Skip to content

[CP Staging] Revert "RevertSplitTransaction fails with UNIQUE constraint: App reuses existing reportActionID instead of generating a new one" #82713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 1 commit into from
Feb 17, 2026
Merged

[CP Staging] Revert "RevertSplitTransaction fails with UNIQUE constraint: App reuses existing reportActionID instead of generating a new one" #82713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/IOU/Split.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,7 +1226,7 @@ function updateSplitTransactions({
newReportTotal: reportTotals.get(splitExpense?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)) ?? 0,
newNonReimbursableTotal: (transactionReport?.nonReimbursableTotal ?? 0) - changesInReportTotal,
isSplitExpense: true,
currentReportActionID: !isReverseSplitOperation ? currentReportAction?.reportActionID : undefined,
currentReportActionID: currentReportAction?.reportActionID,
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid reusing existing reportActionID in reverse split

When isReverseSplitOperation is true, this now forwards currentReportAction?.reportActionID into getMoneyRequestInformation, which makes the optimistic IOU action reuse an ID that already exists on the original split action. That reused ID is then propagated as splitReportActionID for REVERT_SPLIT_TRANSACTION, so reverse-splitting can hit a duplicate report-action insert (UNIQUE constraint) and fail instead of completing.

Useful? React with 👍 / 👎.

isASAPSubmitBetaEnabled,
currentUserAccountIDParam: currentUserPersonalDetails?.accountID,
currentUserEmailParam: currentUserPersonalDetails?.login ?? '',
Expand Down
Loading