fix: close modal once navigate to share flow#82474
Merged
lakchote merged 2 commits intoExpensify:mainfrom Feb 18, 2026
Merged
Conversation
melvin-bot
bot
requested review from
heyjennahay and
situchan
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); | ||
|
|
||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
❌ CLEAN-REACT-PATTERNS-4 (docs)
This component now has multiple useEffect hooks handling unrelated concerns (error alerts, app state management, file processing, and modal closing), making it difficult to modify one concern without touching others.
Suggested fix: Extract the modal closing logic into a focused custom hook to improve separation of concerns:
// useCloseModalOnMount.ts
function useCloseModalOnMount() {
useEffect(() => {
closeModal();
}, []);
}
// In ShareRootPage.tsx
function ShareRootPage() {
useCloseModalOnMount();
// ... rest of component
}This makes the intent clear and isolates the modal closing concern from other initialization logic.
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
There was a problem hiding this comment.
This is definitely too strict for a one-liner.
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, []); | ||
|
|
||
| useEffect(() => { |
Contributor
There was a problem hiding this comment.
❌ PERF-16 (docs)
The closeModal() call is not idempotent and lacks a guard mechanism. In React Strict Mode (development), this Effect will execute twice, potentially closing two modals instead of one. While close() has a guard for when no modals exist (closeModals.length === 0), it would still attempt to close two modals if both are present during initialization.
Suggested fix: Add a module-level guard to ensure this runs only once:
let didCloseModal = false;
function ShareRootPage() {
useEffect(() => {
if (didCloseModal) {
return;
}
didCloseModal = true;
closeModal();
}, []);
// ... rest of component
}Alternatively, if this is truly idempotent (safe to call twice), please add a comment explaining why.
Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
4 tasks
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safari |
situchan
approved these changes
Feb 18, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
76 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.22-0 🚀
|
7 tasks
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
16 tasks
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.22-4 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #76763
PROPOSAL: #76763 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include ""[No QA].""
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
I am unable to login in this platform. I will update video later
Android: mWeb Chrome
This feature isn't available in this platform
iOS: Native
Screen.Recording.2026-02-14.at.06.21.04.mov
iOS: mWeb Safari
This feature isn't available in this platform
MacOS: Chrome / Safari
This feature isn't available in this platform