Skip to content

feat: [CFI] Allow Multi-Line Row Wrapping in Expense Previews (Classic Parity)#82967

Merged
dangrous merged 1 commit intoExpensify:mainfrom
TaduJR:feat-CFI-Allow-Multi-Line-Row-Wrapping-in-Expense-Previews-Classic-Parity
Feb 27, 2026
Merged

feat: [CFI] Allow Multi-Line Row Wrapping in Expense Previews (Classic Parity)#82967
dangrous merged 1 commit intoExpensify:mainfrom
TaduJR:feat-CFI-Allow-Multi-Line-Row-Wrapping-in-Expense-Previews-Classic-Parity

Conversation

@TaduJR
Copy link
Contributor

@TaduJR TaduJR commented Feb 19, 2026

Explanation of Change

Expense preview rows in New Expensify truncate merchant, description, category, and tag text after a single line with ellipsis. In Expensify Classic, these fields wrap across multiple lines. This PR adds Classic Parity by allowing up to 2 lines of text before truncating.

Fixed Issues

$ #81419
PROPOSAL: #81419 (comment)

Tests

Prerequisites:

  • Have a workspace with categories and tags enabled
  • Create several expenses with long merchant names, long descriptions, long category names, and long tag names (text should be long enough to exceed one line in the table)
  • Submit these expenses in a report containing multiple expenses

Expenses page (wide layout):

  1. Navigate to the Reports -> Expenses page
  2. Verify that merchant, description, category, and tag columns wrap up to 2 lines before showing "..." at the end
  3. Hover over text that is cut off and verify a tooltip appears showing the full text
  4. Hover over text that is NOT cut off and verify no tooltip appears
  5. Verify that From/To columns still show names on a single line (no wrapping)

Expenses page (narrow layout):
6. Resize the browser window to a narrow width
7. Verify that merchant/description, category, and tag text also wraps up to 2 lines before truncating

Report detail view:
8. Navigate to Reports -> Reports and open the report containing the expenses created above
9. Verify that merchant/description, category, and tag text in the expense rows wraps up to 2 lines before truncating
10. Verify that short text that fits on one line displays normally with no extra spacing

  • Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native Screenshot 2026-02-22 at 5 12 02 in the afternoon
Android: mWeb Chrome Screenshot 2026-02-22 at 5 17 59 in the afternoon
iOS: Native Screenshot 2026-02-22 at 5 10 15 in the afternoon
iOS: mWeb Safari Screenshot 2026-02-22 at 5 10 51 in the afternoon
MacOS: Chrome / Safari Screenshot 2026-02-22 at 5 08 03 in the afternoon

@melvin-bot
Copy link

melvin-bot bot commented Feb 19, 2026

@dannymcclain @hoangzinh One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from a team and dangrous and removed request for a team February 19, 2026 17:04
@melvin-bot
Copy link

melvin-bot bot commented Feb 19, 2026

@dannymcclain @dangrous One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@TaduJR TaduJR marked this pull request as draft February 19, 2026 17:04
@codecov
Copy link

codecov bot commented Feb 19, 2026

Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally code looks good, will hold on real review until design takes a look!

@dannymcclain dannymcclain requested a review from a team February 20, 2026 16:18
@dannymcclain
Copy link
Contributor

Let us know when it's ready for design review and we can spin up an ad hoc build 🚀

@TaduJR TaduJR marked this pull request as ready for review February 22, 2026 14:20
@shawnborton
Copy link
Contributor

Will run a quick build 🚀

@github-actions
Copy link
Contributor

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@shawnborton
Copy link
Contributor

I think the idea is to use this for all table cells, right? For example, it seems like this is missing from Report titles:
CleanShot 2026-02-23 at 10 37 05@2x

@dannymcclain
Copy link
Contributor

I think the idea is to use this for all table cells, right?

Agree 🤝

@hoangzinh
Copy link
Contributor

@TaduJR Can you also add multi-line for report title?

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 25, 2026

@shawnborton

Should we also add two line support for long-workspace names?

Screen.Recording.2026-02-25.at.11.05.58.in.the.morning.mov

@TaduJR

This comment was marked as off-topic.

@hoangzinh
Copy link
Contributor

Also what about To, and From

@TaduJR To/From is out of scope for now (ref #81419 (comment))

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 25, 2026

@TaduJR To/From is out of scope for now (ref #81419 (comment))

Ahh forgot that.

Thanks @hoangzinh!

So only workspaces needs confirmation.

@shawnborton
Copy link
Contributor

Should we also add two line support for long-workspace names?

I would say no, because we are showing the avatar. So let's treat it like From/To. cc @Expensify/design for viz.

@hoangzinh
Copy link
Contributor

@TaduJR The code looks good to me. However, I found a small bug: when hovering over a long tax rate, it doesn't display a tooltip.

Screen.Recording.2026-02-26.at.08.26.12.mov

@hoangzinh
Copy link
Contributor

hoangzinh commented Feb 26, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-02-26.at.08.41.04.mov
Android: mWeb Chrome
Screen.Recording.2026-02-26.at.08.42.57.mov
iOS: HybridApp
Screen.Recording.2026-02-26.at.08.49.57.mov
iOS: mWeb Safari
Screen.Recording.2026-02-26.at.08.51.44.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-27.at.15.28.15.mov

@hoangzinh
Copy link
Contributor

Navigate to the Expenses page
Navigate to Reports

@TaduJR when you say "Expenses page", do you mean "Reports -> Expenses"? Also for "Navigate to Reports".

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 26, 2026

@TaduJR when you say "Expenses page", do you mean "Reports -> Expenses"? Also for "Navigate to Reports".

Yes, I clarified it.

@TaduJR
Copy link
Contributor Author

TaduJR commented Feb 26, 2026

@TaduJR The code looks good to me. However, I found a small bug: when hovering over a long tax rate, it doesn't display a tooltip.

@hoangzinh

Hmm It's working on my side. You are still able to repo

Mac-Chrome.mp4

@github-actions
Copy link
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@TaduJR TaduJR force-pushed the feat-CFI-Allow-Multi-Line-Row-Wrapping-in-Expense-Previews-Classic-Parity branch from 4a75645 to c10ecf1 Compare February 27, 2026 07:35
@hoangzinh
Copy link
Contributor

Hmm It's working on my side. You are still able to repo

@TaduJR no I couldn't. It seems an issue on my local. All works for me now.

Copy link
Contributor

@hoangzinh hoangzinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

@melvin-bot melvin-bot bot requested a review from dangrous February 27, 2026 08:31
@dangrous dangrous merged commit f169918 into Expensify:main Feb 27, 2026
30 checks passed
@github-actions
Copy link
Contributor

🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 2, 2026

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.28-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mitarachim
Copy link

Deploy Blocker #83987 was identified to be related to this PR.

@mitarachim
Copy link

Deploy Blocker #83989 was identified to be related to this PR.

@jponikarchuk
Copy link

Deploy Blocker #84032 was identified to be related to this PR.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 4, 2026

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.30-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 4, 2026

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants