[CP Staging] fix: revert multi-line wrapping in narrow layout and transaction preview by TaduJR · Pull Request #84047 · Expensify/App

TaduJR · 2026-03-03T15:57:08Z

Explanation of Change

Reverts out-of-scope changes from #82967 that caused three deploy blockers.

The original issue only required multi-line wrapping on large screen table rows (design scope). This PR reverts:

TransactionPreviewContent back to single line ($ [Due for payment 2026-03-13] [$250] Expense - Amount in the split preview is outside the preview when description is long #83987, [Due for payment 2026-03-13] [$250] Expense - Category and tag icon have different alignment on expense preview and expense row #83989) — chat preview wrapping caused amount overflow and icon alignment mismatch.
Narrow layout back to single line ($ [Due for payment 2026-03-13] [$250] Merge - Amount is cutted off while merging expenses with long merchant, tags and category. #84032) — caused amount clipping and tag/category overlap in the merge view.

Large screen table wrapping remains intact.

Fixed Issues

$ #83987
$ #83989
$ #84032
PROPOSAL:

Tests

#83987 — Split preview amount overflow

Open a 1:1 DM with any user.
Click + > Split expense > Manual.
Enter amount > Next.
On confirm page, enter a long description and save.
Click Split.
Verify the amount stays inside the preview.

#83989 — Icon alignment mismatch
Prerequisite: Workspace with long category and tag names.

Go to workspace chat.
Create two expenses with long category and long tag.
Verify category/tag icons are aligned consistently in the expense preview.
Open the expense report and verify icons align the same as in the preview.

#84032 — Merge view amount/tag clipping
Prerequisite: Workspace with long category, tag, and merchant names.

Open any workspace chat.
Create two manual expenses with long merchant names, tags and categories.
Open the report, select one expense, click dropdown > Merge.
Verify the amount is fully visible and tag icon does not overlap category in the eligible expenses list.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screenshot 2026-03-03 at 7 26 42 in the evening

Screenshot 2026-03-03 at 7 26 57 in the evening

Screenshot 2026-03-03 at 7 27 10 in the evening

iOS: mWeb Safari

MacOS: Chrome / Safari

Screenshot 2026-03-03 at 7 06 32 in the evening

Screenshot 2026-03-03 at 7 06 46 in the evening

Screenshot 2026-03-03 at 7 08 29 in the evening

melvin-bot · 2026-03-03T15:57:16Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-03T16:05:07Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ents/TransactionItemRow/DataCells/CategoryCell.tsx	`100.00% <ø> (ø)`
...ents/TransactionItemRow/DataCells/MerchantCell.tsx	`100.00% <100.00%> (ø)`
...omponents/TransactionItemRow/DataCells/TagCell.tsx	`100.00% <ø> (ø)`
src/components/TransactionItemRow/index.tsx	`86.66% <100.00%> (ø)`
...m/TransactionPreview/TransactionPreviewContent.tsx	`76.84% <33.33%> (ø)`
... and 50 files with indirect coverage changes

hoangzinh · 2026-03-03T16:15:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-03.at.23.20.06.mov

Android: mWeb Chrome

Screen.Recording.2026-03-03.at.23.22.19.mov

iOS: HybridApp

Screen.Recording.2026-03-03.at.23.38.55.mov

iOS: mWeb Safari

Screen.Recording.2026-03-03.at.23.30.10.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-03.at.23.17.12.mov

src/components/TransactionItemRow/DataCells/MerchantCell.tsx

hoangzinh · 2026-03-03T16:29:56Z

@TaduJR can you add "[CP Staging]" as a prefix for this PR? TY

hoangzinh

LGTM 🙏

MonilBhavsar

Thanks for quick turnaround!

github-actions · 2026-03-03T16:57:56Z

🚧 @MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-03T17:03:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84047.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9b53e33-cd00326-531110118a42f3e9cebac0cc4a2096b292a43078/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9b53e33-cd00326-4b9f42bb81f7ef29e3f1f12df41380b152fd6bc9/index.html

Web 🕸️
https://84047.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-03T17:05:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…rapping-in-Expense-Previews-Classic-Parity [CP Staging] fix: revert multi-line wrapping in narrow layout and transaction preview (cherry picked from commit 9b53e33) (cherry-picked to staging by blimpich)

OSBotify · 2026-03-03T17:55:15Z

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.28-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T03:21:22Z

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.30-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:11:05Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-04T18:37:59Z

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.31-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T03:50:35Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

TaduJR added 2 commits March 3, 2026 18:01

revert: remove 2-line wrapping from TransactionPreviewContent

021cdf8

fix: revert narrow layout to single-line truncation to fix merge view

d03b5d0

TaduJR requested review from a team as code owners March 3, 2026 15:57

melvin-bot bot assigned TaduJR Mar 3, 2026

melvin-bot bot requested review from hoangzinh and removed request for a team March 3, 2026 15:57

melvin-bot bot requested review from heyjennahay and removed request for a team March 3, 2026 15:57

hoangzinh reviewed Mar 3, 2026

View reviewed changes

src/components/TransactionItemRow/DataCells/MerchantCell.tsx Outdated Show resolved Hide resolved

TaduJR changed the title ~~fix: revert multi-line wrapping in narrow layout and transaction preview~~ [CP Staging] fix: revert multi-line wrapping in narrow layout and transaction preview Mar 3, 2026

fix: improve MerchantCell style readability

ee19038

hoangzinh approved these changes Mar 3, 2026

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar March 3, 2026 16:40

MonilBhavsar approved these changes Mar 3, 2026

View reviewed changes

MonilBhavsar merged commit 9b53e33 into Expensify:main Mar 3, 2026
31 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 3, 2026

OSBotify mentioned this pull request Mar 3, 2026

Deploy Checklist: New Expensify 2026-03-02 #83947

Closed

hoangzinh mentioned this pull request Mar 5, 2026

[$250] [CFI] Allow Multi-Line Row Wrapping in Expense Previews (Classic Parity) #81419

Open

7 tasks

Conversation

TaduJR commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 3, 2026

Uh oh!

codecov bot commented Mar 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hoangzinh commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

hoangzinh commented Mar 3, 2026

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

OSBotify commented Mar 3, 2026

Uh oh!

OSBotify commented Mar 3, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TaduJR commented Mar 3, 2026 •

edited

Loading

codecov bot commented Mar 3, 2026 •

edited by github-actions bot

Loading

hoangzinh commented Mar 3, 2026 •

edited

Loading