[Odometer] Redirecting to inbox on photo capture after App reload on OdometerImage screen

[jakubkalinski0]

Explanation of Change

After capturing an odometer photo, the user was being redirected to the wrong screen - to Inbox on native after app reload, or back to the Odometer creation tab instead of the Confirmation screen on web.

The bug affects both native and web, and manifests in two distinct ways depending on the platform and entry point:

• Native (reported deploy blocker): Navigation.goBack() in IOURequestStepOdometerImage had no fallback route. Before app reload, this works fine because the previous screen is on the navigation stack. After reload (e.g. after granting camera permissions via Settings and returning), the stack is gone and goBack() falls through to Inbox.

• Web (variation of the same bug): The back navigation route was always hardcoded to DISTANCE_REQUEST_CREATE_TAB_ODOMETER regardless of where the user came from. So when the flow was Confirmation screen -> Edit odometer image -> Replace/take photo, the user was brought back to the Odometer creation tab instead of back to the Confirmation screen.

Additionally, a single MONEY_REQUEST_RECEIPT_PREVIEW route was shared between regular receipt preview and odometer image preview. This meant when we navigated to ODOMETER_IMAGE through "Replace" button in the odometer image preview we couldn't distinguish whether it was opened from the creation flow or from the confirmation screen.

This PR is a blocker for image stitching feature testing - it's impossible to verify that images are properly stitched when the "Replace" flow from the confirmation screen navigates to the wrong destination.

Changes made:

• Explicit back navigation in IOURequestStepOdometerImage: Instead of Navigation.goBack() (which relies on stack presence), navigateBack now calls Navigation.goBack(goBackRoute) with an explicit target - either MONEY_REQUEST_STEP_DISTANCE_ODOMETER (when editing from confirmation) or DISTANCE_REQUEST_CREATE_TAB_ODOMETER (normal creation flow).

• Pass context through route params: ODOMETER_IMAGE route now carries isEditingConfirmation so that the camera screen always knows where to navigate back to, regardless of app reload state.

• Separate routes for odometer image previews: Added new route (MONEY_REQUEST_ODOMETER_PREVIEW with isEditingConfirmation) instead of reusing MONEY_REQUEST_RECEIPT_PREVIEW. This allows us to properly pass isEditingConfirmation to ODOMETER_IMAGE to correctly determine whether to navigate back to the creation flow or the confirmation screen.

• Transaction.ts type fix: Corrected odometerStartImage/odometerEndImage types from File | string to FileObject | string to match the actua values used on web (a FileObject with a .uri property is stored, not a raw File).

• Removed premature blob URL cleanup: The useEffect cleanup calls in IOURequestStepDistanceOdometer that revoked blob URLs on component unmount were removed (they caused the image to become inaccessible when navigating to the odometer screen from confirmation plus they are redundant).

Fixed Issues

$ #83526
PROPOSAL: N/A

Tests

On mobile:

Caution

Use an Android emulator or physical iOS device for testing - the iOS simulator doesn't support camera functionality.

Prerequisites: Disable camera permissions for Expensify (set to "Ask every time").

Main bug fix (the deploy blocker):

1. Press FAB -> Track distance -> Odometer tab
2. Press on the Start reading thumbnail
3. Press Continue -> when prompted, press Don't allow
4. Press Continue again -> when prompted with the Settings redirect dialog, press Settings
5. In device Settings, enable camera for Expensify -> navigate back to the app
6. Verify that you are back on the odometer image screen and take a photo
7. Verify you are brought back to the Odometer tab with the thumbnail updated, NOT to the Inbox

Tip

Instead of doing steps 3-6 you can simply grant access to the camera and reload the App -> it's actually the reload of the App after we come back from Settings that is the problematic part not the camera permissions itself

Back navigation - creation flow:

8. Press on a thumbnail -> press Continue -> grant camera permission -> take a photo
9. Verify you are back on the Odometer tab
10. Press the thumbnail again -> verify the Image Preview opens correctly
11. Press Replace -> verify you are brought to the odometer image screen
12. Take a photo -> verify you are back on the Odometer tab (not confirmation)

Back navigation - confirmation/edit flow:

13. Fill in odometer readings and only one image -> proceed to the Confirmation screen
14. Go to Distance -> press the empty thumbnail of the odometer image -> verify you land on the odometer image screen
15. Press the back arrow -> verify you are back on the Distance screen (not the Odometer creation page)
16. Repeat step 14 but take a new photo instead -> verify you are back on the Distance screen with the image updated
17. Press the filled thumbnail on the distance screen -> verify Image Preview opens
18. Press Replace -> verify you are brought to the odometer image screen and after taking a photo you land back on the distance screen

On web:

1. Press FAB -> Track distance -> Odometer tab
2. Press on the Start reading thumbnail
3. Reload the app
4. Verify that you are back on the odometer image screen and add a photo
5. Verify you are brought back to the Odometer tab with the thumbnail updated, NOT to the Inbox

Back navigation - creation flow:

6. Press on a thumbnail -> add a photo
7. Verify you are back on the Odometer tab
8. Press the thumbnail again -> verify the Image Preview opens correctly
9. Press Replace -> verify you are brought to the odometer image screen
10. Add a photo -> verify you are back on the Odometer tab (not confirmation)

Back navigation - confirmation/edit flow:

11. Fill in odometer readings and only one image -> proceed to the Confirmation screen
12. Go to Distance -> press the empty thumbnail of the odometer image -> verify you land on the odometer image screen
13. Press the back arrow -> verify you are back on the Distance screen (not the Odometer tab)
14. Repeat step 14 but add a new photo instead -> verify you are back on the Distance screen with the image updated
15. Press the filled thumbnail on the distance screen -> verify Image Preview opens
16. Press Replace -> verify you are brought to the odometer image screen and after taking a photo you land back on the distance screen

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))\
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS needs to be tested on a physcical device

Android: Native

Steps 1 through 7:

androidnative1to7.webm

Steps 8 through 12:

androidnative8to12.webm

Steps 13 through 18:

androidnative13to18.webm

Android: mWeb Chrome

Steps 1 through 7:

androidweb1to7.webm

Steps 8 through 12:

androidweb8to12.webm

Steps 13 through 18:

androidweb13to18.webm

MacOS: Chrome / Safari

Steps 1 through 5:

web1to5.mov

Steps 6 through 10:

web6to10.mov

Steps 11 through 16:

werb11to16.mov

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	100.00% <ø> (ø)
src/libs/Navigation/AppNavigator/AuthScreens.tsx	80.64% <100.00%> (+0.21%)	⬆️
...ateRootStackNavigator/GetStateForActionHandlers.ts	37.31% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	75.00% <ø> (ø)
...request/step/IOURequestStepOdometerImage/index.tsx	0.00% <0.00%> (ø)
src/pages/media/AttachmentModalScreen/index.tsx	27.77% <0.00%> (ø)
...alScreen/routes/TransactionReceiptModalContent.tsx	0.00% <0.00%> (ø)
.../step/IOURequestStepOdometerImage/index.native.tsx	0.00% <0.00%> (ø)
...ou/request/step/IOURequestStepDistanceOdometer.tsx	0.00% <0.00%> (ø)
src/ROUTES.ts	15.15% <0.00%> (-0.09%)	⬇️
... and 75 files with indirect coverage changes

[melvin-bot]

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Julesssss]

I think if user replaces images we're no longer clearing it. Maybe we can do that before we set odometerStartImage to a new blob?

[github-actions]

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[Julesssss]

Actually we already do that in setMoneyRequestOdometerImage

Oh great, thanks for pointing that out.

[Julesssss]

In that case I think we're ready for @DylanDylann's review now

[DylanDylann]

I need more time to complete my review. I will try to complete it before the new week

[DylanDylann]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09eb6c7862

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[DylanDylann]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[github-actions]

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[DylanDylann]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-10.at.01.20.50.mov

Android: mWeb Chrome

Screen.Recording.2026-03-10.at.01.15.23.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2026-03-10.at.01.14.43.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-10.at.01.13.38.mov

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83668.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b0c18cc-58fa64b-c647a2faa4a1a9e42345234520851ea19f938f3e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b0c18cc-58fa64b-824a40941725b1fe25e9da743b04fce1e9a46498/index.html

Web 🕸️
https://83668.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[DylanDylann]

LGTM

[Julesssss]

Testing well. I just noticed that the 'replace' button is cutoff but that's a separate issue

[github-actions]

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83668.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-55c834e-227a934-ac3e292e8a66adc3834ef029f5442a5af5a3c645/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-55c834e-227a934-ca6a4964b40db82d1a603735ace9538a52b17627/index.html

Web 🕸️
https://83668.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.34-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[JmillsExpensify]

Sorry I didn't get to this in time! All looks good for product.

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅