[No QA] Remove unused eslint-disable directives by roryabraham · Pull Request #83798 · Expensify/App

roryabraham · 2026-02-28T17:45:31Z

Explanation of Change

Upgrades eslint-config-expensify to a version that includes reportUnusedDisableDirectives: 'error' in the base config (defaults to warn), temporarily removed the local override in eslint.config.mjs that previously disabled this check, and auto-fixes all ~1100 stale eslint-disable directives across the codebase.

Fixed Issues

N/A - tooling improvement

Tests

Verify that no errors appear in the JS console

Run npx eslint src/ tests/ .github/ scripts/ and verify no Unused eslint-disable directive errors appear

Offline tests

N/A - no runtime behavior change

QA Steps

N/A - no runtime behavior change. This is a lint-only change.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A - no UI changes

melvin-bot · 2026-02-28T17:45:36Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

codecov · 2026-02-28T17:59:00Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.30% <ø> (ø)`
src/ROUTES.ts	`15.34% <ø> (ø)`
...etAwareScrollView/useActionSheetKeyboardSpacing.ts	`0.00% <ø> (ø)`
src/components/AddPlaidBankAccount.tsx	`0.00% <ø> (ø)`
src/components/AddressSearch/index.tsx	`48.03% <ø> (ø)`
...ons/AutoCompleteSuggestionsPortal/index.native.tsx	`0.00% <ø> (ø)`
...ompleteSuggestions/BaseAutoCompleteSuggestions.tsx	`0.00% <ø> (ø)`
src/components/BlockingViews/FullPageErrorView.tsx	`0.00% <ø> (ø)`
src/components/Button/index.tsx	`90.78% <ø> (ø)`
...kground/updateStatusBarAppearance/index.android.ts	`0.00% <ø> (ø)`
... and 192 more
... and 14 files with indirect coverage changes

melvin-bot · 2026-03-02T23:30:52Z

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

Upgrade eslint-config-expensify to 2.0.106 which sets reportUnusedDisableDirectives: 'error', and auto-fix all stale directives across the codebase. Made-with: Cursor

Some rules (no-restricted-syntax, @typescript-eslint/no-deprecated, no-default-id-values, no-restricted-imports) are only active in the changed-files ESLint config. Restore the disable directives that were present on main and are still needed for those rules. Made-with: Cursor

melvin-bot · 2026-03-05T00:33:38Z

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2026-03-05T00:35:59Z

The rule that's failing in the main config needs to be disabled, one sec

The shared eslint-config-expensify sets this to 'error', but the main config must override it to 'off' since some disable directives are only needed by the stricter eslint.changed.config.mjs rules. Also restore the no-empty disable comment in BaseAutoCompleteSuggestions. Made-with: Cursor

roryabraham · 2026-03-05T01:51:51Z

Just to be clear, because this file touches 300+ files, it's not my intention to fix all the lint-changed errors, because they are pre-existing and many of them are risky/non-trivial to fix

aldo-expensify · 2026-03-05T01:58:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-03-05T01:59:31Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-03-05T02:00:09Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-05T02:06:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83798.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d79c479-a1e5d7f-03d6ee73093e1be2d0113da75608833ab6220e1e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d79c479-a1e5d7f-565e6abbafe7102ba036c3d3a04325945964166d/index.html

Web 🕸️
https://83798.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-05T02:10:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

TaduJR · 2026-03-05T13:39:04Z

src/libs/Navigation/linkingConfig/config.ts

                    // If params are defined, but reportID is explicitly undefined, we will get the url /r/undefined.
                    // We want to avoid that situation, so we will return an empty string instead.
                    parse: {
-                        // eslint-disable-next-line


Hi @roryabraham

This suppression removal causing ESLint fail here on PR #80020

JakubKorytko · 2026-03-05T13:48:47Z

src/libs/actions/IOU/index.ts

            key: `${ONYXKEYS.COLLECTION.NEXT_STEP}${iou.report.reportID}`,
            onyxMethod: Onyx.METHOD.SET,
            // buildOptimisticNextStep is used in parallel
-            // eslint-disable-next-line @typescript-eslint/no-deprecated


This and other no-deprecated removals in this file caused a huge ESLint fail on this PR: https://github.com/Expensify/App/actions/runs/22720110148/job/65879696179?pr=84069

i.e.

buildNextStepNew is deprecated.

runAfterInteractions is deprecated.

translateLocal is deprecated.

getPolicy is deprecated.

getPolicyTagsData is deprecated.

The eslint-disable-next-line @typescript-eslint/no-deprecated comments were removed in a recent cleanup (#83798) but only partially restored. This restores the remaining 28 missing directives that are needed for the Changed files ESLint check to pass. Co-authored-by: DylanDylann <DylanDylann@users.noreply.github.com>

OSBotify · 2026-03-06T04:15:18Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T22:44:31Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned roryabraham Feb 28, 2026

roryabraham mentioned this pull request Mar 1, 2026

Report unused eslint-disable directives as errors Expensify/eslint-config-expensify#180

Merged

3 tasks

roryabraham force-pushed the rory-report-unused-disable-directives branch 2 times, most recently from 303ce76 to 6ac4ea9 Compare March 2, 2026 23:28

roryabraham changed the title ~~[No QA] Remove unused eslint-disable directives~~ [HOLD][No QA] Remove unused eslint-disable directives Mar 2, 2026

roryabraham force-pushed the rory-report-unused-disable-directives branch 7 times, most recently from d177dd3 to 0f70f0f Compare March 4, 2026 22:55

roryabraham changed the title ~~[HOLD][No QA] Remove unused eslint-disable directives~~ [No QA] Remove unused eslint-disable directives Mar 4, 2026

roryabraham added 3 commits March 4, 2026 15:31

Upgrade eslint-config-expensify to 2.0.106

e364c5b

Remove unused eslint-disable directives

b70f95b

Upgrade eslint-config-expensify to 2.0.106 which sets reportUnusedDisableDirectives: 'error', and auto-fix all stale directives across the codebase. Made-with: Cursor

roryabraham force-pushed the rory-report-unused-disable-directives branch from d6fcf07 to c4db6c4 Compare March 5, 2026 00:23

roryabraham marked this pull request as ready for review March 5, 2026 00:33

roryabraham requested review from a team as code owners March 5, 2026 00:33

melvin-bot bot requested review from MarioExpensify and trjExpensify and removed request for a team March 5, 2026 00:33

aldo-expensify approved these changes Mar 5, 2026

View reviewed changes

roryabraham merged commit d79c479 into main Mar 5, 2026
40 of 42 checks passed

roryabraham deleted the rory-report-unused-disable-directives branch March 5, 2026 01:59

melvin-bot bot added the Emergency label Mar 5, 2026

roryabraham removed the Emergency label Mar 5, 2026

MelvinBot mentioned this pull request Mar 5, 2026

Fix trackExpense to include odometer readings in API params #84254

Merged

53 tasks

linhvovan29546 mentioned this pull request Mar 5, 2026

feat: Handle the REJECTEDTOSUBMITTER #84053

Merged

53 tasks

TaduJR reviewed Mar 5, 2026

View reviewed changes

JakubKorytko reviewed Mar 5, 2026

View reviewed changes

JakubKorytko mentioned this pull request Mar 5, 2026

[Metrics] Add submit-to-destination-visible span for expense creation flows #84069

Merged

50 tasks

roryabraham mentioned this pull request Mar 5, 2026

Revert "[No QA] Remove unused eslint-disable directives" #84299

Merged

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

Conversation

roryabraham commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 28, 2026

Uh oh!

codecov bot commented Feb 28, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 2, 2026

Uh oh!

melvin-bot bot commented Mar 5, 2026

Uh oh!

roryabraham commented Mar 5, 2026

Uh oh!

roryabraham commented Mar 5, 2026

Uh oh!

aldo-expensify commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 5, 2026

Uh oh!

TaduJR Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

JakubKorytko Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roryabraham commented Feb 28, 2026 •

edited

Loading

codecov bot commented Feb 28, 2026 •

edited by github-actions bot

Loading

aldo-expensify commented Mar 5, 2026 •

edited

Loading

JakubKorytko Mar 5, 2026 •

edited

Loading