Skip to content

Revert "[No QA] Remove unused eslint-disable directives"#84299

Merged
roryabraham merged 1 commit intomainfrom
revert-83798-rory-report-unused-disable-directives
Mar 5, 2026
Merged

Revert "[No QA] Remove unused eslint-disable directives"#84299
roryabraham merged 1 commit intomainfrom
revert-83798-rory-report-unused-disable-directives

Conversation

@roryabraham
Copy link
Contributor

Reverts #83798

@roryabraham roryabraham requested review from a team as code owners March 5, 2026 18:24
@melvin-bot melvin-bot bot requested a review from trjExpensify March 5, 2026 18:24
@melvin-bot
Copy link

melvin-bot bot commented Mar 5, 2026

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

@melvin-bot melvin-bot bot requested review from mollfpr and removed request for a team March 5, 2026 18:24
@melvin-bot
Copy link

melvin-bot bot commented Mar 5, 2026

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@roryabraham
Copy link
Contributor Author

Skipping checklists for straight revert

@roryabraham roryabraham merged commit c240fa2 into main Mar 5, 2026
38 of 41 checks passed
@roryabraham roryabraham deleted the revert-83798-rory-report-unused-disable-directives branch March 5, 2026 18:31
@melvin-bot melvin-bot bot added the Emergency label Mar 5, 2026
@melvin-bot
Copy link

melvin-bot bot commented Mar 5, 2026

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@codecov
Copy link

codecov bot commented Mar 5, 2026

@OSBotify
Copy link
Contributor

OSBotify commented Mar 5, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.32-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2026

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants