Conversation
… container not focusable or operable"
melvin-bot
bot
requested review from
heyjennahay and
madmax330
and removed request for
a team
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e9d78dcf4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+458
to
462
| accessibilityLabel={accessibilityLabel} | ||
| style={[styles.mh5]} | ||
| disabled={item.disabled} | ||
| onPress={item.action} | ||
| sentryLabel={CONST.SENTRY_LABEL.WORKSPACE.WORKSPACE_MENU_ITEM} |
There was a problem hiding this comment.
This change makes the outer row PressableWithoutFeedback the accessible/onPress container for the whole item, while the ThreeDotsMenu remains nested inside it. In screen-reader mode (VoiceOver/TalkBack), that parent container becomes the primary focusable element, so the nested More button is not reliably focusable/operable and users cannot open workspace actions from the list. This reintroduces the accessibility regression for users navigating by assistive technology.
Useful? React with 👍 / 👎.
This comment has been minimized.
This comment has been minimized.
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
francoisl
approved these changes
Mar 3, 2026
blimpich
deleted the
revert-83324-fix-Accessibility-Tracking-Make-Element-Focusable
branch
Contributor
|
🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
OSBotify
pushed a commit
that referenced
this pull request
Mar 3, 2026
…ty-Tracking-Make-Element-Focusable (cherry picked from commit 9b114da) (cherry-picked to staging by blimpich)
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.28-1 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.30-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.3.31-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://expensify.slack.com/archives/C01GTK53T8Q/p1772497533864769?thread_ts=1772496949.298269&cid=C01GTK53T8Q
Reverts #83324
$ #83965
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari