-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix: selected option is announced without selected state #83996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e19c59f
fix: selected option is announced without selected state
daledah c853934
fix lint
daledah cd9bfa5
Merge branch 'main' into follow/74845
daledah 8794158
fix ts
daledah d9d831a
resolve conflict
daledah 63f09c7
resolve conflict
daledah d1fc573
fix comments
daledah 26c6ca5
remove style
daledah b3f1e42
Merge branch 'main' into follow/74845
daledah 26a64f8
add web condition and missing role
daledah b02c7da
fix test
daledah 6a169ff
git push
daledah 3bfd03f
create a new util function
daledah eb4a7a6
fix ts
daledah 38a35ea
remove useless prop and test id
daledah 3a6b1b2
Merge branch 'main' into follow/74845
daledah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import type {GetListboxRole} from './types'; | ||
|
|
||
| const getListboxRole: GetListboxRole = () => undefined; | ||
|
|
||
| // eslint-disable-next-line import/prefer-default-export | ||
| export {getListboxRole}; | ||
8 changes: 8 additions & 0 deletions
8
src/components/SelectionList/utils/getListboxRole/index.web.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import type {Role} from 'react-native'; | ||
| import CONST from '@src/CONST'; | ||
| import type {GetListboxRole} from './types'; | ||
|
|
||
| const getListboxRole: GetListboxRole = (canSelectMultiple) => (!canSelectMultiple ? (CONST.ROLE.LISTBOX as Role) : undefined); | ||
|
|
||
| // eslint-disable-next-line import/prefer-default-export | ||
| export {getListboxRole}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import type {Role} from 'react-native'; | ||
|
|
||
| type GetListboxRole = (canSelectMultiple: boolean) => Role | undefined; | ||
|
|
||
| // eslint-disable-next-line import/prefer-default-export | ||
| export type {GetListboxRole}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: Why do we eslint disable instead of just using default exports?