fix: Screen Reader: Workspace: 3-dot More button in Workspace container not focusable or operable by TaduJR · Pull Request #84124 · Expensify/App

TaduJR · 2026-03-04T09:24:50Z

Explanation of Change

The parent PressableWithoutFeedback in WorkspacesListPage.tsx defaults to accessible={true}, which groups all children into a single VoiceOver element — making the ThreeDotsMenu invisible to screen readers.

Fix:

Set accessible={false} on the parent and moved accessibility into WorkspacesListRow.tsx — the content area gets its own PressableWithoutFeedback with a descriptive label, while ThreeDotsMenu sits outside it so VoiceOver can focus both independently. Wide layout ThreeDotMenuOrPendingIcon is left untouched to preserve column alignment.

Fixed Issues

$ #77471
$ #79231
$ #83965
PROPOSAL: #79231 (comment)

Tests

VoiceOver (iOS) — #77471 fix:

Open the app on iOS with VoiceOver enabled
Navigate to the Workspaces tab
Swipe right to move through workspace rows
Verify each workspace row is announced with its name, owner, and type
Verify the "More" (3-dot) button is focusable as a separate element right after the workspace row
Double-tap the "More" button and verify the popover menu opens

Column alignment (wide layout) — #82727 regression check:
7. Open the app on web (desktop/wide viewport)
8. Go to the Workspaces list with 2+ workspaces
9. Verify Owner and Workspace Type columns are properly aligned across rows

Arrow click (wide layout) — #82739 regression check:
10. On web (desktop/wide viewport), click the arrow icon on any workspace row
11. Verify it navigates to the workspace page

Padding dead zone (wide layout) — #83965 regression check:
12. On web (desktop/wide viewport), click the empty area above or below the workspace avatar within a row
13. Verify it navigates to the workspace page (same as clicking the row content)

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_Recording_20260224_172300_New.Expensify.Dev.mp4

Android: mWeb Chrome

Screen_Recording_20260224_172721_Chrome.mp4

iOS: Native

Screen.Recording.2026-02-24.at.4.57.28.in.the.afternoon.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-24.at.4.40.07.in.the.afternoon.mov

Screen.Recording.2026-03-04.at.12.23.31.in.the.afternoon.mov

…er not focusable or operable

melvin-bot · 2026-03-04T09:25:00Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…bility-Tracking-Make-Element-Focusable

ikevin127 · 2026-03-05T00:46:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-02-25.at.19.37.43.mov

ikevin127

🟢 LGTM

Note: This is a rework PR following main PR's #83324 revert due to a deploy blocker issue #83965.

yuwenmemon · 2026-03-05T07:46:31Z

Conflicts unfortunately.

…bility-Tracking-Make-Element-Focusable # Conflicts: # src/pages/workspace/WorkspacesListRow.tsx

trjExpensify

Re-work of an accessibility project PR 👍

OSBotify · 2026-03-05T21:51:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-05T22:14:33Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-05T22:19:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84124.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6ccb18f-6ca5122-c6e15790619efd3b4d90d0f43ca40d8854b4476b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6ccb18f-6ca5122-09cdd8485373b0a6c0e2b9ed1b3a66f2b0403fc8/index.html

Web 🕸️
https://84124.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T04:16:30Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nlemma · 2026-03-06T16:58:43Z

Deploy Blocker #84426 was identified to be related to this PR.

The workspaceListRBR style (marginTop: 10, flexDirection: column) was causing vertical misalignment of the RBR indicator in workspace list rows at narrow viewport widths (< 1024px). After PR #84124 moved the ThreeDotsSection outside PressableWithoutFeedback, the marginTop offset no longer aligns with the workspace name row. The parent Views already have alignItemsCenter for proper vertical centering. Co-authored-by: Marco Chávez <marcochavezf@users.noreply.github.com>

OSBotify · 2026-03-06T22:45:43Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

TaduJR added 2 commits March 4, 2026 11:17

fix: Screen Reader: Workspace: 3-dot More button in Workspace contain…

e5e2d77

…er not focusable or operable

fix: Remove orphaned role=cell from action column outside role=row

d3af0b5

TaduJR requested review from a team as code owners March 4, 2026 09:24

melvin-bot bot requested a review from ikevin127 March 4, 2026 09:24

melvin-bot bot assigned TaduJR Mar 4, 2026

melvin-bot bot removed the request for review from a team March 4, 2026 09:24

melvin-bot bot requested review from trjExpensify and removed request for a team March 4, 2026 09:25

TaduJR added 2 commits March 4, 2026 20:25

Merge branch 'main' of https://github.com/TaduJR/App into fix-Accessi…

79daf5c

…bility-Tracking-Make-Element-Focusable

Merge branch 'main' of https://github.com/TaduJR/App into fix-Accessi…

8202c60

…bility-Tracking-Make-Element-Focusable

ikevin127 approved these changes Mar 5, 2026

View reviewed changes

melvin-bot bot requested a review from yuwenmemon March 5, 2026 00:48

yuwenmemon previously approved these changes Mar 5, 2026

View reviewed changes

Merge branch 'main' of https://github.com/TaduJR/App into fix-Accessi…

7d580c2

…bility-Tracking-Make-Element-Focusable # Conflicts: # src/pages/workspace/WorkspacesListRow.tsx

TaduJR dismissed yuwenmemon’s stale review via 7d580c2 March 5, 2026 07:53

trjExpensify approved these changes Mar 5, 2026

View reviewed changes

yuwenmemon merged commit 6ccb18f into Expensify:main Mar 5, 2026
28 checks passed

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

MelvinBot mentioned this pull request Mar 6, 2026

Workspace - RBR is not aligned #84426

Open

7 tasks

MelvinBot mentioned this pull request Mar 6, 2026

Fix RBR indicator vertical alignment in narrow workspace list #84440

Merged

52 tasks

aimane-chnaif mentioned this pull request Mar 6, 2026

Revert "fix: Screen Reader: Workspace: 3-dot More button in Workspace container not focusable or operable" #84451

Draft

rushatgabhane mentioned this pull request Mar 11, 2026

Screen Reader: Workspace: 3-dot More button in Workspace container not focusable or operable #77471

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Screen Reader: Workspace: 3-dot More button in Workspace container not focusable or operable#84124

fix: Screen Reader: Workspace: 3-dot More button in Workspace container not focusable or operable#84124
yuwenmemon merged 5 commits intoExpensify:mainfrom
TaduJR:fix-Accessibility-Tracking-Make-Element-Focusable

TaduJR commented Mar 4, 2026 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

ikevin127 commented Mar 5, 2026 •

edited

Loading

Uh oh!

ikevin127 left a comment

Uh oh!

yuwenmemon commented Mar 5, 2026

Uh oh!

trjExpensify left a comment

Uh oh!

Uh oh!

OSBotify commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

nlemma commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

TaduJR commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 4, 2026

Uh oh!

ikevin127 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

yuwenmemon commented Mar 5, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

nlemma commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TaduJR commented Mar 4, 2026 •

edited

Loading

ikevin127 commented Mar 5, 2026 •

edited

Loading