feat: Update default columns for Expense section on Search page by Eskalifer1 · Pull Request #84461 · Expensify/App

Eskalifer1 · 2026-03-06T21:53:44Z

Explanation of Change

This PR updates the default columns for the Expenses section on the Search page.

Fixed Issues

$#83885
PROPOSAL:#83885 (comment)

Tests

Precondition: Have some created expenses

Go to Reports > Expenses
Make sure you see this default columns:

Receipt
Date
Status
Merchant
From
Category
Amount
Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

83885-web.mov

melvin-bot · 2026-03-06T21:53:51Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

Looking at the PR change... @JS00001 @luacmartins, isn't Tag supposed to still be a default column technically? It's just hidden if none of the expenses have a tag? 🤔

JS00001 · 2026-03-09T11:52:05Z

@trjExpensify I'm not sure, I wasn't in that convo, from the issue it looks like its no longer a default:

Reports > Expenses page. The new default columns we have enabled should be:

Receipt
Type
Date
Status
Merchant
From
Category
Total

trjExpensify · 2026-03-09T11:59:47Z

@shawnborton @JmillsExpensify - we still want to show Tag by default if there's tags on the expenses, right?

shawnborton · 2026-03-09T12:00:36Z

Yup, I would think so.

luacmartins · 2026-03-09T15:39:41Z

Correct, Tag is a "dynamic" column, i.e. it's only shown if at least one transaction has a tag, otherwise we hide the column.

Eskalifer1 · 2026-03-09T17:35:02Z

Hello!

Am I correct in understanding that we need to make the tag field default but dynamic (the logic that was used before)?

Then I have a similar question about the to and description fields. Should they be the same as the tag (default but dynamic), or do we hide them by default?

As mentioned, there is currently a list of default fields, and this list does not include tag, description, and To.

Eskalifer1 · 2026-03-11T12:47:29Z

Bump on question above @JS00001 @trjExpensify @luacmartins

luacmartins · 2026-03-11T16:34:16Z

I'll defer to @trjExpensify on that one. As you mentioned, these columns are not default now, but they do show up if there's data in them.

trjExpensify · 2026-03-12T00:57:42Z

Yeah, we didn't intend to change anything about the dynamic columns logic of Tag and Description in this PR. The scope is to remove Action and To as default columns in the expense table and include Status instead.

The reason for my earlier question was seeing this code change removing Tag from somewhere and I don't know why that was being done, given that it's not in scope of what we're trying to do here:

Eskalifer1 · 2026-03-12T11:36:23Z

Okay. Now I understand, so I'll update the PR today.

Eskalifer1 · 2026-03-13T10:19:20Z

Seems like test is not related to this PR

shawnborton · 2026-03-16T20:03:03Z

What's the latest on this one?

Eskalifer1 · 2026-03-16T20:09:27Z

We are waiting for review from @eVoloshchak

eVoloshchak · 2026-03-16T20:23:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

eVoloshchak · 2026-03-16T22:16:49Z

Make sure you see this default columns:
Receipt
Type

@Eskalifer1, there's no Type column displayed

Eskalifer1 · 2026-03-16T22:26:07Z

Hi @eVoloshchak I think this is expected behavior. Currently, users cannot remove or add the “type” field in custom columns (since the field simply isn't displayed), regardless of whether it's a default column or not.

And in my opinion, this change doesn't apply to this PR.

What I mean is that this list includes all fields that can be used as columns. This applies regardless of whether a column is the default or not (if it is the default, it will simply be selected when no custom columns are applied). And since the “type” field isn't included in this list at all, I don't think it falls within the scope of this PR.

eVoloshchak · 2026-03-16T22:41:18Z

Thanks @Eskalifer1, then let's remove it from testing steps

eVoloshchak

LGTM!

codecov · 2026-03-17T08:25:53Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.60% <ø> (ø)`
src/libs/SearchUIUtils.ts	`69.98% <100.00%> (+0.01%)`	⬆️
src/components/Search/index.tsx	`35.93% <50.00%> (+0.11%)`	⬆️
... and 7 files with indirect coverage changes

shawnborton · 2026-03-17T13:24:32Z

Thanks! All you @flodnv

github-actions · 2026-03-17T14:36:19Z

🚧 @flodnv has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-17T14:41:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84461.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-af79779-9897949-b02c639a30c2720b7ee00acaa38a1d7e6c22c0ff/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-af79779-9897949-603c258d5b36abde9f5919fbb06309ee3f5d067a/index.html

Web 🕸️
https://84461.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-18T13:29:30Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T14:05:31Z

🚀 Deployed to staging by https://github.com/flodnv in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-23T09:26:12Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Eskalifer1 added 2 commits March 6, 2026 22:54

feat: Update default columns for Expense section on Search page

87ff1f3

fix ts error

354e046

Eskalifer1 requested review from a team as code owners March 6, 2026 21:53

melvin-bot bot assigned Eskalifer1 Mar 6, 2026

melvin-bot bot requested review from eVoloshchak and removed request for a team March 6, 2026 21:53

melvin-bot bot requested review from trjExpensify and removed request for a team March 6, 2026 21:53

trjExpensify reviewed Mar 9, 2026

View reviewed changes

Eskalifer1 added 3 commits March 13, 2026 12:02

fix: remove logic for descripion and tag field

ac0070d

Merge remote-tracking branch 'origin' into fix/83885

0a1cda6

fix tests + ts

3eb909e

eVoloshchak approved these changes Mar 16, 2026

View reviewed changes

melvin-bot bot requested a review from flodnv March 16, 2026 22:42

Merge remote-tracking branch 'origin' into fix/83885

3cbe9d7

flodnv approved these changes Mar 17, 2026

View reviewed changes

flodnv merged commit af79779 into Expensify:main Mar 17, 2026
31 checks passed

github-actions bot mentioned this pull request Mar 17, 2026

Investigate workflow job failing on main: chooseDeployActions #85546

Closed

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

melvin-bot bot mentioned this pull request Mar 23, 2026

[Due for payment 2026-03-30] [$250] Update Reports -> Expenses default shown columns #83885

Open

Conversation

Eskalifer1 commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 6, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JS00001 commented Mar 9, 2026

Uh oh!

trjExpensify commented Mar 9, 2026

Uh oh!

shawnborton commented Mar 9, 2026

Uh oh!

luacmartins commented Mar 9, 2026

Uh oh!

Eskalifer1 commented Mar 9, 2026

Uh oh!

Eskalifer1 commented Mar 11, 2026

Uh oh!

luacmartins commented Mar 11, 2026

Uh oh!

trjExpensify commented Mar 12, 2026

Uh oh!

Eskalifer1 commented Mar 12, 2026

Uh oh!

Eskalifer1 commented Mar 13, 2026

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

Eskalifer1 commented Mar 16, 2026

Uh oh!

eVoloshchak commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Mar 16, 2026

Uh oh!

Eskalifer1 commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eVoloshchak commented Mar 16, 2026

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shawnborton commented Mar 17, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Eskalifer1 commented Mar 6, 2026 •

edited

Loading

eVoloshchak commented Mar 16, 2026 •

edited

Loading

Eskalifer1 commented Mar 16, 2026 •

edited

Loading

codecov bot commented Mar 17, 2026 •

edited by github-actions bot

Loading