-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix: resolve deploy blockers and add hover/tooltip to receipt action buttons #84497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
puneetlath
merged 23 commits into
Expensify:main
from
TaduJR:feat-Allow-Multiple-Receipts-to-Be-Attached-to-a-Single-Expense
Mar 18, 2026
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
28e2210
fix: use PressableWithoutFocus on enlarge button to prevent blue focu…
TaduJR 48438e9
fix: validate attachment files and restrict file types on receipt add…
TaduJR 54d5e43
fix: notify transaction thread report for scroll-to-bottom after addi…
TaduJR 98e7b98
fix: show receipt action buttons when hovering during image load
TaduJR 0696ce7
Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…
TaduJR 9f016dd
fix: use hasHoverSupport instead of canUseTouchScreen for receipt act…
TaduJR 1125ca7
Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…
TaduJR 465391b
feat: add hover states to receipt action buttons
TaduJR 1ee46b4
Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…
TaduJR 7463094
feat: add tooltips to receipt action buttons
TaduJR a928724
Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…
TaduJR 56c8916
Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…
TaduJR 8a81fca
fix: reset stale hover states after file picker cancel and improve fi…
TaduJR 41c1ce6
Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…
TaduJR 0b77c55
fix: notify both transaction thread and money request report for scro…
TaduJR 777b863
test: update receipt button accessibility label in tests
TaduJR 031b56c
fix: keep receipt action buttons visible when offline
TaduJR e0863bb
Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…
TaduJR 017a0d6
fix: reset stale hover states after file picker cancel and improve fi…
TaduJR 663da44
Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…
TaduJR 870f9e1
fix: add early return for undefined reportID in notifyNewAction
TaduJR c20fc25
refactor: extract receipt hover utilities into platform-specific files
TaduJR 03f0241
fix: center loading indicator in receipt image container
TaduJR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
172 changes: 109 additions & 63 deletions
172
src/components/ReportActionItem/MoneyRequestReceiptView.tsx
Large diffs are not rendered by default.
Oops, something went wrong.
8 changes: 8 additions & 0 deletions
8
src/components/ReportActionItem/receiptHoverUtils/index.native.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // No-op on native — hover states don't exist on mobile | ||
| function resetButtonHoverState() {} | ||
|
|
||
| function isElementHovered(): boolean { | ||
| return false; | ||
| } | ||
|
|
||
| export {resetButtonHoverState, isElementHovered}; |
16 changes: 16 additions & 0 deletions
16
src/components/ReportActionItem/receiptHoverUtils/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import type {RefObject} from 'react'; | ||
| import type {View} from 'react-native'; | ||
|
|
||
| /** Reset stale button hover/tooltip when file picker opens (browsers don't fire mouseleave). */ | ||
| function resetButtonHoverState(addButtonRef: RefObject<View | null>) { | ||
| const buttonEl = addButtonRef.current as unknown as HTMLElement; | ||
| buttonEl?.dispatchEvent(new PointerEvent('pointerleave')); | ||
| buttonEl?.dispatchEvent(new MouseEvent('mouseout', {bubbles: true, relatedTarget: document.body})); | ||
| } | ||
|
|
||
| /** Check if cursor is over the element (web only). */ | ||
| function isElementHovered(ref: RefObject<View | null>): boolean { | ||
| return !!(ref.current as unknown as HTMLElement)?.matches?.(':hover'); | ||
| } | ||
|
|
||
| export {resetButtonHoverState, isElementHovered}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.