fix: resolve deploy blockers and add hover/tooltip to receipt action buttons by TaduJR · Pull Request #84497 · Expensify/App

TaduJR · 2026-03-07T13:04:17Z

Explanation of Change

Fixes 5 deploy blockers and 1 additional deploy blocker found during QA of the receipt action buttons (Add Receipt + Enlarge) introduced in the original PR #83994:

Buttons don't appear after hovering during image load ([Due for payment 2026-03-30] Web - Expense - Buttons do not appear when hovering over receipt while it is loading #84354) — Added isMouseInsideRef to track mouse position independently of hover state. When isLoading transitions to false, a useEffect re-triggers
onMouseEnter if the mouse is still inside the receipt area, so buttons appear without requiring the user to move the mouse out and back in.
Blue focus ring on enlarge button after pressing ESC ([Due for payment 2026-03-30] Web - Expense - Full screen button has blue border after closing receipt view with ESC key #84355) — Replaced PressableWithoutFeedback with PressableWithoutFocus on the enlarge button and added styles.noOutline. PressableWithoutFocus calls
blur() on press, preventing the browser's default focus ring from persisting after the receipt modal is closed with ESC.
No error modal for oversized/invalid attachments ([Due for payment 2026-03-30] Expense - No error modal when sending large attachment from receipt button #84356) — Integrated useFilesValidation hook (same pattern used by ReportActionCompose) to validate file size, type, and PDF password protection before
uploading. Added acceptedFileTypes restriction to AttachmentPicker so the OS file dialog pre-filters to valid receipt extensions. Renders AttachmentErrorModal and PDFValidationComponent for user feedback.
Report doesn't scroll down after adding attachment ([Due for payment 2026-03-30] Expense - Report does not scroll down after sending attachment #84359) — Changed notifyReportID from moneyRequestReport?.reportID ?? report.reportID to report.reportID. The attachment is posted to the transaction thread
(report), so that's the report that needs the scroll-to-bottom notification — not the parent IOU report.
Buttons persist without hover on touchscreen laptops ([Due for payment 2026-03-30] Chat Report View - Enlarge and plus buttons on receipt image persist without hover #84388) — Replaced canUseTouchScreen() with hasHoverSupport() in both useHover.ts and MoneyRequestReceiptView.tsx. canUseTouchScreen() checks
navigator.maxTouchPoints > 0 which returns true on touchscreen laptops (e.g., Lenovo Flex 5i) even though they have a mouse — blocking hover state updates entirely. hasHoverSupport() uses CSS media query (hover: hover) and (pointer: fine) which correctly identifies hover capability regardless of touch presence.
Button icons hard to see when PDF receipt added offline ([Due for payment 2026-03-30] Android - Expense - Button icons are hard to see when PDF receipt is added offline #84367) — Used shouldDisableOpacity on OfflineWithFeedback to prevent blanket opacity: 0.5 from fading the action buttons when offline. Applied offlineFeedbackPending style manually to just the receipt image wrapper, so the image correctly fades while buttons remain at full opacity and usable.

Fixed Issues

$ #84354
$ #84355
$ #84356
$ #84359
$ #84388
$ #84367
PROPOSAL:

Tests

Prerequisite: Create an expense with a receipt in a workspace chat and open the expense.

#84354 — Buttons appear after hovering during image load:

Open the expense
Quickly hover over the receipt while it is still loading
Keep the mouse over the receipt until loading completes
Verify the enlarge and add buttons appear on the receipt without needing to move the mouse away and back

#84355 — No blue focus ring on enlarge button after ESC:

Hover over the receipt
Click the full screen (enlarge) button
Close the receipt view with the ESC key
Hover over the receipt again
Verify the enlarge button does not have a blue focus border

#84356 — Error modal for oversized/invalid attachments:

Hover over the receipt
Click the Add (+) button
Select an attachment larger than 25 MB
Verify an error modal appears stating the file is too large
Repeat with an invalid file type and verify the file picker filters it out

#84359 — Report scrolls down after adding attachment:

Create two expenses (one must have a receipt) so the report uses the table view
Open the expense with receipt
Send enough messages so the report is scrollable
Scroll to the top
Hover over the receipt and click the Add (+) button
Add a valid attachment
Verify the report scrolls down to show the newly sent attachment

#84388 — Buttons show/hide on hover (touchscreen laptop):

On a device with both touchscreen and mouse (e.g., Lenovo Flex 5i)
Open an expense with a receipt
Verify the buttons are hidden by default
Hover over the receipt with the mouse
Verify the buttons appear
Move the mouse away from the receipt
Verify the buttons disappear

#84367 — Button icons visible when PDF receipt added offline:

Enable dark mode
Go to workspace chat
Create an expense without a receipt
Open the expense
Go offline
Tap the receipt area and add a PDF receipt
Verify the add and enlarge button icons on the receipt are clearly visible and not faded out
Go back online
Verify the buttons remain clearly visible

Tooltip and hover on receipt action buttons:
1. Open an expense with a receipt
2. Hover over the receipt image
3. Verify the add and enlarge buttons appear
4. Hover over the add (+) button
5. Verify a tooltip "Add additional receipt" appears and the button has a hover background
6. Hover over the enlarge button
7. Verify a tooltip "Expand" appears and the button has a hover background
8. Move the mouse away from the receipt
9. Verify the tooltips disappear and buttons hide

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-Safari.mp4

MacOS: Chrome / Safari

Mac-Chrome.mp4

…s ring after ESC

… button

…ng attachment

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

…ion buttons

melvin-bot · 2026-03-07T13:04:24Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-07T13:10:20Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/Report/index.ts	`67.40% <100.00%> (+0.29%)`	⬆️
src/styles/index.ts	`47.42% <ø> (ø)`
...ReportActionItem/receiptHoverUtils/index.native.ts	`66.66% <66.66%> (ø)`
src/hooks/useHover.ts	`66.66% <33.33%> (ø)`
...nents/ReportActionItem/MoneyRequestReceiptView.tsx	`68.21% <68.42%> (+1.27%)`	⬆️
...onents/ReportActionItem/receiptHoverUtils/index.ts	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

joekaufmanexpensify

Fixing DBs

ahmedGaber93 · 2026-03-09T19:41:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

20260316214029107.mp4

20260316213920573.mp4

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

20260316203940082.mp4

20260316204408887.mp4

20260316204449780.mp4

ahmedGaber93 · 2026-03-10T22:35:18Z

Issue: Buttons don't appear after hovering during image load

Review - Edge case: when uploading the receipt for the first time, the button still disappears.

20260310222420835.mp4

Issue: Blue focus ring on enlarge button after pressing ESC

Review - Regression: enlarge button doesn't have border style when using tab to focus it

It would be good to make the border style clearer for both buttons. Maybe we could use a square border.

Issue: Report doesn't scroll down after adding attachment

Review - Not fixed with me.

20260311001943288.mp4

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

…rst-upload hover detection

melvin-bot · 2026-03-16T05:28:30Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

src/libs/actions/Report/index.ts

src/components/ReportActionItem/MoneyRequestReceiptView.tsx

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

OSBotify · 2026-03-18T16:31:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-18T16:34:15Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-18T16:40:37Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84497.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-215b2f5-e8d9bf4-2cba843e1fd9483edd0b6f4395a63097e86ec863/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-215b2f5-e8d9bf4-09d1a8f36c1e339a044c667b758c807763b1b261/index.html

Web 🕸️
https://84497.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T20:24:18Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

IuliiaHerets · 2026-03-20T11:02:43Z

Hi @TaduJR. QA team failed this PR with this original issue

1773956892982.Recording__1872.mp4

TaduJR · 2026-03-20T11:09:54Z

Hi @TaduJR. QA team failed this PR with this #84356

Hi @IuliiaHerets

Hmm not able to repo on my side. Could you please create an issue for it with the attachment you used to repo if possible?

Thanks!

TaduJR · 2026-03-20T13:31:55Z

@IuliiaHerets

Don't forget to tag me there.

nlemma · 2026-03-20T14:21:24Z

Deploy Blocker #85953 was identified to be related to this PR.

IuliiaHerets · 2026-03-20T15:04:53Z

@TaduJR, issue was logged here

OSBotify · 2026-03-23T09:26:18Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

TaduJR added 6 commits March 6, 2026 07:50

fix: use PressableWithoutFocus on enlarge button to prevent blue focu…

28e2210

…s ring after ESC

fix: validate attachment files and restrict file types on receipt add…

48438e9

… button

fix: notify transaction thread report for scroll-to-bottom after addi…

54d5e43

…ng attachment

fix: show receipt action buttons when hovering during image load

98e7b98

Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…

0696ce7

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

fix: use hasHoverSupport instead of canUseTouchScreen for receipt act…

9f016dd

…ion buttons

TaduJR requested review from a team as code owners March 7, 2026 13:04

melvin-bot bot assigned TaduJR Mar 7, 2026

melvin-bot bot requested review from ahmedGaber93 and joekaufmanexpensify and removed request for a team March 7, 2026 13:04

Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…

1125ca7

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

joekaufmanexpensify previously approved these changes Mar 9, 2026

View reviewed changes

feat: add hover states to receipt action buttons

465391b

TaduJR dismissed joekaufmanexpensify’s stale review via 465391b March 9, 2026 18:54

TaduJR requested a review from a team as a code owner March 9, 2026 18:54

TaduJR added 2 commits March 13, 2026 02:24

Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…

1ee46b4

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

feat: add tooltips to receipt action buttons

7463094

TaduJR mentioned this pull request Mar 13, 2026

feat: allow multiple receipts to be attached to a single expense #83994

Merged

54 tasks

TaduJR added 3 commits March 15, 2026 12:14

Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…

a928724

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…

56c8916

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

fix: reset stale hover states after file picker cancel and improve fi…

8a81fca

…rst-upload hover detection

ahmedGaber93 reviewed Mar 16, 2026

View reviewed changes

src/libs/actions/Report/index.ts Show resolved Hide resolved

ahmedGaber93 reviewed Mar 16, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestReceiptView.tsx Outdated Show resolved Hide resolved

ahmedGaber93 reviewed Mar 16, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestReceiptView.tsx Show resolved Hide resolved

TaduJR added 4 commits March 17, 2026 09:29

Merge branch 'main' of https://github.com/TaduJR/App into feat-Allow-…

663da44

…Multiple-Receipts-to-Be-Attached-to-a-Single-Expense

fix: add early return for undefined reportID in notifyNewAction

870f9e1

refactor: extract receipt hover utilities into platform-specific files

c20fc25

fix: center loading indicator in receipt image container

03f0241

ahmedGaber93 approved these changes Mar 17, 2026

View reviewed changes

melvin-bot bot requested a review from puneetlath March 17, 2026 23:53

puneetlath approved these changes Mar 18, 2026

View reviewed changes

puneetlath merged commit 215b2f5 into Expensify:main Mar 18, 2026
35 checks passed

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

This was referenced Mar 20, 2026

[$250] Expense -No error modal when sending a specific attachment via the receipt button #85951

Open

Expense - Wrong attachment size limit is shown when uploading from add receipt button #85953

Closed

Conversation

TaduJR commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 7, 2026

Uh oh!

codecov bot commented Mar 7, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Mar 10, 2026

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

IuliiaHerets commented Mar 20, 2026

Uh oh!

TaduJR commented Mar 20, 2026

Uh oh!

TaduJR commented Mar 20, 2026

Uh oh!

nlemma commented Mar 20, 2026

Uh oh!

IuliiaHerets commented Mar 20, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

TaduJR commented Mar 7, 2026 •

edited

Loading

codecov bot commented Mar 7, 2026 •

edited by github-actions bot

Loading

ahmedGaber93 commented Mar 9, 2026 •

edited

Loading