feat: allow multiple receipts to be attached to a single expense by TaduJR · Pull Request #83994 · Expensify/App

TaduJR · 2026-03-03T07:18:45Z

Explanation of Change

This PR adds two icon buttons overlaid at the top-right of receipt images in MoneyRequestReceiptView: an enlarge button (opens the receipt modal) and an add receipt button (opens the attachment picker and posts the file to the expense thread via addAttachmentWithComment).

Buttons appear on hover (web) and are always visible on touch/mobile
Styled consistently with the flash button on the camera viewfinder (primaryMediumIcon, 16×16 icons, no gradient/scrim) per design team consensus
Buttons are gated behind canShowReceiptActions — only shown when the receipt exists, is editable, not scanning, not a map distance request, and not in merge flow

Fixed Issues

$ #81435
PROPOSAL: #81435 (comment)

Tests

Web (Chrome/Safari) — Hover behavior

Navigate to an expense with an attached receipt image
Hover over the receipt image
Verify two circular icon buttons (enlarge and plus) appear at the top-right corner of the receipt
Move the mouse away from the receipt image
Verify both buttons disappear
Hover over the receipt again and click the enlarge (fullscreen) button
Verify the full-size receipt modal opens showing the receipt image
Close the modal, hover over the receipt again, and click the plus button
Verify a file picker dialog opens
Select an image file from the file picker
Verify the selected file appears as a new attachment message in the expense thread

Mobile (iOS/Android) — Always-visible behavior

Open the same expense with an attached receipt on a mobile device
Verify the enlarge and plus buttons are immediately visible on the receipt
Tap the enlarge button
Verify the receipt modal opens
Go back, then tap the plus button
Verify the attachment picker opens
Select or capture an image
Verify the attachment appears as a new message in the expense thread

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-Safari.mp4

MacOS: Chrome / Safari

Mac-Chrome.mp4

melvin-bot · 2026-03-03T07:18:52Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e92af7d33a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/ReportActionItem/MoneyRequestReceiptView.tsx

codecov · 2026-03-03T07:35:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.30% <ø> (ø)`
src/styles/index.ts	`47.64% <ø> (+7.85%)`	⬆️
...nents/ReportActionItem/MoneyRequestReceiptView.tsx	`67.21% <50.00%> (+10.07%)`	⬆️
... and 424 files with indirect coverage changes

src/components/ReportActionItem/MoneyRequestReceiptView.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b40ff14b81

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/ReportActionItem/MoneyRequestReceiptView.tsx

ahmedGaber93 · 2026-03-03T17:45:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

a.mp4

Android: mWeb Chrome

aw.mp4

iOS: HybridApp

iOS: mWeb Safari

20260304202114953.mp4

MacOS: Chrome / Safari

20260304200055659.mp4

src/components/ReportActionItem/MoneyRequestReceiptView.tsx

github-actions · 2026-03-04T13:23:30Z

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

JmillsExpensify · 2026-03-04T13:35:43Z

Wow, this looks pretty great. Excited to get this into the product.

JmillsExpensify

Going to go ahead and approve for product.

TaduJR · 2026-03-04T13:47:43Z

Wow, this looks pretty great. Excited to get this into the product.

Thanks @JmillsExpensify

WDYT about the above comment?

dannymcclain · 2026-03-04T15:34:59Z

Seems to be working well for me, but can you update the icons to match the mocks from the design team?

Should be using these two:

Receipt plus: App/assets/images/receipt-plus.svg
https://github.com/Expensify/App/blob/main/assets/images/receipt-plus.svg

Expand: App/assets/images/expand.svg
https://github.com/Expensify/App/blob/main/assets/images/expand.svg

mitarachim · 2026-03-06T04:21:13Z

Deploy Blocker #84354 was identified to be related to this PR.

mitarachim · 2026-03-06T04:30:54Z

Deploy Blocker #84356 was identified to be related to this PR.

jponikarchuk · 2026-03-06T04:33:16Z

Deploy Blocker #84355 was identified to be related to this PR.

mitarachim · 2026-03-06T04:48:13Z

Deploy Blocker #84359 was identified to be related to this PR.

jponikarchuk · 2026-03-06T05:43:49Z

Deploy Blocker #84362 was identified to be related to this PR.

mitarachim · 2026-03-06T06:17:15Z

Deploy Blocker #84367 was identified to be related to this PR.

mitarachim · 2026-03-06T11:03:25Z

@TaduJR This PR is failing because of a regression issue #84388

The issue is reproducible in: Web

The issue can only be reproduced on laptops with touchscreens

Lenovo / Ideapad Flex 5i
Lenovo / Ideapad Flex5

Bug7095356_1772783628779.hoverr.mp4

TaduJR · 2026-03-06T15:39:44Z

The issue can only be reproduced on laptops with touchscreens

Thanks @mitarachim

Will look in to it.

OSBotify · 2026-03-06T22:45:01Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

shawnborton · 2026-03-09T16:35:04Z

Looks like we forgot to add the hover states to the icon buttons. @TaduJR can you make a follow up PR for that?

TaduJR · 2026-03-09T18:25:57Z

Looks like we forgot to add the hover states to the icon buttons. @TaduJR can you make a follow up PR for that?

Sure

TaduJR · 2026-03-09T18:53:19Z

Looks like we forgot to add the hover states to the icon buttons. @TaduJR can you make a follow up PR for that?

Mac-Chrome.mp4

Any feedbacks @shawnborton?

shawnborton · 2026-03-09T19:33:03Z

Looks great, thanks!

puneetlath · 2026-03-10T14:39:54Z

Should there be a tooltip describing what it does on hover?

dannymcclain · 2026-03-10T15:44:05Z

Should there be a tooltip describing what it does on hover?

Ah yes, good shout Puneet, there definitely should be. What labels make the most sense here?

Add receipt / Add additional receipts / Something else?

Expand / Open receipt / View receipt / Something else?

puneetlath · 2026-03-10T19:20:37Z

Add additional receipt and Expand sound good to me.

puneetlath · 2026-03-11T16:45:19Z

@TaduJR will you be implementing that as part of the hover follow-up?

TaduJR · 2026-03-11T20:23:35Z

@TaduJR will you be implementing that as part of the hover follow-up?

Sure, No Problem.

puneetlath · 2026-03-13T15:08:23Z

@TaduJR mind linking the PR?

TaduJR · 2026-03-13T21:44:06Z

@TaduJR mind linking the PR?

@puneetlath

#84497

TaduJR added 2 commits March 3, 2026 09:59

feat: Allow Multiple Receipts to Be Attached to a Single Expense

63e6060

fix: migrate icons to lazy loading

e92af7d

TaduJR requested review from a team as code owners March 3, 2026 07:18

melvin-bot bot assigned TaduJR Mar 3, 2026

melvin-bot bot requested a review from ahmedGaber93 March 3, 2026 07:18

melvin-bot bot requested review from heyjennahay and removed request for a team March 3, 2026 07:18

fix: add sentry labels to receipt action buttons

eaa8219

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestReceiptView.tsx Show resolved Hide resolved

fix: pass user timezone to addAttachmentWithComment

626dd47

TaduJR marked this pull request as draft March 3, 2026 07:47

TaduJR added 2 commits March 3, 2026 11:27

fix: hide receipt action buttons until image is loaded

64b1f16

fix: prevent hover state during receipt image loading

b40ff14

TaduJR marked this pull request as ready for review March 3, 2026 09:45

github-actions bot reviewed Mar 3, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestReceiptView.tsx Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 3, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestReceiptView.tsx Outdated Show resolved Hide resolved

fix: notify parent report when adding attachment from transaction thread

cd990c0

ahmedGaber93 reviewed Mar 3, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

JmillsExpensify previously approved these changes Mar 4, 2026

View reviewed changes

jponikarchuk mentioned this pull request Mar 6, 2026

[Due for payment 2026-03-30] Web - Expense - Full screen button has blue border after closing receipt view with ESC key #84355

Open

7 tasks

mitarachim mentioned this pull request Mar 6, 2026

[Due for payment 2026-03-30] Expense - No error modal when sending large attachment from receipt button #84356

Open

7 tasks

mitarachim mentioned this pull request Mar 6, 2026

[Due for payment 2026-03-30] Expense - Report does not scroll down after sending attachment #84359

Open

7 tasks

jponikarchuk mentioned this pull request Mar 6, 2026

Android - Report - User is auto scrolled up after returning from second added receipt. #84362

Open

7 tasks

mitarachim mentioned this pull request Mar 6, 2026

[Due for payment 2026-03-30] Android - Expense - Button icons are hard to see when PDF receipt is added offline #84367

Open

7 tasks

mitarachim mentioned this pull request Mar 6, 2026

[Due for payment 2026-03-30] Chat Report View - Enlarge and plus buttons on receipt image persist without hover #84388

Open

7 tasks

puneetlath mentioned this pull request Mar 6, 2026

Revert "feat: allow multiple receipts to be attached to a single expense" #84454

Closed

TaduJR mentioned this pull request Mar 7, 2026

fix: resolve deploy blockers and add hover/tooltip to receipt action buttons #84497

Merged

54 tasks

mitarachim mentioned this pull request Mar 9, 2026

Expense - Attachment added from receipt is uploaded in "marked as paid" system message thread #84532

Open

7 tasks

nkdengineer mentioned this pull request Mar 20, 2026

[$250] Expense -No error modal when sending a specific attachment via the receipt button #85951

Open

7 tasks

Conversation

TaduJR commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Web (Chrome/Safari) — Hover behavior

Mobile (iOS/Android) — Always-visible behavior

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Mar 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ahmedGaber93 commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

JmillsExpensify commented Mar 4, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

TaduJR commented Mar 4, 2026

Uh oh!

dannymcclain commented Mar 4, 2026

Uh oh!

mitarachim commented Mar 6, 2026

Uh oh!

mitarachim commented Mar 6, 2026

Uh oh!

jponikarchuk commented Mar 6, 2026

Uh oh!

mitarachim commented Mar 6, 2026

Uh oh!

jponikarchuk commented Mar 6, 2026

Uh oh!

mitarachim commented Mar 6, 2026

Uh oh!

mitarachim commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaduJR commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

shawnborton commented Mar 9, 2026

Uh oh!

TaduJR commented Mar 9, 2026

Uh oh!

TaduJR commented Mar 9, 2026

Uh oh!

shawnborton commented Mar 9, 2026

Uh oh!

puneetlath commented Mar 10, 2026

Uh oh!

TaduJR commented Mar 3, 2026 •

edited

Loading

codecov bot commented Mar 3, 2026 •

edited by github-actions bot

Loading

ahmedGaber93 commented Mar 3, 2026 •

edited

Loading

mitarachim commented Mar 6, 2026 •

edited

Loading