fix: current active menu button not getting announced in settings profile page by Burhan-Rashid · Pull Request #85193 · Expensify/App

Burhan-Rashid · 2026-03-13T06:46:42Z

Explanation of Change

Added accessibility attribute (selected) for menu buttons in settings profile page, so that selected menu buttons are properly announced as selected to the user.

Fixed Issues

$#75556
PROPOSAL:#75556 (comment)

Tests

Prerequisites:

The user is signed in
Enable VoiceOver

Test 1:

Using JAWS + Chrome, open the site https://new.expensify.com/settings/profile
Click a menu button e.g. 'Profile'
Press Tab key to focus the currently selected menu button 'Profile'
verify that the selected menu button (e.g. 'Profile') is announced correctly as 'selected' (Voice over should announce like this 'Profile, selected, tab, group')

Test 2:

Go to reports page.
Click on some menu button e.g 'Expenses'.
Press tab key to focus the currently selected menu button e.g 'Expenses'
Verify that selected menu button (e.g Expenses) is announced correctly as 'selected'.

Test 3:
Precondition: Have some workspace already created.

Go to workspaces page > Click on some workspace.
Click on some menu button e.g. 'Overview'.
Press tab key to focus the currently selected menu button e.g. 'Overview'
Verify that selected menu button (e.g Overview) is announced correctly as 'selected'.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

macos.web.mp4

…file page

melvin-bot · 2026-03-13T12:16:55Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Burhan-Rashid · 2026-03-13T12:21:36Z

I added screenshots of web platform only because for native platforms(narrow layout), we don't show the user the selected menu item and the details page in the same view.
Also we have other pages like workspaces and reports where similar issue is present. Do we need to add these changes for those two as well?
@aimane-chnaif

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1405b9bc1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/components/MenuItem.tsx

Burhan-Rashid · 2026-03-13T15:37:54Z

@codex review

chatgpt-codex-connector · 2026-03-13T15:46:53Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify · 2026-03-13T20:48:06Z

No product review needed

aimane-chnaif · 2026-03-15T10:30:29Z

Also we have other pages like workspaces and reports where similar issue is present. Do we need to add these changes for those two as well? @aimane-chnaif

yes, we should fix other pages too

aimane-chnaif · 2026-03-15T10:44:53Z

src/components/MenuItem.tsx

                                role={interactive ? role : undefined}
                                accessibilityLabel={`${enhancedAccessibilityLabel}${brickRoadIndicator ? `. ${translate('common.yourReviewIsRequired')}` : ''}`}
                                accessible={shouldBeAccessible}
+                                accessibilityState={{selected}}


Introduce new prop like isTab (or you can find better name)

accessibilityState={isTab ? {selected: isFocused} : undefined} role={isTab ? CONST.ROLE.TAB : undefined}

Should we only pass the prop role=CONST.ROLE.TAB to menuitem and do like this

accessibilityState={role === CONST.ROLE.TAB ? {selected: focused} : undefined}

For role prop we already have a condition here:

App/src/components/MenuItem.tsx

Line 797 in 0a415ed

role={interactive ? role : undefined}

so i don't think we should do isTab for this @aimane-chnaif

ok go with that

…tialPage

codecov · 2026-03-16T03:10:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MenuItem.tsx	`87.09% <100.00%> (+1.91%)`	⬆️
src/pages/Search/SavedSearchList.tsx	`0.00% <ø> (ø)`
src/pages/settings/InitialSettingsPage.tsx	`0.00% <ø> (ø)`
src/pages/workspace/WorkspaceInitialPage.tsx	`0.00% <ø> (ø)`
src/pages/Search/SearchTypeMenuItem.tsx	`0.00% <0.00%> (ø)`
... and 340 files with indirect coverage changes

aimane-chnaif · 2026-03-16T08:11:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

aimane-chnaif · 2026-03-16T09:02:29Z

Some behaviors different from production:

Space key doesn't work (works in production). Only Enter key works for selecting tab
After selecting tab with Enter, tab is still active (tab is blurred in production).

web.mov

I am not sure if it's fine. @rushatgabhane can you please confirm?

rushatgabhane · 2026-03-16T14:18:12Z

@MelvinBot why could that be

MelvinBot · 2026-03-16T14:23:37Z

Both issues stem from how react-native-web's PressResponder handles keyboard events differently based on the element's role.

1. Space key doesn't work with `role="tab"`

The isValidKeyPress function in react-native-web's PressResponder (source) only allows Space for role="button" or native <button> elements:

const isValidKeyPress = (event) => {
  const { key, target } = event;
  const isSpacebar = key === ' ' || key === 'Spacebar';
  const isButtonish = getElementType(target) === 'button' || isButtonRole(target);
  return key === 'Enter' || (isSpacebar && isButtonish);
};

isButtonRole checks getElementRole(element) === 'button', so role="tab" fails that check. Enter always works because it's unconditionally accepted.

2. Tab stays focused after Enter

MenuItem's onPressAction at src/components/MenuItem.tsx:709-710 only calls .blur() for click events:

if (event?.type === 'click') {
    (event.currentTarget as HTMLElement).blur();
}

When activated via Enter, PressResponder's keyupHandler calls onPress(event) with a KeyboardEvent (type "keyup"), not a "click". So .blur() is never called.

In production with role="button", this works because browsers natively synthesize a click event when Space is pressed on a button-role element — so the blur path fires via that synthetic click. With role="tab", browsers don't synthesize clicks from keyboard interaction, so neither Space nor Enter triggers the blur path.

Possible fixes

Space key: Override keyboard handling to treat Space as a valid activation key for tab-role pressables (e.g., add an onKeyDown handler that manually triggers onPress for Space when role="tab").
Blur: Extend the blur condition to also handle keyboard events, e.g.: if (event?.type === 'click' || event?.type === 'keyup') { ... }, or unconditionally blur after press.

Per the WAI-ARIA Tabs Pattern, tabs should be activatable by both Space and Enter, so this is worth addressing.

rushatgabhane · 2026-03-17T22:09:12Z

Space key doesn't work with role="tab"

I mean fair enough. If QA wants it to be tab then we can't support space key

Burhan-Rashid · 2026-03-18T00:02:22Z

Some behaviors different from production:

Space key doesn't work (works in production). Only Enter key works for selecting tab

After selecting tab with Enter, tab is still active (tab is blurred in production).

The behaviour became similar to other role='tab' items like these

which also doesn't get selected on space key.
I think if we want to handle the space key selection for tab items, it should be created as a separate issue/PR for all the role='tab' items in the app in my opinion.

aimane-chnaif · 2026-03-18T10:47:53Z

ok, agree not blocker

rushatgabhane · 2026-03-18T15:12:59Z

sounds good! @aimane-chnaif please watch out for deploy blockers and ask them to demote them 😓

github-actions · 2026-03-19T06:58:36Z

🚧 @mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-19T07:03:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85193.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2dfe23b-6d2fe73-68247c3c1afac5f7c5af029f798e46bfe8d34056/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2dfe23b-6d2fe73-990920827ac298a57501cee58281e6f34379b818/index.html

Web 🕸️
https://85193.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-19T07:06:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-19T20:25:10Z

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-23T09:27:39Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: current active menu button not getting announced in settings pro…

f1405b9

…file page

melvin-bot bot assigned Burhan-Rashid Mar 13, 2026

Burhan-Rashid marked this pull request as ready for review March 13, 2026 12:16

Burhan-Rashid requested review from a team as code owners March 13, 2026 12:16

melvin-bot bot requested review from aimane-chnaif and removed request for a team March 13, 2026 12:16

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 13, 2026 12:16

Burhan-Rashid mentioned this pull request Mar 13, 2026

[Due for payment 2026-03-30] [$250] Screen Reader: Settings-Profile: The currently active menu button is not announced as such #75556

Open

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

src/components/MenuItem.tsx Outdated Show resolved Hide resolved

fixed pr comments

a484805

joekaufmanexpensify removed their request for review March 13, 2026 20:48

aimane-chnaif reviewed Mar 15, 2026

View reviewed changes

fixed PR comments and added changes for reports page and workspaceIni…

629c87e

…tialPage

added role prop for saved search menuItems as well

34fb1d2

aimane-chnaif approved these changes Mar 18, 2026

View reviewed changes

melvin-bot bot requested a review from mollfpr March 18, 2026 10:48

mollfpr approved these changes Mar 19, 2026

View reviewed changes

mollfpr merged commit 2dfe23b into Expensify:main Mar 19, 2026
32 checks passed

OSBotify mentioned this pull request Mar 19, 2026

Deploy Checklist: New Expensify 2026-03-19 #85862

Closed

Conversation

Burhan-Rashid commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

Burhan-Rashid commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Burhan-Rashid commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 13, 2026

Uh oh!

joekaufmanexpensify commented Mar 13, 2026

Uh oh!

aimane-chnaif commented Mar 15, 2026

Uh oh!

aimane-chnaif Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Burhan-Rashid Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Burhan-Rashid Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aimane-chnaif commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Mar 16, 2026

Uh oh!

rushatgabhane commented Mar 16, 2026

Uh oh!

MelvinBot commented Mar 16, 2026

1. Space key doesn't work with role="tab"

2. Tab stays focused after Enter

Possible fixes

Uh oh!

rushatgabhane commented Mar 17, 2026

Uh oh!

Burhan-Rashid commented Mar 18, 2026

Uh oh!

aimane-chnaif commented Mar 18, 2026

Uh oh!

rushatgabhane commented Mar 18, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

OSBotify commented Mar 23, 2026

Uh oh!

Burhan-Rashid commented Mar 13, 2026 •

edited

Loading

Burhan-Rashid commented Mar 13, 2026 •

edited

Loading

aimane-chnaif Mar 15, 2026 •

edited

Loading

Burhan-Rashid Mar 16, 2026 •

edited

Loading

codecov bot commented Mar 16, 2026 •

edited by github-actions bot

Loading

aimane-chnaif commented Mar 16, 2026 •

edited

Loading

1. Space key doesn't work with `role="tab"`