Skip to content

fix: current active menu button not getting announced in settings profile page #85193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mollfpr merged 4 commits into from
Mar 19, 2026
Merged

fix: current active menu button not getting announced in settings profile page #85193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1405b9
fix: current active menu button not getting announced in settings pro…
Burhan-Rashid Mar 13, 2026
a484805
fixed pr comments
Burhan-Rashid Mar 13, 2026
629c87e
fixed PR comments and added changes for reports page and workspaceIni…
Burhan-Rashid Mar 16, 2026
34fb1d2
added role prop for saved search menuItems as well
Burhan-Rashid Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/MenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,7 @@ function MenuItem({
role={interactive ? role : undefined}
accessibilityLabel={`${enhancedAccessibilityLabel}${brickRoadIndicator ? `. ${translate('common.yourReviewIsRequired')}` : ''}`}
accessible={shouldBeAccessible}
accessibilityState={role === CONST.ROLE.TAB ? {selected: focused} : undefined}
tabIndex={interactive ? tabIndex : -1}
onFocus={onFocus}
sentryLabel={sentryLabel}
Expand Down
1 change: 1 addition & 0 deletions src/pages/Search/SavedSearchList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ function SavedSearchList({hash}: SavedSearchListProps) {

return {
...baseMenuItem,
role: CONST.ROLE.TAB,
sentryLabel: CONST.SENTRY_LABEL.SEARCH.SAVED_SEARCH_MENU_ITEM,
onPress: () => {
setSearchContext(false);
Expand Down
3 changes: 2 additions & 1 deletion src/pages/Search/SearchTypeMenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ function SearchTypeMenuItem({title, icon, badgeText, focused = false, onPress}:
<PressableWithoutFeedback
onPress={onPress}
accessibilityLabel={title}
role={CONST.ROLE.BUTTON}
accessibilityState={{selected: focused}}
role={CONST.ROLE.TAB}
sentryLabel={CONST.SENTRY_LABEL.SEARCH.TYPE_MENU_ITEM}
style={({hovered, pressed}) => [
styles.flexRow,
Expand Down
1 change: 1 addition & 0 deletions src/pages/settings/InitialSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ function InitialSettingsPage({currentUserPersonalDetails}: InitialSettingsPagePr
shouldBlockSelection={!!item.link}
onSecondaryInteraction={item.link ? (event) => openPopover(item.link, event) : undefined}
focused={isFocused}
role={CONST.ROLE.TAB}
isPaneMenu
sentryLabel={item.sentryLabel}
iconRight={item.iconRight}
Expand Down
1 change: 1 addition & 0 deletions src/pages/workspace/WorkspaceInitialPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,7 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac
wrapperStyle={styles.sectionMenuItem(shouldUseNarrowLayout)}
highlighted={!!item?.highlighted}
focused={!!(item.screenName && activeRoute?.startsWith(item.screenName))}
role={CONST.ROLE.TAB}
badgeText={item.badgeText}
shouldIconUseAutoWidthStyle
sentryLabel={item.sentryLabel}
Expand Down
Loading