Unlock landscape mode by GCyganek · Pull Request #85229 · Expensify/App

GCyganek · 2026-03-13T13:22:18Z

Explanation of Change

Unlocks landscape mode for phones on iOS and Android. Removes portrait-only orientation locks, adds a new useIsInLandscapeMode hook and isInLandscapeMode utility, and applies layout fixes across modals, text inputs, pages, and popover menus. Auto-focus is suppressed in landscape via a Proxy-based ref wrapper, keyboards can be dismissed by tapping headers/safe area insets, and bottom-docked modals are height-constrained and optionally wrapped in ScrollView.

Fixed Issues

$ #77280
PROPOSAL: #77280 (comment)
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13889

Tests

Open the app on an iOS or Android phone (not tablet)
Rotate the device to landscape orientation
Navigate through key screens: chat composer, expense creation (scan, distance map, distance GPS), settings (avatar page, set time page, tag settings), onboarding workspace optional screen, and emoji picker
Verify that all screens render correctly in landscape — content is scrollable, modals are height-constrained and not cut off, text inputs do not auto-focus (keyboard does not appear automatically), and no content is unreachable
Open a bottom-docked modal (e.g. FAB popover, action context menu) in landscape mode and verify it is scrollable and closeable, with a max height of 75% of the window height
Verify that in portrait mode the UI remains unchanged

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-03-13.at.14.03.49.mov

iOS: Native

Screen.Recording.2026-03-13.at.14.00.33.mov

github-actions · 2026-03-13T13:22:27Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

GCyganek · 2026-03-13T13:23:45Z

@mountiny could you ran adhoc here and ask QA to do full regression testing in landscape mode?

github-actions · 2026-03-13T13:33:14Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

truph01 · 2026-03-13T14:30:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

truph01 · 2026-03-14T08:43:56Z

Here are a few issues I noticed during testing:

Bug 1: [Android] Unable to scroll the popover menu

The popover menu cannot be scrolled on Android.

Screen.Recording.2026-03-14.at.15.29.46.mov

Bug 2: [Android] Input field layout issue when focusing

When the input field receives focus and the keyboard opens, the layout looks incorrect.

Screen.Recording.2026-03-14.at.15.34.29.mov

Bug 3: [Android] Digit input partially hidden in landscape mode

The digit input is partially hidden. In landscape mode, it might be better to display it on the left or right side instead of at the bottom.

Screen.Recording.2026-03-14.at.15.37.55.mov

Bug 4: Camera view too narrow in request scan flow

The camera preview in the request scan flow appears too narrow. We may want to adjust the layout for landscape mode to improve the view.

Screen.Recording.2026-03-14.at.15.39.17.mov

Bug 5: [Android] The report action's context menu looks weird

Screen.Recording.2026-03-14.at.15.50.25.mov

truph01 · 2026-03-14T08:47:42Z

@GCyganek Besides the issues above, I noticed that there are quite a few UI problems in landscape mode that still need improvement. However, I’m not sure we should try to address all of them in this PR, since deciding on the appropriate UI changes and implementing them will likely take additional time.

Perhaps we could focus on a few important flows to review, test, and fix in this PR, and leave the remaining issues to be addressed in follow-up PRs.

mountiny · 2026-03-15T22:56:18Z

Yeah I think we should mainly focus on making it work and usable now, anything minor can be handled later

GCyganek · 2026-03-16T10:08:03Z

@truph01 thank you so much for testing and reporting these issues! I'll be working on them today

@mountiny is it ok if I just fix all these issues here and then we can merge and keep on fixing remaining issues that pop up until the end of March?

truph01 · 2026-03-16T10:10:30Z

@mountiny I think most of these issues will require input from the design team as well.

GCyganek · 2026-03-16T10:11:51Z

I noticed that there are quite a few UI problems in landscape mode that still need improvement. However, I’m not sure we should try to address all of them in this PR, since deciding on the appropriate UI changes and implementing them will likely take additional time.

I guess that anything that comes to mind can be reported here/on the issue and then we can decide if we want to have it fixed.

GCyganek · 2026-03-16T10:15:49Z

@mountiny I think most of these issues will require input from the design team as well.

Yeah, @dubielzyk-expensify I see that you're the main designer on this issue, right? Do you have any thoughts on the issues reported above by @truph01? Do you have any requests for the main UI components like the header or bottom menu?

GCyganek · 2026-03-16T12:25:36Z

Bug 1: [Android] Unable to scroll the popover menu

The popover menu cannot be scrolled on Android.

Fixed by making it scrollable and limiting max height to 75% of the screen height in landscape mode so that there is an area that user can tap to close the menu:

Screen.Recording.2026-03-16.at.13.22.51.mov

mountiny · 2026-03-16T12:27:24Z

I think that we:

fix the bugs that make it unusable
leave minor ui issues for later, most users will not use the app in the landscape mode
Can we gate the mode in some way for only selected users? so then only QA could test it in staging?

GCyganek · 2026-03-16T12:41:32Z

3. Can we gate the mode in some way for only selected users? so then only QA could test it in staging?

The landscape mode was not locked in JS, but in the config (Info.plist, .xml, AndroidManifext.xml files), so to enable it only for selected group of users we would probably need:

to setup a beta
lock the landscape mode in JS for users outside of the beta + we would need to add a library that allows us to lock the orientation in JS, for example expo-screen-orientation

That's how I see it

GCyganek · 2026-03-16T12:48:49Z

Bug 2: [Android] Input field layout issue when focusing

When the input field receives focus and the keyboard opens, the layout looks incorrect.

I don't know if we should treat it as a bug, not sure what if there is a better alternative to this. This is a global behaviour in the landscape mode - whenever user taps a text input it shows a fullscreen keyboard:

Screen.Recording.2026-03-16.at.13.46.54.mov

Let's see what @Expensify/design thinks about it

mountiny · 2026-03-16T12:52:39Z

hmm I am not sure if its worth that effort to gate it

shawnborton · 2026-03-16T12:54:13Z

Agree with that too.

GCyganek · 2026-03-16T12:57:09Z

Bug 3: [Android] Digit input partially hidden in landscape mode

The digit input is partially hidden. In landscape mode, it might be better to display it on the left or right side instead of at the bottom.

It's painful, but usable I think:

Screen.Recording.2026-03-16.at.13.51.28.mov

Would wait for @Expensify/design opinion on this. I'm not sure if there is a way to fit the keyboard entirely on the screen with the input field in view. Maybe just making sure that the input field is sticky so that it's always in view would be enough here if we even want to make some improvements here?

shawnborton · 2026-03-16T13:01:07Z

I don't know how much time I would spend optimizing this personally. But one idea we could do would be to have some kind of split layout:

GCyganek · 2026-03-16T13:09:27Z

I don't know how much time I would spend optimizing this personally. But one idea we could do would be to have some kind of split layout:

If we were to split the bugs into groups:

bug that makes something unusable
makes UX painful
UX improvements recommended

I'd say it's in the second group where for example the first bug with FAB popover not being closable and scrollable is in the first group. So let's keep it high on the list and try to fix it before the deadline if we have enough time and not on this PR?

shawnborton · 2026-03-16T13:55:58Z

That makes sense to me, I like breaking it down into those three buckets like that. cc @Expensify/design for viz too

dannymcclain · 2026-03-16T14:04:16Z

Oh yeah I like breaking it down that way too. Makes sense to me 👍

GCyganek · 2026-03-16T14:49:42Z

Bug 4: Camera view too narrow in request scan flow

The camera preview in the request scan flow appears too narrow. We may want to adjust the layout for landscape mode to improve the view.

Any idea @Expensify/design how to handle this? I'd treat it as "makes UX painful" bug.

GCyganek · 2026-03-16T14:50:43Z

Adding this here to make sure it's not forgotten: clicking on scan multiple receipts button opens a modal in broken layout that can't be closed.

Screen.Recording.2026-03-16.at.15.49.47.mov

EDIT: Fixed

shawnborton · 2026-03-16T15:02:52Z

Any idea @Expensify/design how to handle this? I'd treat it as "makes UX painful" bug.

Probably another case where we might want to do a split view?

nlemma · 2026-04-08T11:41:59Z

Deploy Blocker #87364 was identified to be related to this PR.

nlemma · 2026-04-08T11:50:44Z

Deploy Blocker #87366 was identified to be related to this PR.

nlemma · 2026-04-08T12:10:29Z

Deploy Blocker #87369 was identified to be related to this PR.

lanitochka17 · 2026-04-08T12:24:09Z

Deploy Blocker ##87370 was identified to be related to this PR.

jponikarchuk · 2026-04-08T12:32:54Z

Deploy Blocker #87372 was identified to be related to this PR.

nlemma · 2026-04-08T12:41:26Z

Deploy Blocker #87375 was identified to be related to this PR.

lanitochka17 · 2026-04-08T12:50:03Z

Deploy Blocker ##87374 was identified to be related to this PR

lanitochka17 · 2026-04-08T12:51:10Z

Deploy Blocker ##87377 was identified to be related to this PR

nlemma · 2026-04-08T16:09:28Z

Deploy Blocker #87401 was identified to be related to this PR.

nlemma · 2026-04-08T16:37:16Z

Deploy Blocker #87403 was identified to be related to this PR.

lanitochka17 · 2026-04-08T16:54:08Z

Deploy Blocker ##87405 was identified to be related to this PR.

lanitochka17 · 2026-04-08T17:07:32Z

Deploy Blocker ##87406 was identified to be related to this PR.

lanitochka17 · 2026-04-08T18:34:08Z

Deploy Blocker ##87415 was identified to be related to this PR.

lanitochka17 · 2026-04-08T20:49:42Z

Deploy Blocker ##87423 was identified to be related to this PR.

OSBotify · 2026-04-09T00:31:32Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.54-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Unlock landscape mode

8f4229f

melvin-bot bot assigned GCyganek Mar 13, 2026

mountiny requested a review from truph01 March 13, 2026 13:40

This comment has been minimized.

Sign in to view

Make FAB popover closeable and scrollable in landscape mode

2c2b73a

nlemma mentioned this pull request Apr 8, 2026

Android - Expense- Page scrolls to the top after switching to landscape mode & entering number #87364

Open

7 tasks

nlemma mentioned this pull request Apr 8, 2026

Android & iOS - Reports - Empty state has narrow viewport when scrolled down in landscape mode #87366

Open

7 tasks

nlemma mentioned this pull request Apr 8, 2026

Expense-Delete and cancel button partially hidden behind navigation bar in delete modal. #87369

Open

7 tasks

lanitochka17 mentioned this pull request Apr 8, 2026

Profile - Zoom green dot slider is not fully visible and functioning in landscape. #87370

Open

7 tasks

jponikarchuk mentioned this pull request Apr 8, 2026

Android - Text desc successfully authenticated overlaps with the Got it in landscape mode #87372

Open

7 tasks

lanitochka17 mentioned this pull request Apr 8, 2026

Expense - Side arrow to navigate to next month is hidden behind navigation bar. #87374

Open

7 tasks

nlemma mentioned this pull request Apr 8, 2026

Chat-Emoji reaction button is partially hidden in landscape. #87375

Open

7 tasks

lanitochka17 mentioned this pull request Apr 8, 2026

Chat - Compose box is hidden behind keypad in expense thread and concierge #87377

Open

7 tasks

nlemma mentioned this pull request Apr 8, 2026

Expensify Card - Card fraud reported page is not scrollable and blocked in landscape mode #87401

Open

7 tasks

nlemma mentioned this pull request Apr 8, 2026

Android - Expensify Card - Card name cannot be removed in landscape mode #87403

Open

7 tasks

lanitochka17 mentioned this pull request Apr 8, 2026

Workspace - Search bar hidden behind keyboard, Learn more remains in landscape #87405

Open

7 tasks

lanitochka17 mentioned this pull request Apr 8, 2026

Categories - Text in "Import spreadsheet" page is not centered in landscape mode. #87406

Open

7 tasks

This was referenced Apr 8, 2026

Android - QBD - "QuickBooks Desktop setup" page is not scrollable #87409

Open

Status-Message box hidden behind save button, Pronouns search box is partially hidden #87415

Open

lanitochka17 mentioned this pull request Apr 8, 2026

Bank - White page is shown instead plaid in landscape #87423

Open

7 tasks

Conversation

GCyganek commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

GCyganek commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

This comment has been minimized.

truph01 commented Mar 13, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

truph01 commented Mar 14, 2026

Uh oh!

mountiny commented Mar 15, 2026

Uh oh!

GCyganek commented Mar 16, 2026

Uh oh!

truph01 commented Mar 16, 2026

Uh oh!

GCyganek commented Mar 16, 2026

Uh oh!

GCyganek commented Mar 16, 2026

Uh oh!

GCyganek commented Mar 16, 2026

Uh oh!

mountiny commented Mar 16, 2026

Uh oh!

GCyganek commented Mar 16, 2026

Uh oh!

GCyganek commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Mar 16, 2026

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

GCyganek commented Mar 16, 2026

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

GCyganek commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

dannymcclain commented Mar 16, 2026

Uh oh!

GCyganek commented Mar 16, 2026

Uh oh!

GCyganek commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Mar 16, 2026

Uh oh!

nlemma commented Apr 8, 2026

Uh oh!

nlemma commented Apr 8, 2026

Uh oh!

nlemma commented Apr 8, 2026

Uh oh!

lanitochka17 commented Apr 8, 2026

Uh oh!

jponikarchuk commented Apr 8, 2026

Uh oh!

nlemma commented Apr 8, 2026

Uh oh!

GCyganek commented Mar 13, 2026 •

edited

Loading

truph01 commented Mar 14, 2026 •

edited

Loading

GCyganek commented Mar 16, 2026 •

edited

Loading

GCyganek commented Mar 16, 2026 •

edited

Loading

GCyganek commented Mar 16, 2026 •

edited

Loading