Conversation
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid.movAndroid: mWeb Chromemweb-chrome.moviOS: HybridAppios.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.mov |
|
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @jayeshmangwani, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #85328. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Product review not required on this one.
|
🚧 @Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.40-0 🚀
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.40-0 🚀
|
|
Hi @NikkiWines, QA team doesn't see step 3 on our side "In the Signer Info step, enter a job title (e.g., 'Director') and complete all other required fields." cc @Gonals Recording.149.mp4 |
@IuliiaHerets from the video it looks like this is set to I will try to test on staging now though |
|
Works for me on staging :) Screen.Recording.2026-03-19.at.18.05.46.mov |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.41-4 🚀
|
Small regression from #81602
Explanation of Change
Job title is being unnecessarily overwritten. When the signer is also a beneficial owner,
signerJobTitleis reset to''to so it can be repopulated from beneficial owner data. But, unlike name, DOB, and address, job title has no beneficial owner equivalent, so it stays empty, and the API rejects the request with "Invalid field in inputs".Fixed Issues
$ https://github.com/Expensify/Expensify/issues/610314
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari