Bump onyx to 3.0.46 by VickyStash · Pull Request #85248 · Expensify/App

VickyStash · 2026-03-13T16:39:46Z

Explanation of Change

Bumps react-native-onyx from 3.0.45 to 3.0.46 (Expensify/react-native-onyx#724 - Remove macro/micro
tasks during subscriber update).

This Onyx update changes subscriber notifications to be more synchronous, which exposed two issues in the App:

Side effect in render body — updateLastAccessedWorkspace() was called directly during render in the withPolicy HOC, causing "Cannot update a component while rendering a different component" errors. Wrapped in useEffect. (context)
New expense scroll/highlight race condition — Faster Onyx updates caused useNewTransactions to fire before navigation completed, so isFocused was still false and new transactions were missed. Moved the focus check into the scroll setTimeout callback via a ref, so it evaluates at scroll time rather than render time. (context)

Fixed Issues

$ #82871
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

The E/App should work the same way as before. Let's verify basic test steps:

Login with a account.
Navigate to a chat, send a message. React to that message.
Reply to that message in a new thread.
Create a new task, navigate to its details and mark it as completed.
Create a couple of new expenses for someone else, and make sure they are correctly highlighted. Navigate to its details.
Go to Reports tab, Expenses, make sure you can find your expenses and see its details.
Create a new workspace, make sure the rooms were created, and no new warnings appear in the console.
Add a member to the workspace. See it works the same way as before.

Offline tests

Same, as in the Tests section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

ios_web.mov

MacOS: Chrome / Safari

web.mp4

github-actions · 2026-03-13T16:39:55Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-03-13T17:08:56Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...portActionItem/MoneyRequestReportPreview/index.tsx	`90.32% <100.00%> (ø)`
src/pages/workspace/withPolicy.tsx	`100.00% <100.00%> (ø)`
...ReportPreview/MoneyRequestReportPreviewContent.tsx	`61.49% <57.14%> (-0.03%)`	⬇️
... and 93 files with indirect coverage changes

VickyStash · 2026-03-16T08:44:03Z

@codex review

chatgpt-codex-connector · 2026-03-16T08:59:27Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-03-16T09:52:08Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

This reverts commit 834a218.

joekaufmanexpensify · 2026-03-16T19:52:13Z

No product review needed

Krishna2323 · 2026-03-17T08:16:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: HybridApp

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Krishna2323

LGTM and works well!

mountiny

Thank you

OSBotify · 2026-03-17T22:10:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-17T22:12:57Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-17T22:18:01Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85248.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-572af3b-84e475f-77d09b73609720c3600ee9a5e3eae06352e51080/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-572af3b-84e475f-504ddab03ed9b6fbb0e6cb65555a77d56cfbdb77/index.html

Web 🕸️
https://85248.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-18T13:30:18Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T14:06:19Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…ckyStash/refactor/bump-onyx-3.0.46" This reverts commit 572af3b, reversing changes made to b12722f.

OSBotify · 2026-03-19T20:25:19Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.41-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

VickyStash added 3 commits March 13, 2026 17:36

Bump onyx to 3.0.46

609bfcc

Update tests

32dbd5e

Fix scrolling/highlighting of the new expense

b3ee3f9

melvin-bot bot assigned VickyStash Mar 13, 2026

VickyStash added 2 commits March 13, 2026 17:43

Fix prettier

cbe0947

Fix SessionTest.ts

3527401

VickyStash mentioned this pull request Mar 13, 2026

[Due for payment 2026-03-30] Remove asynchronous scheduling from Onyx subscriber notifications #82871

Open

VickyStash added 2 commits March 16, 2026 09:07

Merge branch 'main' into VickyStash/refactor/bump-onyx-3.0.46

aacac75

Fix side effect in withPolicy HOC

c3647c8

VickyStash marked this pull request as ready for review March 16, 2026 09:52

VickyStash requested review from a team as code owners March 16, 2026 09:52

melvin-bot bot requested review from Krishna2323 and removed request for a team March 16, 2026 09:52

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 16, 2026 09:52

github-actions bot reviewed Mar 16, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx Show resolved Hide resolved

github-actions bot reviewed Mar 16, 2026

View reviewed changes

src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx Show resolved Hide resolved

VickyStash added 3 commits March 16, 2026 18:23

Add a comment

d619a85

Add clearTimeout

834a218

Revert "Add clearTimeout"

75145a7

This reverts commit 834a218.

joekaufmanexpensify removed their request for review March 16, 2026 19:52

Krishna2323 approved these changes Mar 17, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny March 17, 2026 08:30

JKobrynski mentioned this pull request Mar 17, 2026

[Due for payment 2026-03-30] [Onyx Audit] Remove allowDynamicKey from useOnyx #80096

Open

mountiny approved these changes Mar 17, 2026

View reviewed changes

mountiny merged commit 572af3b into Expensify:main Mar 17, 2026
40 of 41 checks passed

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Closed

100 tasks

OSBotify mentioned this pull request Mar 18, 2026

[Due for payment 2026-03-30] Workspace settings - Photo is not updated on WS #85673

Closed

7 tasks

MelvinBot mentioned this pull request Mar 18, 2026

[Due for payment 2026-03-30] Tags - Unable to import multi-level tags #85708

Closed

7 tasks

chrispader added a commit to margelo/Expensify that referenced this pull request Mar 19, 2026

Revert "Merge pull request Expensify#85248 from callstack-internal/Vi…

872a52a

…ckyStash/refactor/bump-onyx-3.0.46" This reverts commit 572af3b, reversing changes made to b12722f.

This was referenced Mar 19, 2026

[Due for payment 2026-03-30] Web - User receives an error message while scanning a receipt. The expense is not created. #85755

Closed

[Due for payment 2026-03-30] [$250] Expenses - Uploaded receipt is not displayed when create manual expense #85669

Open

mountiny mentioned this pull request Mar 19, 2026

[CP Staging] fix: Downgrade Onyx to v3.0.45 #85767

Merged

52 tasks

jponikarchuk mentioned this pull request Mar 19, 2026

[$250] Expense - Second created in Reports expense is not highlighted #85805

Open

7 tasks

VickyStash mentioned this pull request Mar 20, 2026

[HOLD] Reapply Onyx bump to v3.0.x #85919

Draft

52 tasks

Conversation

VickyStash commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

codecov bot commented Mar 13, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

VickyStash commented Mar 16, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 16, 2026

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

Uh oh!

Uh oh!

joekaufmanexpensify commented Mar 16, 2026

Uh oh!

Krishna2323 commented Mar 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VickyStash commented Mar 13, 2026 •

edited

Loading

codecov bot commented Mar 13, 2026 •

edited by github-actions bot

Loading