[CP Staging] fix: add exactlyMatch to workspace description mention context by MelvinBot · Pull Request #85369 · Expensify/App

MelvinBot · 2026-03-16T11:32:12Z

Explanation of Change

PR #55846 added room mention highlighting to workspace descriptions by wrapping the description in a MentionReportContext.Provider. However, the context value was missing exactlyMatch: true, which caused ALL room mentions to be highlighted — even non-existing rooms like #abc.

Without exactlyMatch, the styling condition in MentionReportRenderer (!exactlyMatch || navigationRoute) short-circuits to true, bypassing the check for whether the room actually exists. Additionally, since both reportID (for a non-existing room) and currentReportID (explicitly set to undefined) are undefined, the comparison undefined === undefined evaluates to true, triggering the green "current room" highlight.

This PR adds exactlyMatch: true to the workspace description's mention context, matching the pattern already used by PureReportActionItem, ReportDetailsPage, and MoneyRequestConfirmationListFooter. With this flag, the styling condition requires a valid navigationRoute (which only exists for rooms that actually exist), preventing non-existing rooms from being highlighted.

Fixed Issues

$ #85363
PROPOSAL: #85363 (comment)

Tests

Go to a workspace settings > Overview
Click Description
Enter a non-existing room mention like #abc
Click Save
Verify that #abc does NOT show a green highlight — it should appear as plain text
Enter an existing room mention (e.g., #admins if one exists in your workspace)
Click Save
Verify that the existing room mention shows a blue highlight and is clickable

Verify that no errors appear in the JS console

Offline tests

N/A — this change affects rendering logic only, not network behavior. Room mentions render the same way offline.

QA Steps

Go to a workspace settings > Overview
Click Description
Enter a non-existing room mention like #abc
Click Save
Verify that #abc does NOT show a green highlight
Enter an existing room mention in the same workspace
Click Save
Verify that the existing room mention shows a blue highlight and is clickable

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Non-existing room mention (#abc) — no green highlight, renders as plain text:

Tested on web: after saving #abc as workspace description, the mention renders as plain text with no highlight (transparent background, standard text color).

Existing room mention (#admins) — blue highlight, clickable:

Tested on web: after saving #admins as workspace description, the mention renders with blue highlight background (rgb(176, 217, 255)) and blue link text (rgb(1, 100, 191)), and is clickable.

Non-existing room mentions in workspace descriptions showed a green highlight because the MentionReportContext was missing exactlyMatch: true, causing all mentions to be highlighted regardless of whether the room exists. This matches the pattern used by PureReportActionItem, ReportDetailsPage, and MoneyRequestConfirmationListFooter. Co-authored-by: truph01 <truph01@users.noreply.github.com>

MelvinBot · 2026-03-16T11:32:32Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixNonExistingRoomMentionGreenHighlight
git checkout -b claude-fixNonExistingRoomMentionGreenHighlight upstream/claude-fixNonExistingRoomMentionGreenHighlight
git push -u origin claude-fixNonExistingRoomMentionGreenHighlight

Then you can close this PR and open a new one from your fork.

truph01 · 2026-03-16T11:41:53Z

@eh2077 Could you take a look into this PR as well?

codecov · 2026-03-16T11:47:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/workspace/WorkspaceOverviewPage.tsx	`0.00% <0.00%> (ø)`
... and 15 files with indirect coverage changes

eh2077 · 2026-03-16T12:23:32Z

yes, it makes sense. @MelvinBot mark it ready for review

melvin-bot · 2026-03-16T12:25:39Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-03-16T12:25:43Z

Done! This PR has been marked as ready for review. 🚀

eh2077 · 2026-03-16T12:43:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-16.at.8.47.21.PM.mov

eh2077

confirmed it fixes the issue.

github-actions · 2026-03-16T13:09:47Z

🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-16T13:14:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85369.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3617034-a6a9d5f-67aff241e9e59e4d00ddfc2b8c090bc34471907d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3617034-a6a9d5f-ae8cd9cb4d9c28b1b0240dd3d59fc01738f396e8/index.html

Web 🕸️
https://85369.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T13:20:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

cristipaval · 2026-03-17T08:07:51Z

I'll request a CP for you, @madmax330, don't forget next time 😆

…tionGreenHighlight fix: add exactlyMatch to workspace description mention context (cherry picked from commit 3617034) (cherry-picked to staging by cristipaval)

OSBotify · 2026-03-17T09:00:44Z

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.3.38-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-17T11:29:58Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-17T11:57:20Z

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.3.39-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:04:26Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

MelvinBot assigned truph01 Mar 16, 2026

MelvinBot requested a review from a team March 16, 2026 11:32

MelvinBot mentioned this pull request Mar 16, 2026

[Due for payment 2026-03-25] Workspace - Non-existing room mention shows green highlight after saving description #85363

Closed

7 tasks

MelvinBot marked this pull request as ready for review March 16, 2026 12:25

MelvinBot requested a review from a team as a code owner March 16, 2026 12:25

melvin-bot bot requested review from brunovjk and removed request for a team March 16, 2026 12:25

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 16, 2026 12:25

eh2077 approved these changes Mar 16, 2026

View reviewed changes

melvin-bot bot requested a review from madmax330 March 16, 2026 12:49

eh2077 mentioned this pull request Mar 16, 2026

[Due for payment 2026-03-24] [$250] Workspace - Mentions are not highlighted in workspace description #54941

Open

8 tasks

madmax330 approved these changes Mar 16, 2026

View reviewed changes

madmax330 merged commit 3617034 into main Mar 16, 2026
44 checks passed

madmax330 deleted the claude-fixNonExistingRoomMentionGreenHighlight branch March 16, 2026 13:09

cristipaval changed the title ~~fix: add exactlyMatch to workspace description mention context~~ [CP Staging] fix: add exactlyMatch to workspace description mention context Mar 17, 2026

cristipaval added the CP Staging marks PRs that have been CP'd to staging label Mar 17, 2026

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-16 #85347

Closed

74 tasks

Conversation

MelvinBot commented Mar 16, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 16, 2026

Uh oh!

truph01 commented Mar 16, 2026

Uh oh!

codecov bot commented Mar 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eh2077 commented Mar 16, 2026

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

MelvinBot commented Mar 16, 2026

Uh oh!

eh2077 commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

cristipaval commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Mar 16, 2026 •

edited by github-actions bot

Loading

eh2077 commented Mar 16, 2026 •

edited

Loading