Skip to content

fix: the mentioned room is not highlighted in policy profile page#55846

Merged
madmax330 merged 21 commits intoExpensify:mainfrom
truph01:fix/54941
Mar 13, 2026
Merged

fix: the mentioned room is not highlighted in policy profile page#55846
madmax330 merged 21 commits intoExpensify:mainfrom
truph01:fix/54941

Conversation

@truph01
Copy link
Contributor

@truph01 truph01 commented Jan 28, 2025

Explanation of Change

Fixed Issues

$ #54941
PROPOSAL: #54941 (comment)

Tests

Test 1:

  1. Go to ND.
  2. Tap settings -- workspace settings.
  3. Tap workspace profile - description.
  4. Clear the description and enter #test-new-room.
  5. Save the description.
  6. Verify the #test-new-room is highlighted in workspace description.

Test 2:

  1. WS A has a room, #room-ws-a
  2. Add #room-ws-a to the description of WS A
  3. The room mention is highlighted and clickable
  4. Add #room-ws-a to the description of WS B
  5. Verify: The room mention is neither highlighted nor clickable.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Go to ND.
  2. Tap settings -- workspace settings.
  3. Tap workspace profile - description.
  4. Clear the description and enter #test-new-room.
  5. Save the description.
  6. Verify the #test-new-room is highlighted in workspace description.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-01-28.at.16.45.57.mov
Android: mWeb Chrome
Screen.Recording.2025-01-28.at.16.44.51.mov
iOS: Native
Screen.Recording.2025-01-28.at.16.43.15.mov
iOS: mWeb Safari
Screen.Recording.2025-01-28.at.16.44.06.mov
MacOS: Chrome / Safari
Screen.Recording.2025-01-28.at.16.41.38.mov
MacOS: Desktop
Screen.Recording.2025-01-28.at.16.46.46.mov

@truph01 truph01 requested a review from a team as a code owner January 28, 2025 09:50
@melvin-bot melvin-bot bot requested review from eh2077 and removed request for a team January 28, 2025 09:50
@melvin-bot
Copy link

melvin-bot bot commented Jan 28, 2025

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@eh2077
Copy link
Contributor

eh2077 commented Jan 30, 2025

We're waiting for the BE change to fully test the PR. cc @madmax330

@eh2077
Copy link
Contributor

eh2077 commented Feb 6, 2025

Waiting for BE update #54941 (comment)

@eh2077
Copy link
Contributor

eh2077 commented Feb 14, 2025

still waiting for BE fix

@eh2077
Copy link
Contributor

eh2077 commented Feb 25, 2025

Still waiting for BE fix #54941 (comment)

@eh2077
Copy link
Contributor

eh2077 commented Jun 4, 2025

still waiting for BE

@eh2077
Copy link
Contributor

eh2077 commented Dec 1, 2025

@truph01 Let's continue with this PR as BE is ready, see #54941 (comment), thank you!

@truph01
Copy link
Contributor Author

truph01 commented Dec 2, 2025

Working on it

@truph01 truph01 requested a review from a team as a code owner December 2, 2025 17:45
@melvin-bot melvin-bot bot requested review from JmillsExpensify and removed request for a team December 2, 2025 17:46
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ers/MentionReportRenderer/MentionReportContext.tsx 100.00% <ø> (ø)
src/libs/MentionUtils.ts 66.66% <100.00%> (ø)
src/libs/actions/Policy/Policy.ts 45.29% <100.00%> (+0.94%) ⬆️
...ider/HTMLRenderers/MentionReportRenderer/index.tsx 0.00% <0.00%> (ø)
src/pages/workspace/WorkspaceOverviewPage.tsx 0.00% <0.00%> (ø)
... and 114 files with indirect coverage changes

@eh2077
Copy link
Contributor

eh2077 commented Dec 3, 2025

Bug: existing room mention is only highlighted and clickable in the WS it belongs to

  1. WS A has a room, #room-ws-a
  2. Add #room-ws-a to the description of WS A
  3. The room mention is highlighted and clickable
  4. Add #room-ws-a to another WS B
  5. The room mention is neither highlighted nor clickable.
Screen.Recording.2025-12-03.at.9.11.00.AM.mov

Copy link
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good from a product perspective.

@eh2077
Copy link
Contributor

eh2077 commented Dec 4, 2025

@truph01 Bump on review comments, thanks!

@truph01
Copy link
Contributor Author

truph01 commented Dec 9, 2025

Working on it

@getusha
Copy link
Contributor

getusha commented Jan 20, 2026

This way, if report_8667216463890409 is missing from Onyx (or hasn’t been fetched yet), we can fall back to displaying the reportName instead of just showing the raw report ID.

Hmm. shouldn't we be loading the room with OpenApp?

@truph01
Copy link
Contributor Author

truph01 commented Jan 20, 2026

@getusha

Hmm. shouldn't we be loading the room with OpenApp?

I don't think so because we are unable to load all reports at once in OpenApp. For example, in focus mode.

@eh2077
Copy link
Contributor

eh2077 commented Feb 25, 2026

@truph01 Let's continue on this as the BE is ready.

@eh2077
Copy link
Contributor

eh2077 commented Mar 2, 2026

@truph01 Friendly bump 🙇

@truph01
Copy link
Contributor Author

truph01 commented Mar 2, 2026

@eh2077 I just merged main, and everything appears to be working correctly after the recent BE changes.

Screen.Recording.2026-03-02.at.18.17.34.mov

However, before the data is received, the room name is displayed as "Hidden". This behavior seems to have been introduced in PR #76204. I’m not sure whether this is expected behavior or a regression.

Previously, the UI displayed the room ID instead (see the discussion here: #55846 (comment)).

@eh2077
Copy link
Contributor

eh2077 commented Mar 2, 2026

@truph01 Does it work correctly if revert that PR? If yes, it seems like a regression. I think we should investigate a bit why it doesn't work given #55846 (comment), we have both report id and report name.

@truph01
Copy link
Contributor Author

truph01 commented Mar 5, 2026

Does it work correctly if revert that PR?

Yes, it does. However, I think displaying "Hidden" is more meaningful than showing a string ID, so I’m not sure that PR should be considered a regression.


I think we should investigate a bit why it doesn't work given #55846 (comment), we have both report id and report name.

@eh2077 Please refer to this comment. With the recent backend change:

we can include the data in OpenPolicyProfilePage

When the policy profile page is opened, the OpenPolicyProfilePage action may still be processing, which means the report name has not been populated yet. As a result, the report name can be temporarily missing at that moment.

@eh2077
Copy link
Contributor

eh2077 commented Mar 9, 2026

@truph01 Thanks for the explanation! That makes sense to me. Can you help resolve conflicts?

@eh2077
Copy link
Contributor

eh2077 commented Mar 11, 2026

@truph01 friendly bump

@eh2077
Copy link
Contributor

eh2077 commented Mar 13, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-03-13.at.9.09.22.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-03-13.at.9.09.51.PM.mov
iOS: HybridApp
Screen.Recording.2026-03-13.at.9.08.49.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-03-13.at.9.09.09.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-13.at.9.06.49.PM.mov

Copy link
Contributor

@eh2077 eh2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well!

@melvin-bot melvin-bot bot requested a review from madmax330 March 13, 2026 13:12
@madmax330 madmax330 merged commit a19cdc7 into Expensify:main Mar 13, 2026
32 checks passed
@github-actions
Copy link
Contributor

🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.38-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@mitarachim
Copy link

Deploy Blocker #85363 was identified to be related to this PR.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants