fix: the mentioned room is not highlighted in policy profile page#55846
fix: the mentioned room is not highlighted in policy profile page#55846madmax330 merged 21 commits intoExpensify:mainfrom
Conversation
|
We're waiting for the BE change to fully test the PR. cc @madmax330 |
|
Waiting for BE update #54941 (comment) |
|
still waiting for BE fix |
|
Still waiting for BE fix #54941 (comment) |
|
still waiting for BE |
|
@truph01 Let's continue with this PR as BE is ready, see #54941 (comment), thank you! |
|
Working on it |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Bug: existing room mention is only highlighted and clickable in the WS it belongs to
Screen.Recording.2025-12-03.at.9.11.00.AM.mov |
src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx
Outdated
Show resolved
Hide resolved
JmillsExpensify
left a comment
There was a problem hiding this comment.
All looks good from a product perspective.
|
@truph01 Bump on review comments, thanks! |
|
Working on it |
Hmm. shouldn't we be loading the room with OpenApp? |
I don't think so because we are unable to load all reports at once in OpenApp. For example, in focus mode. |
|
@truph01 Let's continue on this as the BE is ready. |
|
@truph01 Friendly bump 🙇 |
|
@eh2077 I just merged Screen.Recording.2026-03-02.at.18.17.34.movHowever, before the data is received, the room name is displayed as "Hidden". This behavior seems to have been introduced in PR #76204. I’m not sure whether this is expected behavior or a regression. Previously, the UI displayed the room ID instead (see the discussion here: #55846 (comment)). |
|
@truph01 Does it work correctly if revert that PR? If yes, it seems like a regression. I think we should investigate a bit why it doesn't work given #55846 (comment), we have both report id and report name. |
Yes, it does. However, I think displaying "Hidden" is more meaningful than showing a string ID, so I’m not sure that PR should be considered a regression.
@eh2077 Please refer to this comment. With the recent backend change:
When the policy profile page is opened, the |
|
@truph01 Thanks for the explanation! That makes sense to me. Can you help resolve conflicts? |
|
@truph01 friendly bump |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-13.at.9.09.22.PM.movAndroid: mWeb ChromeScreen.Recording.2026-03-13.at.9.09.51.PM.moviOS: HybridAppScreen.Recording.2026-03-13.at.9.08.49.PM.moviOS: mWeb SafariScreen.Recording.2026-03-13.at.9.09.09.PM.movMacOS: Chrome / SafariScreen.Recording.2026-03-13.at.9.06.49.PM.mov |
|
🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.38-0 🚀
|
|
Deploy Blocker #85363 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀
|
Explanation of Change
Fixed Issues
$ #54941
PROPOSAL: #54941 (comment)
Tests
Test 1:
#test-new-room.#test-new-roomis highlighted in workspace description.Test 2:
#room-ws-ato the description of WS A#room-ws-ato the description of WS BOffline tests
QA Steps
#test-new-room.#test-new-roomis highlighted in workspace description.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-01-28.at.16.45.57.mov
Android: mWeb Chrome
Screen.Recording.2025-01-28.at.16.44.51.mov
iOS: Native
Screen.Recording.2025-01-28.at.16.43.15.mov
iOS: mWeb Safari
Screen.Recording.2025-01-28.at.16.44.06.mov
MacOS: Chrome / Safari
Screen.Recording.2025-01-28.at.16.41.38.mov
MacOS: Desktop
Screen.Recording.2025-01-28.at.16.46.46.mov