clear reportIDToNameMap every time report collection update by marufsharifi · Pull Request #76204 · Expensify/App

marufsharifi · 2025-11-27T05:33:58Z

Explanation of Change

Fixed Issues

$ #74674
PROPOSAL: #74674 (Comment)

Tests

Invite User B to the workspace as a member.
User A creates a workspace room or sends a message in the workspace chat.
User A mentions the #admins room.
Review User B’s LHN and chat to verify that #admins is displayed as #hidden.
User A promotes User B to admin.
Review User B’s LHN and chat to verify that #admins is displayed as #admins.
User A demotes User B back to member.
Review User B’s LHN and chat to verify that #admins is displayed as #hidden.

Verify that no errors appear in the JS console

Offline tests

No offline Test

QA Steps

Same as Tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.1404-09-06.at.9.45.13.AM.mov

Android: mWeb Chrome

Screen.Recording.1404-09-06.at.9.48.11.AM.mov

iOS: Native

Screen.Recording.1404-09-06.at.9.53.37.AM.mov

iOS: mWeb Safari

Screen.Recording.1404-09-06.at.9.56.15.AM.mov

MacOS: Chrome / Safari

Screen.Recording.1404-09-06.at.9.36.17.AM.mov

melvin-bot · 2025-11-27T05:34:05Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

heyjennahay

No concern with product change

eVoloshchak · 2025-11-30T18:10:06Z

Looking good!

It should change back to #12 role changed back to member

@marufsharifi, there seems to be a typo in test steps

marufsharifi · 2025-12-01T03:50:03Z

@eVoloshchak, thanks for the review, fixed the type.

eVoloshchak · 2025-12-03T18:30:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-22.at.23.23.50.mov

Android: mWeb Chrome

Screen.Recording.2026-02-22.at.23.24.43.mov

iOS: HybridApp

Screen.Recording.2026-02-22.at.19.54.26.mov

iOS: mWeb Safari

Screen.Recording.2026-02-22.at.19.47.38.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-22.at.19.40.20.mov

codecov · 2025-12-04T08:23:51Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Parser.ts	`89.65% <100.00%> (+0.36%)`	⬆️
src/libs/ReportNameUtils.ts	`81.09% <100.00%> (+0.53%)`	⬆️
src/pages/inbox/HeaderView.tsx	`87.16% <100.00%> (+1.35%)`	⬆️
src/libs/MentionUtils.ts	`66.66% <0.00%> (ø)`
... and 20 files with indirect coverage changes

eVoloshchak · 2025-12-04T12:30:35Z

@marufsharifi, it shows hidden in LNH, but admins in chat, I don't think they should be different

Screen.Recording.2025-12-04.at.12.48.27.mov

marufsharifi · 2025-12-07T12:33:33Z

@marufsharifi, it shows hidden in LNH, but admins in chat, I don't think they should be different

Screen.Recording.2025-12-04.at.12.48.27.mov

@eVoloshchak, thanks for the review. Could you clarify the expected behavior here? My understanding is that the original issue only concerned the LHN not updating when a Member’s role changed from Admin to Member.

Displaying #Hidden in the LHN for the member role seems correct to me. What should be shown in the chat view? I don’t think we’ve defined that yet.

marufsharifi · 2025-12-11T05:07:48Z

@eVoloshchak, could you please check this comment when you get a chance? Thanks.

marufsharifi · 2026-01-26T17:50:47Z

Updating her today. thanks.

marufsharifi · 2026-01-27T11:13:33Z

@eVoloshchak, thanks for your patience. Updated the PR to work exactly as expected.

Screen.Recording.1404-11-07.at.3.37.48.PM.mp4

@eVoloshchak, the pr is ready for your review. Please take a look when you get a chance.

marufsharifi · 2026-01-29T03:38:29Z

@eVoloshchak, kindly bump. thanks.

eVoloshchak · 2026-01-29T12:13:07Z

src/libs/MentionUtils.ts

-        mentionDisplayText = removeLeadingLTRAndHash(report?.reportName ?? htmlAttributeReportID);
+        // Match ExpensiMark htmlToText behavior: if we can't resolve a report name, show "Hidden".
+        // This keeps chat mentions consistent with LHN previews.
+        mentionDisplayText = removeLeadingLTRAndHash(report?.reportID && report?.reportName ? report?.reportName : 'Hidden');


Suggested change

mentionDisplayText = removeLeadingLTRAndHash(report?.reportID && report?.reportName ? report?.reportName : 'Hidden');

mentionDisplayText = removeLeadingLTRAndHash(report?.reportID && report?.reportName ? report?.reportName : translate('common.hidden'));

Could you also extend and update the test steps according to the new expected behavoir please?

@eVoloshchak, thanks for the review. For LHN, it is not translated. Do you think we should do it here? it come from expensify-common, and it is not translated.

it come from expensify-common, and it is not translated.

I don't quite understand, could you expand on that please?
Do we have to keep it hardcoded as hidden to work properly?

We use hiddenTranslation here
https://github.com/marufsharifi/App/blob/f9c7167cac5f9de37cd7d66f3c911b16cde66f04/src/libs/ReportUtils.ts#L1223

it come from expensify-common, and it is not translated.

I don't quite understand, could you expand on that please? Do we have to keep it hardcoded as hidden to work properly?

We use hiddenTranslation here https://github.com/marufsharifi/App/blob/f9c7167cac5f9de37cd7d66f3c911b16cde66f04/src/libs/ReportUtils.ts#L1223

@eVoloshchak, thanks for the review. The variable you shared was only used in the condition and never used in ui. Could you please carefully review the code and check where the #Hidden comes in LHN? I don't mind adding translation, but it would make it incompatible with LHN. We should hard-code #Hidden as it is hard-coded in expensify-common.

Screen.Recording.1404-11-16.at.10.38.18.AM.mp4

Is there a way we could keep compatibility with expensify-common while displaying the translated "Hidden" to the user? According to #22659:

Expected Result:
'Hidden' is translated correctly

marufsharifi · 2026-02-02T06:49:59Z

@eVoloshchak, kindly bump. thanks.

marufsharifi · 2026-02-04T05:09:46Z

@eVoloshchak, please take a quick look at this comment when you get a chance. thanks.

marufsharifi · 2026-02-11T06:33:43Z

Bug:

Invite User B to the workspace as a member.

User A creates a workspace room or sends a message in the workspace chat.

User A mentions the #admins room.

Review User B’s LHN and chat to verify that #admins is displayed as #hidden.

Right-click on the message, select "Reply in thread"

Notice the thread title still displays "admins"

Screen.Recording.2026-02-10.at.10.50.36.mov

@eVoloshchak, fixed. thanks.

marufsharifi · 2026-02-11T06:34:33Z

@eVoloshchak, I fixed the latest bug reported. Please take another look when you get a chance. thanks.

marufsharifi · 2026-02-11T07:04:35Z

@eVoloshchak, could you please share your thoughts on the failure unit test?

I think we have 3 options

Change the test
Revert to deprecated getReportName and fix the latest bug in deprecated getReportName
Update the new getReportName to cover the failure unit test.

eVoloshchak · 2026-02-12T20:33:50Z

Update the new getReportName to cover the failure unit test.

This is the right option I think, the failure means the new getReportName doesn't meet the requirements

marufsharifi · 2026-02-16T08:00:56Z

Update the new getReportName to cover the failure unit test.

This is the right option I think, the failure means the new getReportName doesn't meet the requirements

@eVoloshchak, I investigated the failing CI (tests/ui/components/HeaderViewTest.tsx) and found the regressions came from replacing the old ReportUtils.getReportName(...) call in HeaderView.tsx with the new lightweight getReportName(...) from:

App/src/libs/ReportNameUtils.ts

Lines 833 to 842 in 1d699f9

    
           /** 
        
            * Check for existence of report name in derived values first, then fall back to the report object 
        
            * 
        
            * @param report 
        
            * @param reportAttributesDerivedValue 
        
            */ 
        
           function getReportName(report?: Report, reportAttributesDerivedValue?: ReportAttributesDerivedValue['reports']): string { 
        
               if (!report || !report.reportID) { 
        
                   return ''; 
        
               }

The new helper was only returning derived/static names, so it missed two required dynamic title paths:

Invoice room titles must update when receiver's personal details change.
CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS thread titles must be built from the parent action context.

To fix this without reverting to deprecated code, I updated the new getReportName to:

handle invoice room naming via getInvoicesChatName(...) (using current personal details),
handle CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS by resolving the parent action and building the expected message,

marufsharifi · 2026-02-18T16:13:08Z

@eVoloshchak, kindly bump. thanks.

src/libs/ReportNameUtils.ts

…ameter

marufsharifi · 2026-02-20T10:04:49Z

@eVoloshchak, I've addressed your comment. Please take another look. thanks.

eVoloshchak

LGTM!

marufsharifi · 2026-02-25T07:29:13Z

@grgia, kindly bump. thanks.

github-actions · 2026-02-26T15:49:18Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-26T15:53:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #76204.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cf4e836-b8486d2-b5f5274acf3ac362fdec4eb4d04f0eca5538cabd/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cf4e836-b8486d2-b076364cfc6731862b363946385ec33d7d77afb5/index.html

Web 🕸️
https://76204.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-26T15:58:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-27T15:24:38Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.27-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-02T22:15:58Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…ead function of getReportName

clear reportIDToNameMap every time report collection update

266422a

marufsharifi requested review from a team as code owners November 27, 2025 05:33

melvin-bot bot assigned marufsharifi Nov 27, 2025

melvin-bot bot requested review from eVoloshchak and heyjennahay and removed request for a team November 27, 2025 05:34

melvin-bot bot removed the request for review from a team November 27, 2025 05:34

heyjennahay previously approved these changes Nov 27, 2025

View reviewed changes

Merge branch 'main' into fix/visibility-of-admin-tag-LHN-member

d830555

marufsharifi mentioned this pull request Jan 1, 2026

[$250] Workspace - #admin is displayed as #hidden for workspace member's LHN #74674

Open

8 tasks

marufsharifi added 2 commits January 7, 2026 16:36

Merge branch 'main' into fix/visibility-of-admin-tag-LHN-member

e827bb0

Merge branch 'main' into fix/visibility-of-admin-tag-LHN-member

4749f44

marufsharifi added 2 commits January 27, 2026 10:15

Merge branch 'main' into fix/visibility-of-admin-tag-LHN-member

dd85953

keeps chat mentions consistent with LHN previews.

f9c7167

marufsharifi dismissed heyjennahay’s stale review via f9c7167 January 27, 2026 11:01

eVoloshchak reviewed Jan 29, 2026

View reviewed changes

marufsharifi added 2 commits February 11, 2026 08:36

Merge branch 'main' into fix/visibility-of-admin-tag-LHN-member

c49ce7b

replaced deprecated getReportName by new getReportName

4ceb25b

marufsharifi added 2 commits February 16, 2026 11:08

Merge branch 'main' into fix/visibility-of-admin-tag-LHN-member

cec331d

fix(header): restore dynamic report titles in new getReportName

244603b

fixed the lint error

e503393

eVoloshchak suggested changes Feb 18, 2026

View reviewed changes

src/libs/ReportNameUtils.ts Show resolved Hide resolved

src/libs/ReportNameUtils.ts Outdated Show resolved Hide resolved

refactored removed reports action and used the parentReportAction par…

9433cf0

…ameter

eVoloshchak approved these changes Feb 22, 2026

View reviewed changes

melvin-bot bot requested a review from grgia February 22, 2026 22:31

marufsharifi added 2 commits February 24, 2026 11:22

Merge branch 'main' into fix/visibility-of-admin-tag-LHN-member

ae6ad55

fixed prettier

e366244

grgia approved these changes Feb 26, 2026

View reviewed changes

grgia merged commit cf4e836 into Expensify:main Feb 26, 2026
29 checks passed

OSBotify mentioned this pull request Feb 27, 2026

Deploy Checklist: New Expensify 2026-02-27 #83700

Closed

truph01 mentioned this pull request Mar 2, 2026

fix: the mentioned room is not highlighted in policy profile page #55846

Merged

53 tasks

sosek108 added a commit to callstack-internal/Expensify-App that referenced this pull request Mar 3, 2026

Remove logic introduced in Expensify#76204 and restoring pure value-r…

8a3b3f1

…ead function of getReportName

sosek108 mentioned this pull request Mar 3, 2026

fix: port CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS case to computeReportName #83460

Merged

51 tasks

	mentionDisplayText = removeLeadingLTRAndHash(report?.reportID && report?.reportName ? report?.reportName : 'Hidden');
	mentionDisplayText = removeLeadingLTRAndHash(report?.reportID && report?.reportName ? report?.reportName : translate('common.hidden'));

Conversation

marufsharifi commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 27, 2025

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Nov 30, 2025

Uh oh!

marufsharifi commented Dec 1, 2025

Uh oh!

eVoloshchak commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 4, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

eVoloshchak commented Dec 4, 2025

Uh oh!

marufsharifi commented Dec 7, 2025

Uh oh!

marufsharifi commented Dec 11, 2025

Uh oh!

marufsharifi commented Jan 26, 2026

Uh oh!

marufsharifi commented Jan 27, 2026

Uh oh!

marufsharifi commented Jan 29, 2026

Uh oh!

eVoloshchak Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

marufsharifi Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

marufsharifi Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

eVoloshchak Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

marufsharifi commented Feb 2, 2026

Uh oh!

marufsharifi commented Feb 4, 2026

Uh oh!

marufsharifi commented Feb 11, 2026

Uh oh!

marufsharifi commented Feb 11, 2026

Uh oh!

marufsharifi commented Feb 11, 2026

Uh oh!

eVoloshchak commented Feb 12, 2026

Uh oh!

marufsharifi commented Feb 16, 2026

Uh oh!

marufsharifi commented Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

marufsharifi commented Feb 20, 2026

Uh oh!

eVoloshchak left a comment

marufsharifi commented Nov 27, 2025 •

edited

Loading

eVoloshchak commented Dec 3, 2025 •

edited

Loading

codecov bot commented Dec 4, 2025 •

edited by github-actions bot

Loading