fix: port CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS case to computeReportName by sosek108 · Pull Request #83460 · Expensify/App

sosek108 · 2026-02-25T16:35:25Z

Explanation of Change

computeReportName in src/libs/ReportNameUtils.ts is the current implementation of report name resolution, introduced on Oct 29, 2025 as part of the refactor away from ReportUtils.getReportName. However, on Jan 11, 2026, PR #78267 added handling for the CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS action type to the old getReportName — after computeReportName had already been created — so this branch was never ported over.

As a result, any thread whose parent action is CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS would display a blank or generic title instead of the correct system message. This PR ports the missing case into computeReportName, importing getCreatedReportForUnapprovedTransactionsMessage from ReportActionsUtils and wiring it up identically to the old implementation.

The regression was identified from a bot P2 comment on PR #83031.

Fixed Issues

$ #76852
PROPOSAL:

Tests

create new branch from this
merge changes from refactor: Remove deprecated report name functions in ReportUtils (Part 3) #83031
go through test cases from QA steps

Offline tests

Same as QA

QA Steps

Use case from this PR

Sign in ND
Go to workspace chat
Submit 2 expenses
Hold one of them
Tap the "Approve" button => Only approve unheld expenses
Verify that the held expenses are moved to a new report
Open that new report
Verify that the report displays a message created this report for any held expense from #{original report} from "Concierge"
Right click on the message and Reply in a thread
Verify the name of the created thread

Use case from this PR

Invite User B to the workspace as a member.
User A creates a workspace room or sends a message in the workspace chat.
User A mentions the #admins room.
Review User B’s LHN and chat to verify that #admins is displayed as #hidden.
User A promotes User B to admin.
Review User B’s LHN and chat to verify that #admins is displayed as #admins.
User A demotes User B back to member.
Review User B’s LHN and chat to verify that #admins is displayed as #hidden.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…eportName

melvin-bot · 2026-02-25T16:47:30Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sosek108 · 2026-02-25T16:49:14Z

After this comment I've moved missing logic to computeReportName. This PR cannot be tested by QA as its logic is not yet visible (waits for getReportName full refactor).

cc: @shubham1206agra @mohammadjafarinejad @waterim @neil-marcellini

codecov · 2026-02-25T16:50:16Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportNameUtils.ts	`81.09% <100.00%> (-0.26%)`	⬇️
src/pages/inbox/HeaderView.tsx	`86.20% <100.00%> (+1.27%)`	⬆️
... and 13 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c738bb6ed9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/ReportNameUtils.ts

sosek108 · 2026-02-26T09:16:18Z

I doubt if this is really needed. See my comment to original implementation: https://github.com/Expensify/App/pull/78267/changes#r2857877391

sosek108 · 2026-02-26T09:58:50Z

Got an hint that this is used in header of chat report, but not reflected in the QA steps

eVoloshchak · 2026-03-02T13:55:20Z

This PR cannot be tested by QA as its logic is not yet visible (waits for getReportName full refactor).

@sosek108, should this PR wait until the completion of getReportName refactor (so the QA can test it)?

neil-marcellini

The code looks good but let's please find a way to test this, even if it requires testing with the [App] refactor: Remove deprecated report name functions in ReportUtils (Part 3)

src/libs/ReportNameUtils.ts

…ead function of getReportName

sosek108 · 2026-03-03T16:16:33Z

@neil-marcellini I did test the PR with changes from #83031. And logic works as expected.

I tested test cases from PR: #78267 and from #76204

neil-marcellini

Good to go, pending C+ review. Thank you.

eVoloshchak · 2026-03-04T12:32:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-04.at.18.04.46.mov

Android: mWeb Chrome

Screen.Recording.2026-03-04.at.18.08.14.mov

iOS: HybridApp

Screen.Recording.2026-03-04.at.17.55.23.mov

iOS: mWeb Safari

Screen.Recording.2026-03-04.at.17.58.31.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-04.at.17.48.16.mov

Screen.Recording.2026-03-04.at.17.35.09.mov

eVoloshchak

LGTM!

github-actions · 2026-03-04T17:59:20Z

🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-04T18:04:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83460.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e8154a4-7e28b30-8f8d0c1284ca49c9f2cb10d965f27036abc64fee/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e8154a4-7e28b30-564476df3faec5fd1b69a8773b1dcd22a48d3f94/index.html

Web 🕸️
https://83460.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-04T18:16:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-04T18:35:57Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.31-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T03:48:38Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: port CREATED_REPORT_FOR_UNAPPROVED_TRANSACTIONS case to computeR…

628c153

…eportName

melvin-bot bot assigned sosek108 Feb 25, 2026

prettier fix

c738bb6

This was referenced Feb 25, 2026

[Due for payment 2026-03-31] Remove deprecated report name functions in ReportUtils #76852

Open

refactor: Remove deprecated report name functions in ReportUtils (Part 3) #83031

Merged

sosek108 marked this pull request as ready for review February 25, 2026 16:47

sosek108 requested review from a team as code owners February 25, 2026 16:47

melvin-bot bot requested review from eVoloshchak and heyjennahay and removed request for a team February 25, 2026 16:47

chatgpt-codex-connector bot reviewed Feb 25, 2026

View reviewed changes

src/libs/ReportNameUtils.ts Show resolved Hide resolved

neil-marcellini reviewed Mar 2, 2026

View reviewed changes

github-actions bot reviewed Mar 2, 2026

View reviewed changes

src/libs/ReportNameUtils.ts Show resolved Hide resolved

sosek108 added 2 commits March 3, 2026 16:37

Merge branch 'main' into fix/computeReportName-unapproved

0142aef

Remove logic introduced in Expensify#76204 and restoring pure value-r…

8a3b3f1

…ead function of getReportName

sosek108 added 4 commits March 3, 2026 17:21

prettier fix

3832aef

doc comment on getReportName

6d2b3f9

typecheck fix

ba9324d

typecheck fix

c679d6b

neil-marcellini previously approved these changes Mar 3, 2026

View reviewed changes

Merge branch 'main' into fix/computeReportName-unapproved

fb15e01

test repair

0bcc133

sosek108 dismissed neil-marcellini’s stale review via 0bcc133 March 4, 2026 09:20

test repair

1844903

eVoloshchak approved these changes Mar 4, 2026

View reviewed changes

melvin-bot bot requested a review from neil-marcellini March 4, 2026 17:09

neil-marcellini approved these changes Mar 4, 2026

View reviewed changes

neil-marcellini merged commit e8154a4 into Expensify:main Mar 4, 2026
30 checks passed

OSBotify mentioned this pull request Mar 4, 2026

Deploy Checklist: New Expensify 2026-03-04 #84164

Closed

Conversation

sosek108 commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 25, 2026

Uh oh!

sosek108 commented Feb 25, 2026

Uh oh!

codecov bot commented Feb 25, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

sosek108 commented Feb 26, 2026

Uh oh!

sosek108 commented Feb 26, 2026

Uh oh!

eVoloshchak commented Mar 2, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sosek108 commented Mar 3, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sosek108 commented Feb 25, 2026 •

edited

Loading

codecov bot commented Feb 25, 2026 •

edited by github-actions bot

Loading

eVoloshchak commented Mar 4, 2026 •

edited

Loading