refactor: Remove deprecated report name functions in ReportUtils (Part 3)#83031
Merged
neil-marcellini merged 7 commits intoExpensify:mainfrom Mar 9, 2026
Merged
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
melvin-bot
bot
requested review from
JmillsExpensify and
eVoloshchak
and removed request for
a team and
JmillsExpensify
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mohammadjafarinejad
changed the title
mohammadjafarinejad
changed the title
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/pages/media/AttachmentModalScreen/routes/report/ReportAvatarModalContent.tsx
Outdated
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dccd14f189
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
51 tasks
sosek108
approved these changes
Feb 26, 2026
Contributor
sosek108
left a comment
sosek108
left a comment
There was a problem hiding this comment.
This PR looks goot to me. There is one comment from Codex, but this part is handled in another PR. We still need to confirm if the mentioned code is used at all
Contributor
|
@MelvinBot, merge main and resolve conflicts |
Contributor
|
Merged
|
Contributor
|
@MelvinBot, This branch has conflicts that must be resolved, merge main, resolve conflicts, and push the new commit here |
Resolved conflicts in 7 files by keeping the new ReportNameUtils.getReportName(report, reportAttributes) API while incorporating main's structural changes (e.g., useMappedPersonalDetails in ReportWelcomeText). Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>
Contributor
|
Merged
|
Contributor
|
@MelvinBot, some checks are failing |
- Fix import ordering in RoomInvitePage.tsx (Prettier) - Remove canBeMissing option from useOnyx calls in RoomMembersPage.tsx and ReportAvatarModalContent.tsx (removed from useOnyx API on main) Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>
Contributor
|
Fixed the two PR-related failing checks:
Unrelated failure: The |
Contributor
Reviewer Checklist
Screenshots/VideosTests 1-8
|
neil-marcellini
previously approved these changes
Mar 2, 2026
Contributor
neil-marcellini
left a comment
neil-marcellini
left a comment
There was a problem hiding this comment.
Overall, the code looks good. I do think we should hold based on this comment, because otherwise this pull request could create a regression.
neil-marcellini
changed the title
neil-marcellini
changed the title
Contributor
|
@mohammadjafarinejad The PR this was held on has merged, so let's merge main and then I think we can move this forward. |
Contributor
Author
|
@neil-marcellini Ready for re-review. |
neil-marcellini
approved these changes
Mar 9, 2026
Contributor
neil-marcellini
left a comment
neil-marcellini
left a comment
There was a problem hiding this comment.
Good to go, thank you.
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
75 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.3.34-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀
|
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Migrates component call sites from the deprecated
ReportUtils.getReportNametoReportNameUtils.getReportName, passingreportAttributes(viauseReportAttributeshook) as the second argument to ensure computed report names are returned correctly.Changed Files
Fixed Issues
$ #76852
PROPOSAL:
Tests
1. Open a report and verify the report name displays correctly in the header (
AvatarWithDisplayName)2. Open a report and verify the welcome message shows the correct report name (
ReportWelcomeText)3. Open a room's invite page and verify the report name appears correctly in the header (
RoomInvitePage)4. Open a room's members page and verify the report name appears in the subtitle (
RoomMembersPage)5. Open the share code page for a report and verify the title shows the correct report name (
ShareCodePage)6. Open a trip chat and verify the current chat name pre-fills correctly on the edit name page (
TripChatNameEditPage)7. Open a report avatar and verify the header title shows the correct report name (
ReportAvatarModalContent)8. Verify archived reports still show the
(archived)suffix in all of the above locations(archived)is appended to the report name in every location aboveOffline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
iOS: Native
ios.mp4
MacOS: Chrome / Safari
web.mp4