Add OpenSearchCardFiltersPage command#85947
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…f github.com:Expensify/App into jsenyitko-open-search-card-filters-page
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d35c1621b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@abzokhattab yep! Would you mind reviewing this one please? |
|
Yeah, no problem reviewing it as well |
src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx
Outdated
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-10.at.18.17.11.movAndroid: mWeb ChromeScreen.Recording.2026-02-10.at.18.26.57.moviOS: HybridAppScreen.Recording.2026-02-10.at.18.17.11.moviOS: mWeb SafariScreen.Recording.2026-02-10.at.18.26.57.movMacOS: Chrome / SafariScreen.Recording.2026-02-10.at.18.14.38.mov |
|
PR doesn’t need product input as a performance PR. Unassigning and unsubscribing myself. |
|
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
The PR looks good i just have one comment here .. please let me know what u think about it @JS00001 |
|
🎯 @abzokhattab, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #86280. |
…f github.com:Expensify/App into jsenyitko-open-search-card-filters-page
|
Updated, thanks @abzokhattab ! |
|
@luacmartins over to you |
| } | ||
|
|
||
| function openSearchCardFiltersPage() { | ||
| const finallyData: Array<OnyxUpdate<typeof ONYXKEYS.IS_SEARCH_FILTERS_CARD_DATA_LOADED>> = [ |
There was a problem hiding this comment.
Why do we need this key? It seems like it can only ever be undefined when we haven't called this API at least once, or it's always true. Can we skip this entirely and use other keys to determine if we should show the loading indicator?
There was a problem hiding this comment.
I dont think so, no, we don't have a way of checking if this command has completed before,outside of storing a key for it.
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here). Failure details: https://github.com/Expensify/Expensify/actions/runs/23647059042 |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|
Explanation of Change
Adds an OpenSearchCardFiltersPage command, when opening the search card filters page
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/558953
Tests
Add company cards & transactions
Open the filters > card filter RHP
Ensure that the same cards are visible as production
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-03-23.at.10.29.10.AM.mov