[Payment due @abzokhattab] Add OpenSearchCardFiltersPage command to the Feed selector#86319
[Payment due @abzokhattab] Add OpenSearchCardFiltersPage command to the Feed selector#86319
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@abzokhattab can you please review this since you also reviewed #85947? |
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1700e69614
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Yess sure |
| ListItem={MultiSelectListItem} | ||
| onSelectRow={updateSelectedItems} | ||
| textInputOptions={textInputOptions} | ||
| /> |
There was a problem hiding this comment.
{loading ? (
<View style={[styles.flex1, styles.justifyContentCenter, styles.alignItemsCenter]}>
<ActivityIndicator
size={CONST.ACTIVITY_INDICATOR_SIZE.SMALL}
color={theme.spinner}
reasonAttributes={reasonAttributes}
/>
</View>
) :(
<SelectionList
shouldSingleExecuteRowSelect
data={listData}
ListItem={MultiSelectListItem}
onSelectRow={updateSelectedItems}
textInputOptions={textInputOptions}
/>
)}NAB, but this is a bit more readable
|
@JS00001 Should i review it or @eVoloshchak would? |
|
I think it'd be better for @abzokhattab to review since they reviewed the last PR and have more context, sorry about that @eVoloshchak |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-01.at.04.32.48.movAndroid: mWeb ChromeScreen.Recording.2026-04-01.at.04.35.05.moviOS: HybridAppScreen.Recording.2026-04-01.at.04.32.48.moviOS: mWeb SafariScreen.Recording.2026-04-01.at.04.35.05.movMacOS: Chrome / SafariScreen.Recording.2026-04-01.at.04.27.10.mov |
|
@JS00001 I found a bug where the selector is flickery in android Screen.Recording.2026-04-01.at.04.42.17.movi am not sure if its an existing bug or was introduced by the current PR |
|
@abzokhattab could you check if you are able to see that behavior on main as well please? |
|
Yes, I was able to reproduce it on main as well Screen.Recording.2026-04-01.at.14.09.55.movso this is safe for merge |
|
🎯 @abzokhattab, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.52-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR adds a loading indicator (spinner) to the Feed selector dropdown while card data is being fetched via |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀
|
|
🤖 Payment issue created: #87189 |
Explanation of Change
Based on #85947, lets also add the OpenSearchCardFiltersPage loading indicator to the feed selector dropdown, so that the user is guaranteed to have the correct card data.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/558953
Tests
Add company cards & transactions
Open the 'Statements' suggested search
Open the 'Feed' dropdown
Ensure that the same cards are visible as production
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Screen.Recording.2026-03-25.at.10.10.08.AM.mov