performance: Always mount `SplashScreenHider` and control hide timing via prop instead of conditional rendering by war-in · Pull Request #86226 · Expensify/App

war-in · 2026-03-24T13:55:42Z

Explanation of Change

Previously, SplashScreenHider was conditionally rendered — it only mounted once shouldHideSplash became true. On native, the component then had to wait for the logo SVG onLoadEnd callback before starting the hide animation. This added unnecessary latency to every app start: mount time + SVG load time before the splash could begin dismissing.

This PR changes the approach so that SplashScreenHider is always mounted from the start. A new shouldHideSplash prop controls when the hide animation fires via a useEffect. On native, the onLoadEnd trigger is removed since the logo SVG is already loaded by the time we're ready to hide. The component is unmounted after onHide completes to clean up.

Both platforms also switch the hide callback to useEffectEvent to avoid stale closure issues without needing it in the dependency array.

I measured the performance gains and I was able to lower the app startup time (ManualAppStartup metric) by ~250ms (from initial `~3s). I tested it in a release build using the Applause account on my Samsung Galaxy Z Flip 5.

Fixed Issues

$ #85883

Tests

Open the app (cold start)
Verify the splash screen appears and smoothly animates away
Verify the app loads normally after the splash screen hides
Force close and reopen the app (warm start)
Verify the splash screen still hides correctly
Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open the app (cold start) on all platforms
Verify the splash screen appears and smoothly animates away
Verify the app loads normally after the splash screen hides
Force close and reopen the app
Verify the splash screen still hides correctly

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

timing via prop instead of conditional rendering

codecov · 2026-03-24T14:06:24Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/Expensify.tsx	`88.13% <100.00%> (+0.30%)`	⬆️
src/components/SplashScreenHider/index.native.tsx	`100.00% <100.00%> (ø)`
src/components/SplashScreenHider/index.tsx	`0.00% <0.00%> (ø)`
... and 52 files with indirect coverage changes

sumo-slonik · 2026-03-25T10:26:48Z

LGTM 🚀

sumo-slonik · 2026-03-25T10:27:47Z

It's surprising that such a change can affect the result by as much as 100 ms, very nice catch 🦅

melvin-bot · 2026-03-25T12:52:31Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-03-25T13:01:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screenrecorder-2026-03-26-12-21-45-488.mp4

Android: mWeb Chrome

Screenrecorder-2026-03-26-12-24-56-876.mp4

iOS: HybridApp

2026-03-26.12.47.34.mov

iOS: mWeb Safari

video_2026-03-26_12-48-27.mp4

MacOS: Chrome / Safari

2026-03-26.12.10.04.mov

ZhenjaHorbach · 2026-03-25T13:02:33Z

@FitseTLT
Sorry
I suppose I'm a reviewer here 😅

ZhenjaHorbach · 2026-03-25T18:20:48Z

@Julesssss
Could you please run adhoc builds here?

joekaufmanexpensify · 2026-03-25T21:13:18Z

No product review needed

github-actions · 2026-03-25T21:13:19Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

Julesssss

Nice find

war-in · 2026-03-26T10:14:55Z

@ZhenjaHorbach adhocs are ready!

ZhenjaHorbach · 2026-03-26T10:56:54Z

Working on it!

ZhenjaHorbach · 2026-03-26T11:35:19Z

Actually, on Android, I don't see any difference 😅
But on iOS it looks really fast!

But maybe it's just a phone-specific

ZhenjaHorbach · 2026-03-26T11:52:49Z

But LGTM!

war-in · 2026-03-26T12:57:46Z

Actually, on Android, I don't see any difference 😅

Yeah, it's hard to catch it by only looking at the screen. I modified the code to display ManualAppStartup and read logs from logcat. Also, those times can vary by even 1 second

github-actions · 2026-03-26T16:41:33Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-26T16:46:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86226.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-264543e-3063164-d1443296f91b9af0d96cf759e96e3ccf9d4bbb73/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-264543e-3063164-62fec11c9b2d2531c8dcd405eaf337042fb5edeb/index.html

Web 🕸️
https://86226.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-26T16:48:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-27T12:52:04Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.50-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-03-27T12:53:47Z

I reviewed the changes in this PR and checked the help site files under docs/articles.

No help site changes are required.

This PR is a purely internal performance optimization to the SplashScreenHider component — it changes how the component is mounted and when the hide animation is triggered. Specifically:

SplashScreenHider is now always mounted (instead of conditionally rendered), with a shouldHideSplash prop controlling when the hide animation fires
The native implementation removes the onLoadEnd SVG callback in favor of a useEffect trigger
Both platforms switch to useEffectEvent for the hide callback

These changes don't affect any user-facing feature, setting, label, workflow, or functionality that would be documented in the help site. No articles reference the splash screen or app boot behavior.

jponikarchuk · 2026-03-30T11:26:27Z

Deploy Blocker #86642 was identified to be related to this PR.

OSBotify · 2026-03-31T21:51:54Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

performance: Always mount SplashScreenHider and control hide

e3c1764

timing via prop instead of conditional rendering

melvin-bot bot assigned war-in Mar 24, 2026

war-in marked this pull request as ready for review March 25, 2026 12:52

war-in requested review from a team as code owners March 25, 2026 12:52

melvin-bot bot requested a review from FitseTLT March 25, 2026 12:52

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 25, 2026 12:52

This was referenced Mar 25, 2026

[Due for payment 2026-04-14] [Due for payment 2026-04-07] Investigate migration to native BootSplash animation on Android #85883

Open

[Tracking] Improve the bootsplash time when opening the app #74832

Open

Julesssss requested review from ZhenjaHorbach and removed request for FitseTLT March 25, 2026 21:13

joekaufmanexpensify requested review from FitseTLT and removed request for joekaufmanexpensify March 25, 2026 21:13

Julesssss reviewed Mar 25, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

ZhenjaHorbach approved these changes Mar 26, 2026

View reviewed changes

melvin-bot bot requested a review from Julesssss March 26, 2026 11:53

Julesssss approved these changes Mar 26, 2026

View reviewed changes

Julesssss merged commit 264543e into Expensify:main Mar 26, 2026
46 of 49 checks passed

OSBotify mentioned this pull request Mar 27, 2026

Deploy Checklist: New Expensify 2026-03-27 #86530

Closed

86 tasks

This was referenced Mar 30, 2026

Revert "performance: Always mount SplashScreenHider and control hide timing via prop instead of conditional rendering" #86659

Merged

fix: start HybridApp splashScreenState as undefined until native settings arrive #86676

Merged

Conversation

war-in commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 24, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sumo-slonik commented Mar 25, 2026

Uh oh!

sumo-slonik commented Mar 25, 2026

Uh oh!

melvin-bot bot commented Mar 25, 2026

Uh oh!

ZhenjaHorbach commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Mar 25, 2026

Uh oh!

ZhenjaHorbach commented Mar 25, 2026

Uh oh!

joekaufmanexpensify commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

war-in commented Mar 26, 2026

Uh oh!

ZhenjaHorbach commented Mar 26, 2026

Uh oh!

ZhenjaHorbach commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 26, 2026

Uh oh!

war-in commented Mar 26, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

OSBotify commented Mar 27, 2026

Uh oh!

MelvinBot commented Mar 27, 2026

Uh oh!

jponikarchuk commented Mar 30, 2026

Uh oh!

OSBotify commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

war-in commented Mar 24, 2026 •

edited

Loading

codecov bot commented Mar 24, 2026 •

edited by github-actions bot

Loading

ZhenjaHorbach commented Mar 25, 2026 •

edited

Loading

ZhenjaHorbach commented Mar 26, 2026 •

edited

Loading