fix: start HybridApp splashScreenState as undefined until native settings arrive by war-in · Pull Request #86676 · Expensify/App

war-in · 2026-03-30T17:17:06Z

Explanation of Change

Root cause: splashScreenState always initialized as VISIBLE, even in the HybridApp OD sign-out flow where the native bootsplash isn't on screen. This caused PR #86226 (which mounted SplashScreenHider early) to show an infinite BootSplash on the sign-in page.

Fix: Make splashScreenState start as undefined for HybridApp. HybridAppHandler resolves it to VISIBLE or HIDDEN as soon as native settings arrive — the earliest possible moment we know whether the splash is on screen.

State flows after this change:

Standalone: VISIBLE → HIDDEN (unchanged)
HybridApp normal: undefined → VISIBLE → READY_TO_BE_HIDDEN → HIDDEN
HybridApp OD sign-out: undefined → HIDDEN (SplashScreenHider never mounts)

SplashScreenHider now mounts when isSplashVisible || isSplashReadyToBeHidden, giving it time to pre-render (mount Reanimated views, load SVG) before shouldHideSplash becomes true. This reduces the ManualAppStartup metric by eliminating the mount delay.

All existing consumers that check === HIDDEN or !== HIDDEN work correctly with undefined — no logic changes needed in those files.

Fixed Issues

$ #85883

Tests

Open the web app
Verify splash screen animates out normally with no delay regression
HybridApp normal transition: Open the app via OldDot → Try New Expensify
Verify splash animates out normally
HybridApp OD sign-out: Sign out from OldDot
Verify the NewDot sign-in page shows immediately with no green overlay flash
HybridApp cold start: Open app via icon
Verify BootSplash animates correctly

Offline tests

N/A — splash screen logic is local, no network dependency.

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-03-30T17:26:46Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/Expensify.tsx	`87.71% <100.00%> (+0.10%)`	⬆️
src/SplashScreenStateContext.tsx	`93.33% <100.00%> (+0.47%)`	⬆️
src/components/SplashScreenHider/index.native.tsx	`100.00% <100.00%> (ø)`
src/libs/telemetry/bootsplashTelemetry.ts	`91.66% <100.00%> (ø)`
src/HybridAppHandler.tsx	`50.00% <50.00%> (ø)`
src/components/SplashScreenHider/index.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

melvin-bot · 2026-03-30T17:29:00Z

@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: adf85d9a10

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/HybridAppHandler.tsx

ZhenjaHorbach · 2026-03-30T17:51:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screenrecorder-2026-04-02-14-13-48-874.mp4

Android: mWeb Chrome

Screenrecorder-2026-04-02-14-16-23-58.mp4

iOS: HybridApp

2026-03-26.12.47.34.mov

iOS: mWeb Safari

video_2026-03-26_12-48-27.mp4

MacOS: Chrome / Safari

2026-04-02.14.08.35.mov

github-actions · 2026-03-30T19:20:22Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

# Conflicts: # src/Expensify.tsx

ZhenjaHorbach · 2026-04-01T09:16:43Z

@war-in
Could you check TS issues?

war-in · 2026-04-01T12:47:00Z

@ZhenjaHorbach fixed! Looks like we'll need another adhoc because part of the core logic disappeared

@Julesssss could you rerun the adhocs?

github-actions · 2026-04-01T17:01:56Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-01T17:07:03Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86676.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-490a3c5-7ece5a5-4d3f2baad3685b49f0268c1ce2814c934f0c488e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-490a3c5-7ece5a5-556e2d280265f95658f1c10ca99c30c30003899d/index.html

Web 🕸️
https://86676.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ZhenjaHorbach · 2026-04-02T12:25:09Z

LGTM!

war-in · 2026-04-02T14:20:39Z

@Julesssss could you review? 🙏 We had to revert the previous PR because it introduced a deploy blocker

github-actions · 2026-04-02T19:03:11Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-02T19:08:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86676.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-59fe031-dddefdc-ef841087b7d423e089b8149f38acb93f570c3c41/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-59fe031-dddefdc-aa8336b7b7495968e59d8dfa12f5223008839841/index.html

Web 🕸️
https://86676.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-02T19:11:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-02T20:21:11Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-02T20:22:30Z

No help site changes are required.

This PR is an internal implementation fix for the HybridApp splash screen state management (SplashScreenStateContext, HybridAppHandler, SplashScreenHider, bootsplash telemetry). None of these changes affect user-facing features, settings, UI labels, or workflows documented in docs/articles — the splash screen is an internal app loading mechanism, not something end users configure or interact with.

OSBotify · 2026-04-07T01:12:10Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: dont show splash on OD signout

adf85d9

melvin-bot bot assigned war-in Mar 30, 2026

war-in marked this pull request as ready for review March 30, 2026 17:28

war-in requested review from a team as code owners March 30, 2026 17:28

melvin-bot bot requested review from cretadn22 and joekaufmanexpensify and removed request for a team and joekaufmanexpensify March 30, 2026 17:28

war-in changed the title ~~fix: dont show splash on OD signout~~ fix: start HybridApp splashScreenState as undefined until native settings arrive Mar 30, 2026

chatgpt-codex-connector bot reviewed Mar 30, 2026

View reviewed changes

src/HybridAppHandler.tsx Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Merge branch 'main' into war-in/fix-OD-signout-bootsplash

32fbe93

# Conflicts: # src/Expensify.tsx

war-in added 2 commits April 1, 2026 14:38

Merge branch 'main' into war-in/fix-OD-signout-bootsplash

1def202

fix: trigger hide on shouldHideSplash change

490a3c5

ZhenjaHorbach approved these changes Apr 2, 2026

View reviewed changes

melvin-bot bot requested a review from Gonals April 2, 2026 12:25

Julesssss approved these changes Apr 2, 2026

View reviewed changes

Julesssss merged commit 59fe031 into Expensify:main Apr 2, 2026
34 checks passed

OSBotify mentioned this pull request Apr 2, 2026

Deploy Checklist: New Expensify 2026-04-02 #86989

Closed

roryabraham mentioned this pull request Apr 6, 2026

[Metrics] Improve App Start Time Performance #77171

Open

melvin-bot bot mentioned this pull request Apr 7, 2026

[Due for payment 2026-04-14] [Due for payment 2026-04-07] Investigate migration to native BootSplash animation on Android #85883

Open

Conversation

war-in commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 30, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

This comment has been minimized.

ZhenjaHorbach commented Apr 1, 2026

Uh oh!

war-in commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

ZhenjaHorbach commented Apr 2, 2026

Uh oh!

war-in commented Apr 2, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

MelvinBot commented Apr 2, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

war-in commented Mar 30, 2026 •

edited

Loading

codecov bot commented Mar 30, 2026 •

edited by github-actions bot

Loading

ZhenjaHorbach commented Mar 30, 2026 •

edited

Loading