Skip to content

fix: android pressability issue with measureAsyncOnUI patch (v5) #86708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneetlath merged 5 commits into from
Apr 1, 2026
Merged

fix: android pressability issue with measureAsyncOnUI patch (v5) #86708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8d9342
fix: android pressability issue with measureAsyncOnUI patch
MelvinBot Mar 31, 2026
d702ac5
Update pressability new arch patch with safety fixes
MelvinBot Mar 31, 2026
72b78b4
Fix measureAsyncOnUI callback type in Spec interface
MelvinBot Mar 31, 2026
daab92c
Invoke callback with zeroed measurements on Android failure path
MelvinBot Mar 31, 2026
2f2e42c
Merge main: renumber pressability patch from 034 to 035
MelvinBot Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions patches/react-native/details.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,3 +258,9 @@
- Reason: Fixes a Fabric regression where VoiceOver on iOS only announces "expanded" but never "collapsed" for elements with `accessibilityState.expanded`. In `RCTViewComponentView.mm`, the code uses `value_or(false)` which skips the announcement entirely when `expanded` is `false`. This patch changes the logic to use `has_value()` and correctly announce both "expanded" and "collapsed" states, matching the old architecture (Paper) behavior.
- Upstream PR/issue: https://github.com/facebook/react-native/issues/56296
- E/App issue: [#76929](https://github.com/Expensify/App/issues/76929)

### [react-native+0.83.1+035+fix-pressability-new-arch.patch](react-native+0.83.1+035+fix-pressability-new-arch.patch)

- Reason: Fixes an Android-specific issue (reproducible on certain Samsung models) where `onPress` events do not trigger for `Pressable` components when used inside a `Tooltip`. The root cause is that in the new architecture, `Pressability.measure()` reads stale layout information from the shadow tree instead of the actual native view hierarchy. This patch introduces a new `measureAsyncOnUI` method that measures the view asynchronously using the native layout hierarchy on the UI thread, bypassing stale shadow tree data.
- Upstream PR/issue: [facebook/react-native#51835](https://github.com/facebook/react-native/pull/51835)
- E/App issue: [#59953](https://github.com/Expensify/App/issues/59953)
Loading
Loading