fix: update local file handling in MoneyRequestConfirmationListFooter… by kubabutkiewicz · Pull Request #87340 · Expensify/App

kubabutkiewicz · 2026-04-08T08:19:53Z

update local file handling in MoneyRequestConfirmationListFooter to manage resolved receipt images

Explanation of Change

Fixed Issues

$#87301
$#87284
PROPOSAL:

Tests

Go to workspace chat.
Click + > Create expense > Scan.
Upload a receipt.
On confirm page, click on the receipt.
Click Replace.
Upload a different receipt.
Click on the receipt.
Confirm page will show the replaced receipt.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

… to manage resolved receipt images

melvin-bot · 2026-04-08T08:20:05Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-08T08:32:42Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../components/MoneyRequestConfirmationListFooter.tsx	`56.25% <80.00%> (+0.08%)`	⬆️
... and 14 files with indirect coverage changes

brunovjk · 2026-04-08T17:03:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

87340_anrdoid_web.mov

iOS: HybridApp

iOS: mWeb Safari

87340_ios_web.mov

MacOS: Chrome / Safari

87340_web_chrome.mov

github-actions · 2026-04-08T19:46:47Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-04-08T19:51:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-08T19:51:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87340.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b42aaf7-77157b8-a18fb4530859148d3f4a352c390730bfdb066fc8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b42aaf7-77157b8-a1df5cc394215b2829f94b1402aaea1ef2f2c1dc/index.html

Web 🕸️
https://87340.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…pe-after-scan fix: update local file handling in MoneyRequestConfirmationListFooter… (cherry picked from commit b42aaf7) (cherry-picked to staging by roryabraham)

OSBotify · 2026-04-08T21:07:59Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.54-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

iOS

MelvinBot · 2026-04-08T21:12:28Z

No help site changes are required for this PR.

This is a bug fix to internal ref tracking in MoneyRequestConfirmationListFooter.tsx — it ensures the receipt preview updates correctly when a user replaces a scanned receipt. No user-facing workflows, UI labels, or features were added or changed.

The existing help article Attach and edit receipts on expenses already documents the Replace flow accurately.

m-natarajan · 2026-04-08T21:50:23Z

Passed, Chrome / v9.3.54-5 and Phone 12 mini / iOS 26.3.1

Repro87340iOS.mp4

bandicam.2026-04-09.00-37-09-657.mp4

Julesssss · 2026-04-08T21:58:33Z

Thank you! Checked off

OSBotify · 2026-04-08T22:01:08Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.54-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-08T22:06:47Z

No help site changes are required for this PR.

This PR fixes an internal React state management bug in how the receipt image source ref is tracked when replacing a scanned receipt. The user-facing workflow is unchanged.

The relevant help article — Attach and edit receipts on expenses — already accurately documents the replace receipt flow and needs no updates.

OSBotify · 2026-04-09T00:33:47Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.54-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-04-09T00:58:51Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.55-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-09T01:02:36Z

No help site changes are required.

This PR is a purely technical bug fix — it updates internal state management for local receipt image handling in MoneyRequestConfirmationListFooter.tsx. There are no changes to user-facing text, feature names, UI labels, navigation flows, or documented workflows. The help site articles under App/docs/articles do not need to be updated.

fix: update local file handling in MoneyRequestConfirmationListFooter…

364afdb

… to manage resolved receipt images

melvin-bot bot assigned kubabutkiewicz Apr 8, 2026

kubabutkiewicz requested review from a team as code owners April 8, 2026 08:19

melvin-bot bot requested review from JmillsExpensify and brunovjk and removed request for a team and JmillsExpensify April 8, 2026 08:20

melvin-bot bot removed the request for review from a team April 8, 2026 08:20

This was referenced Apr 8, 2026

[Due for payment 2026-04-16] Scan - Confirm page shows old receipt when it is replaced with new receipt #87301

Closed

[Due for payment 2026-04-16] Receipt thumbnail on confirmation page not updated after replacing image #87284

Closed

Julesssss approved these changes Apr 8, 2026

View reviewed changes

Julesssss merged commit b42aaf7 into Expensify:main Apr 8, 2026
36 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Apr 8, 2026

OSBotify mentioned this pull request Apr 8, 2026

Deploy Checklist: New Expensify 2026-04-07 #87294

Closed

97 tasks

Conversation

kubabutkiewicz commented Apr 8, 2026 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 8, 2026

Uh oh!

codecov bot commented Apr 8, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brunovjk commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

OSBotify commented Apr 8, 2026

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

OSBotify commented Apr 8, 2026

Uh oh!

MelvinBot commented Apr 8, 2026

Uh oh!

m-natarajan commented Apr 8, 2026

Uh oh!

Julesssss commented Apr 8, 2026

Uh oh!

OSBotify commented Apr 8, 2026

Uh oh!

MelvinBot commented Apr 8, 2026

Uh oh!

OSBotify commented Apr 9, 2026

Uh oh!

OSBotify commented Apr 9, 2026

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kubabutkiewicz commented Apr 8, 2026 •

edited by Julesssss

Loading

codecov bot commented Apr 8, 2026 •

edited by github-actions bot

Loading

brunovjk commented Apr 8, 2026 •

edited

Loading