Skip to content

Improve offline behaviour#14

Merged
mountiny merged 3 commits intoExpensify:mainfrom
rezkiy37:feature/22998-improve-offline-behaviour
Mar 12, 2024
Merged

Improve offline behaviour#14
mountiny merged 3 commits intoExpensify:mainfrom
rezkiy37:feature/22998-improve-offline-behaviour

Conversation

@rezkiy37
Copy link
Copy Markdown
Contributor

@rezkiy37 rezkiy37 commented Mar 5, 2024

Details

The PR improves the offline behavior. It handles to pre-upload of a PDF worker to be able to open PDF files smoothly when the user is offline. It was mentioned here. I use this PDF worker described in docs. Also, it improves the example project to be able to upload and open PDF files.

Related Issues

Expensify/App#22998

Manual Tests

  1. Install deps. for both package and example: npm install && cd example && npm install && cd ...
  2. Please confirm that you run with these local changes to test with the latest codebase.
  3. Run a script - cd example && npm run start && cd .. - of the example.
  4. Verify that Webpack launches successfully.
  5. Verify that it opens a tab.
  6. Verify that the PDF previewer works.
  7. Go offline.
  8. Verify that the previewer still works properly.

Linked PRs

Expensify/App#33434

Offline.mp4
Offline.mp4

@allroundexperts
Copy link
Copy Markdown

allroundexperts commented Mar 10, 2024

Works good!

Screen.Recording.2024-03-11.at.11.42.00.PM.mov
Screen.Recording.2024-03-11.at.11.42.52.PM.mov
Screen.Recording.2024-03-11.at.11.45.57.PM.mov

Copy link
Copy Markdown

@allroundexperts allroundexperts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mountiny mountiny merged commit 85cc36d into Expensify:main Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants