Dynamically update container height#30
Merged
mountiny merged 2 commits intoExpensify:mainfrom Jul 5, 2024
Merged
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
6 tasks
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
mkhutornyi
approved these changes
Jul 3, 2024
mkhutornyi
left a comment
mkhutornyi
left a comment
There was a problem hiding this comment.
Looks good! Checklist will be done in app PR
mountiny
approved these changes
Jul 3, 2024
Contributor
|
@bernhardoj @mkhutornyi sorry lint is failing now |
Contributor
Author
|
@mountiny Lint fixed |
mountiny
approved these changes
Jul 5, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
The container height is only initialized once. This PR updates it so it dynamically updates.
Related Issues
Expensify/App#42566
Manual Tests
Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4