[TS migration] Setup typescript in react-native-onyx

[blazejkustra]

Details

Going forward Onyx code will be written in Typescript, we have to take into consideration transpiling step now.

• From now on .ts code will live in lib catalog and transpiled code will end up in dist catalog. The lib catalog won’t be published to npm; instead, we’ll only publish the dist catalog.
• Webpack is removed, no need for minified version of the code
• We also want to make the library accessible with a standard React.js setup (without react-native-web), to achieve this we can rename […].web.js to […].js, so these are treated as default implementation (+ .native.js for ios and android).

Here is a slack discussion, where it is explained in details why these changes are necessary.

Related Issues

GH_LINK

Automated Tests

N/A (same as before)

Manual Tests

• Delete old dist folder if you have it
• Build the package with npm run build
• Use npm pack command to generate package code (this generates .tgz file, unzip it)
• Copy generated content to App/node_modules/react-native-onyx (use this PR/branch)
• Test if NewDot works as expected on different platforms

Author Checklist

• I linked the correct issue in the ### Related Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[BartoszGrajdek]

LGTM! 😄

[rlinoz]

I am getting some weird behavior like messages not coming through, or not being able to add a new workspace room.

Did you have any of those?

[chrispader]

LGTM, except for one test failing right now! ✅

[chrispader]

Just so you know: I have another PR ongoing which reverts two PRs which are also part of the migration here. Not sure which PR to merge first, but in any case we'll have to revert some of these changes later, and maybe re-apply them in the future...

[blazejkustra]

@rlinoz On what platform? Can you record a video or provide more detailed steps?

edit: I updated both PRs please pull the newest changes

[blazejkustra]

Working on failing test, it's very weird 🤷‍♂️

[chrispader]

LGTM! 🚀

[fabioh8010]

Some minor comments, but in general LTGM! I've tested in all platforms and it's working fine for me.

@blazejkustra What about setting up typecheck and prettier in the lint workflow like we did for Expensify/App here?

[rlinoz]

Tried again today and everything worked fine, probably something weird in my environment yesterday, sorry about that.

[blazejkustra]

@rlinoz I resolved conflicts and adjusted the code after Fabio's review. Can we proceed with a merge? 👀

[blazejkustra]

Just so you know: I have #458 ongoing which reverts two PRs which are also part of the migration here. Not sure which PR to merge first, but in any case we'll have to revert some of these changes later, and maybe re-apply them in the future...

@chrispader I think we can proceed with TS setup first, wdyt?