[TS migration] Setup typescript in expensify-common & Migrate CONST, fastMerge, Device, Logger to Typescript

[blazejkustra]

Going forward expensify-common code can be written in Typescript, we have to take into consideration transpiling step now.

TS code will live in lib catalog and transpiled code will end up in dist catalog. The lib catalog won’t be published to npm; instead, we’ll only publish the dist catalog.

⚠️ This means that from now on expensify-common imports will look like this:

// Before:
import ExpensiMark from 'expensify-common/lib/ExpensiMark';

// After:
import {ExpensiMark, Str} from 'expensify-common';
// or
import ExpensiMark from 'expensify-common/dist/ExpensiMark';

Here is a similar PR that prepared Onyx for a similar migration.

Fixed Issues

$ Expensify/App#42245

[jnowakow]

LGTM

[carlosmiceli]

@tgolen I thought I'd bring you in to review this one, since I may not be the best suited to confirm that everything is as it should... I haven't seen anything wrong in the code, but I think a second more veteran opinion is worth it here.

[tgolen]

I'm really sorry. I was not able to review this today due to being heads-down getting comp review ready. I will be OOO for the next 1.5 week, so I will assign someone else to review.

[roryabraham]

Also, what is the plan for publishing this? Right now, expensify-common is consumed via a git hash in E/App's package.json

That could work if we commit dist, but I see you've addd it to the .gitignore. So what's the plan? If we need to publish this to npm can you copy the workflow from react-native-onyx?

[blazejkustra]

Also, what is the plan for publishing this? Right now, expensify-common is consumed via a git hash in E/App's package.json

That could work if we commit dist, but I see you've addd it to the .gitignore. So what's the plan? If we need to publish this to npm can you copy the workflow from react-native-onyx?

I think copying the workflow from react-native-onyx makes the most sense, so that we consume the package from npm.

[blazejkustra]

@roryabraham I copied over the publish workflow from Onyx, I think the last thing we need is to add the missing secrets. Would you be able to copy it over from Onyx?

• OS_BOTIFY_COMMIT_TOKEN
• LARGE_SECRET_PASSPHRASE
• NPM_TOKEN

FYI: There is expensify-common in npm's registry already.

If you think this PR is too big, I can move publish workflow and related changes to a separate PR.

[blazejkustra]

Also, please have another look at the code, I changed it slightly! 🚀

[roryabraham]

LGTM but let's get those secrets added before we merge

[roryabraham]

Created internal ticket to add those GitHub secrets

[roryabraham]

Let's see if publishing works as expected... https://github.com/Expensify/expensify-common/actions/runs/9261388961

[github-actions]

🚀Published to npm in v2.0.1

[roryabraham]

Looks like that worked (after a few more minor adjustments) 🎉

[blazejkustra]

Awesome! Thanks @roryabraham for the help on this one 🙌