Update batching to be applied to useOnyx updates as well

[VickyStash]

Details

Before, the batch updates logic in the onyx was working for withOnyx subscribers only.
This PR extends that batching mechanism to also include useOnyx subscribers.
Previously, useOnyx subscribers could receive Onyx.update updates slightly out of sync, as some updates would arrive a bit earlier than others, causing extra re-renders and data missing -> it was reported here. It should be fixed with this PR.

Related Issues

#571

The issue was reported here: Expensify/App#66801 (comment)

Automated Tests

Manual Tests

Feel free to test updates over this PR.
That PR has E/App using onyx version 2.0.127 + this PR updates. I've done it this way since onyx upgrade to v2.0.130 was reverted.

1. Open the app.
2. Create a DM report that holds at least two expenses.
3. Go to Settings -> Troubleshoot -> Clear cache and restart
4. Go to Reports > Reports
5. Find the DM report and enter it.
6. The OpenReport API call will be triggered. Make sure that in the SearchMoneyRequestReportPage the response successData (ONYXKEYS.COLLECTION.REPORT_METADATA key specifically) is loaded at the same time as the returned by API report (ONYXKEYS.COLLECTION.REPORT) data.

Before	After
Successful data hasOnceLoadedReportActions: true is applied in metadata, but the report from the response isn't loaded yet. It appears a little later, though this data was provided in one Onyx.update	1. The report isn't loaded, isLoadingInitialReportActions: true in the metadata. 2. The report is loaded. Successful data hasOnceLoadedReportActions: true is applied in metadata

Besides that, let's make sure the basic app functionality works the same as before:

• Switch between chats. Make sure the data is loading as expected.
• Switch between app tabs. Make sure the data is loading as expected.
• Try to send several expenses. Update/delete them.
• Try to send several messages.

Author Checklist

• I linked the correct issue in the ### Related Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

[fabioh8010]

Please dont merge this yet, we are performing more tests...

[mountiny]

@TMisiukiewicz What is the merge strategy now? I would like to make sure we can first update Onyx in App without regressions. Was the previously found regression fixed already in main (sorry I cant recall now)

[TMisiukiewicz]

@mountiny Solution with last regression fixed waits for a merge there: #670 I think we can merge it and bump Onyx in E/App before moving forward with this one

[mountiny]

Merged that PR

[VickyStash]

Great, let's then wait till onyx version is bumped in the E/App - PR

[mollfpr]

The changes look good to me and have tested well!

[VickyStash]

Note: I'll be OOO tomorrow!

[shubham1206agra]

Add #571 as fixed issue.

[mountiny]

Waiting for the onyx bump go through

[VickyStash]

It looks like the previous bump PR was closed and we are waiting for a new one...

[mountiny]

Thank you!

[os-botify]

🚀 Published to npm in 2.0.135 🎉

[Pujan92]

@VickyStash I am not sure why but this false seems to cause below issue(passing true worked 😅 ), could you plz check once

Bug: Toggling the language preference back doesn't apply to the application.

Screen.Recording.2025-08-25.at.19.26.46.mov

[VickyStash]

Let me check!

[Pujan92]

Yes, I was testing PR and came to know about this issue.

[VickyStash]

@Pujan92 I was able to reproduce it on my end, but I need some time to figure out why it happens. I'll return to you tomorrow morning!

[Pujan92]

Thanks!

[VickyStash]

Okay, I've found out why it happens.

When we change the language, the app loads it and changes ONYXKEYS.ARE_TRANSLATIONS_LOADING flag here (to true) and here (to false).

The thing is that when the translations were already loaded before, they are cached and both ONYXKEYS.ARE_TRANSLATIONS_LOADING happen almost at the same moment, so they are batched together.

Due to that -> this hook doesn't work as expected -> causing the bug.

---

I think there can be other places like that in the app...
One of the ideas that I have is apply batching only if updates are coming from Onyx.update.
It also can easily be fixed on the app side, but I don't think it's a good idea