perf: speed up collection reads in tryGetCachedValue

[TMisiukiewicz]

Details

Related Issues

$ Expensify/App#68908

Automated Tests

As it is a pure performance optimization, no tests are needed. Performance tests running on CI in this PR shows improvements to tryGetCachedValue.

Manual Tests

1. Open the app
2. Verify the LHN is loaded
3. Go to any chat
4. Open modal -> Create expense
5. Go to Manual -> Next
6. Create an expense
7. Verify the expense is displayed in the chat

Author Checklist

• I linked the correct issue in the ### Related Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[TMisiukiewicz]

I just encountered a couple of failing tests in the E/App when testing this branch, lets hold with the review

[TMisiukiewicz]

I fixed one test suite, looks like the rest is coming from 2.1.135 version - OnyxDerivedTest -> updates when locale changes fails also on main

[mountiny]

@Pujan92 can you please test this change in App?

[Pujan92]

@TMisiukiewicz just to understand, is this optimization for those collection where the data might not be available and is undefined(like for those undefined we want to avoid the search loop for every useOnyx )? Bcoz I think for the common collections(report_, policy_, transaction_, etc..) there will be direct set of values from the below part instead of going into search part.

react-native-onyx/lib/OnyxUtils.ts

Lines 534 to 539 in 27f8a11

	if (isCollectionKey(key)) {
	const collectionData = cache.getCollectionData(key);
	const allCacheKeys = cache.getAllKeys();
	if (collectionData !== undefined && allCacheKeys.size > 0) {
	val = collectionData;
	} else {

[TMisiukiewicz]

@Pujan92 before, tryGetCachedValue was doing an expensive forEach loop through all cache keys to search for matches. Now, for collections that already have data → they get the pre-computed collectionData directly (fast path). For undefined/empty collections, instead of doing the expensive search loop and returning an empty object anyway, we now return {} immediately or undefined if keys aren't loaded yet. It's specifically optimizing those cases where we were doing unnecessary search loops for collections that don't have data, while keeping the fast access for populated collections.

[Pujan92]

Bug: Toggling the language preference back doesn't apply to the application. Weird bug but only happening in this PR and not with the react-native-onyx main. Sorry, my main wasn't updated. The error occurs on main and it might be from recent changes here.

Screen.Recording.2025-08-25.at.19.26.46.mov

[Pujan92]

Screenshots/Videos

Android: HybridApp

ap1.webm

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-08-26.at.12.09.03.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-08-26.at.12.11.04.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-08-26.at.11.34.06.mov

MacOS: Desktop

Screen.Recording.2025-08-26.at.12.02.07.mov

[Pujan92]

App works well

[Pujan92]

The only point is that earlier we used to store the collection member keys to the collection index but now we are storing the values in the collectionData. So the memory usage may increase.

[mountiny]

Thanks, changes look good to me! @AndrewGable do you want to review?

[os-botify]

🚀 Published to npm in 2.0.138 🎉