ci: trigger release-asset build on release.published#409
Merged
Conversation
Same fix as Extra-Chill/data-machine: the gate needs.homeboy.outputs.released == 'true' was relying on an output the homeboy-action ci.yml reusable workflow does not expose, so the ZIP build never fired. Moves the asset build to its own workflow file triggered on release.published. The release tag flows through github.event.release.tag_name without depending on the CI workflow's outputs. Adds a workflow_dispatch input for backfilling existing release tags.
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#408 added a
build-release-assetjob to.github/workflows/homeboy.ymlgated onneeds.homeboy.outputs.released == 'true'. The gate is broken: the reusable workflow atExtra-Chill/homeboy-action/.github/workflows/ci.yml@v2only exposes amatrixoutput, notreleased/release-tag. The job will skip on every future release run.Fix
Moves the asset build into its own
.github/workflows/release-asset.ymlfile triggered on therelease.publishedevent. The release tag flows throughgithub.event.release.tag_name— no dependency on the CI workflow's outputs.Also exposes a
workflow_dispatchinput so an existing tag can be backfilled by hand.Validation
Related
AI assistance