ci: trigger release-asset build on release.published#2034
Merged
Conversation
The homeboy.yml build-release-asset job gated on needs.homeboy.outputs.released == 'true', but the homeboy-action ci.yml reusable workflow only exposes a 'matrix' output, not 'released' or 'release-tag'. The gate evaluated to false on every release run and the ZIP never published. This moves the asset build to its own workflow file that fires on the release.published event. The release event tag flows through github.event.release.tag_name without depending on the CI workflow's outputs. Also adds a workflow_dispatch input so an existing release tag can be (re)built and uploaded by hand — useful for backfilling v0.116.0 which released after the previous PR landed but never got a ZIP.
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#2031 added a
build-release-assetjob to.github/workflows/homeboy.ymlgated onneeds.homeboy.outputs.released == 'true'. v0.116.0 was released after that PR merged. The job was skipped on every release run and the ZIP never published.Root cause: the reusable workflow at
Extra-Chill/homeboy-action/.github/workflows/ci.yml@v2only exposes amatrixoutput, notreleased/release-tag/release-version. Those outputs exist on homeboy-action's standalonerelease.ymlworkflow, but consumers calling theci.ymlreusable workflow don't get them. The gateneeds.homeboy.outputs.released == 'true'was always evaluating to false.Fix
Moves the asset build into its own
.github/workflows/release-asset.ymlfile triggered on therelease.publishedevent. The release tag flows throughgithub.event.release.tag_name— no dependency on the CI workflow's outputs.Also exposes a
workflow_dispatchinput so an existing tag can be backfilled by hand.Validation
gh release upload --clobbersemantics preserved.Backfill
After merge, run the new workflow against v0.116.0:
That will produce
data-machine.zipon the existing v0.116.0 release without needing a new tag.Related
AI assistance