Skip to content

Update to 1.21.5 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
modmuss50 wants to merge 1 commit into from
Closed

Update to 1.21.5 #316

modmuss50 wants to merge 1 commit into from

Conversation

@modmuss50
Copy link
Member

@modmuss50 modmuss50 commented Mar 25, 2025 •
edited
Loading

  • Get the mod to compile
  • Make sure I didnt break anything when porting
  • Update the docs pages related to the changes
  • appendTooltip is now deprecated, should it be using components?

Please feel free to make PRs into this branch.

@modmuss50 modmuss50 requested review from a team as code owners March 25, 2025 18:59
@netlify
Copy link

netlify bot commented Mar 25, 2025 •
edited
Loading

✅ Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit c8d3c45
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/67e2fd162c57460008ad9ed2
😎 Deploy Preview https://deploy-preview-316--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@its-miroma its-miroma added todo:verify This needs to be reviewed new-version Related to a newer version of Minecraft priority:low This is nice to have, but it can wait a little priority:medium This should be addressed relatively quickly and removed priority:low This is nice to have, but it can wait a little labels Mar 26, 2025
its-miroma

This comment was marked as resolved.

Sign in to view

@its-miroma its-miroma changed the title Port to 1.21.5 Update to 1.21.5 Mar 26, 2025
@its-miroma its-miroma removed the priority:medium This should be addressed relatively quickly label Mar 26, 2025
@IMB11 IMB11 linked an issue Apr 5, 2025 that may be closed by this pull request
Developer Guides: Model generation #319
Closed
@its-miroma its-miroma linked an issue Apr 26, 2025 that may be closed by this pull request
SwordItem class not found? #325
Closed
@its-miroma its-miroma added todo:expand This should be expanded priority:high This should be addressed before anything else and removed todo:verify This needs to be reviewed labels May 1, 2025
@its-miroma its-miroma linked an issue Jun 2, 2025 that may be closed by this pull request
"validateTicker" NOT FOUND #333
Closed
This was linked to issues Aug 2, 2025
Screen documentation for ~1.21.6-1.21.8: Change in functionality to color arguments in text rendering methods #340
Closed
missing reference to item model definition #337
Closed
TotalSync
TotalSync reviewed Aug 7, 2025
View reviewed changes
Copy link

@TotalSync TotalSync left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the gradle updates and anything pertaining to blocks and items. I am not comfortable enough with the rendering to give it the go-ahead. If I get more time, I will circle back and see if I can validate it.

This was unlinked from issues Aug 11, 2025
Developer Guides: Model generation #319
Closed
SwordItem class not found? #325
Closed
"validateTicker" NOT FOUND #333
Closed
missing reference to item model definition #337
Closed
Screen documentation for ~1.21.6-1.21.8: Change in functionality to color arguments in text rendering methods #340
Closed
This was linked to issues Aug 11, 2025
Developer Guides: Model generation #319
Closed
Upgrade to 1.21.8 #344
Closed
This was linked to issues Aug 11, 2025
Screen documentation for ~1.21.6-1.21.8: Change in functionality to color arguments in text rendering methods #340
Closed
Developer Guides: Data Attachment API #341
Closed
missing reference to item model definition #337
Closed
"validateTicker" NOT FOUND #333
Closed
SwordItem class not found? #325
Closed
@dicedpixels dicedpixels mentioned this pull request Aug 12, 2025
Merged
9 tasks
@its-miroma
Copy link
Member

its-miroma commented Aug 17, 2025

superseded by #347

@its-miroma its-miroma closed this Aug 17, 2025
@its-miroma its-miroma added not-accepted This doesn't look right and removed todo:expand This should be expanded labels Aug 17, 2025
This was unlinked from issues Aug 18, 2025
Developer Guides: Model generation #319
Closed
SwordItem class not found? #325
Closed
"validateTicker" NOT FOUND #333
Closed
missing reference to item model definition #337
Closed
Screen documentation for ~1.21.6-1.21.8: Change in functionality to color arguments in text rendering methods #340
Closed
Developer Guides: Data Attachment API #341
Closed
Upgrade to 1.21.8 #344
Closed
@its-miroma its-miroma removed new-version Related to a newer version of Minecraft priority:high This should be addressed before anything else labels Oct 14, 2025
@modmuss50 modmuss50 deleted the port/1.21.5 branch January 5, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@its-miroma its-miroma its-miroma left review comments

+1 more reviewer

@TotalSync TotalSync TotalSync left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@modmuss50 modmuss50

@IMB11 IMB11

Labels

not-accepted This doesn't look right

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@modmuss50 @its-miroma @TotalSync @IMB11