Skip to content

Conversation

@dicedpixels
Copy link
Contributor

@dicedpixels dicedpixels commented Aug 12, 2025

supersedes and closes #316
supersedes and closes #331
closes #344

Maintainer TODO:

Original Comment

Changes

Reference Mod:

  • Update Gradle, Loom, Fabric API, Fabric Loader to support 1.21.8.
  • FabricDocsReferenceItemTagProvider now extends FabricTagProvider.ItemTagProvider, docs are updated to reflect this.
  • HudRenderingEntrypoint now uses HudElementRegistry, docs are updated to reflect this.
  • RenderingConceptsEntrypoint commented out. I couldn't figure this out.
  • Regenerate all JSON files.
  • CounterBlockEntity now overrides writeData and readData, docs are updated to reflect this.
  • FabricDocsReferenceCommands has a new call to cast. Vanilla also does this.

Docs:

  • Block Entities/Saving and Loading Data → Updated to reflect WriteView/ReadView changes. Text adapted from the Fabric blog.
  • Data Generation/Block Model Generation/Custom BlockModelDefinitionCreator Method → Now based on the new code. Text is also updated.
  • Data Generation/Tag Generation → Now updated to use FabricTagProvider.ItemTagProvider. The generic tag generation process is mentioned.
  • Items/Tools and Weapons → Includes a mention to REPAIRS_GUIDITE_ARMOR.
  • Items/Custom Armor → Includes a mention to REPAIRS_GUIDITE_ARMOR.
  • Loom → Fix broken link to Getting Started/Introduction to Fabric and Modding page.
  • Rendering/Rendering in the HUD → Updated for HudElementRegistry and references to tickDelta are replaced with tickProgress.

@netlify
Copy link

netlify bot commented Aug 12, 2025

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit a08e36c
🔍 Latest deploy log https://app.netlify.com/projects/nimble-elf-d9d491/deploys/68a327acde097d0008c2dd08
😎 Deploy Preview https://deploy-preview-347--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cputnam-a11y

This comment was marked as resolved.

@dicedpixels

This comment was marked as resolved.

@dicedpixels dicedpixels marked this pull request as ready for review August 13, 2025 11:24
@dicedpixels dicedpixels requested review from a team as code owners August 13, 2025 11:24
@dicedpixels
Copy link
Contributor Author

Removed the Basic Rendering Concepts page from the navigator and 2 links that were pointing to it. The remaining rendering pages should be isolated enough to be on their own. Once someone helps out with the rendering changes, we can add them back.

its-miroma

This comment was marked as outdated.

@dicedpixels

This comment was marked as resolved.

@cassiancc
Copy link
Member

My two cents on appendTooltip - it's still the only good way to add a tooltip to an item, not a component. While having docs on the ComponentTooltipAppenderRegistry would be a worthwhile enhancement, it should not be a blocker on this PR while appendTooltip still exists and functions as intended.

@its-miroma its-miroma added todo:verify This needs to be reviewed new-version Related to a newer version of Minecraft priority:high This should be addressed before anything else labels Aug 20, 2025
@modmuss50
Copy link
Member

Lets just merge this, any issues can be fixed in follow up PRs. Big thanks for this.

@modmuss50 modmuss50 merged commit 9886aab into FabricMC:main Sep 7, 2025
7 checks passed
@its-miroma its-miroma added stage:ready and removed todo:verify This needs to be reviewed labels Sep 20, 2025
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 14, 2025
* Port to 1.21.5

* update reference mod to 1.21.8, excluding 'rendering/basic-concepts'

* remove unused reference, fix block entity renderer text

* update docs

* Add a note on 1.21.6's change to text rendering

* add block models page link to data generation setup page

* remove the rendering concepts page from the navigator, minor fixes

* update version numbers

* sync with upstream, fix game tests, checkstyle fixes

* fix typo

* fix spotless violations

---------

Co-authored-by: modmuss50 <modmuss50@gmail.com>
Co-authored-by: Cassian Godsted <cassian@godsted.com>
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>

(cherry picked from commit 9886aab)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 14, 2025
* Port to 1.21.5

* update reference mod to 1.21.8, excluding 'rendering/basic-concepts'

* remove unused reference, fix block entity renderer text

* update docs

* Add a note on 1.21.6's change to text rendering

* add block models page link to data generation setup page

* remove the rendering concepts page from the navigator, minor fixes

* update version numbers

* sync with upstream, fix game tests, checkstyle fixes

* fix typo

* fix spotless violations

---------

Co-authored-by: modmuss50 <modmuss50@gmail.com>
Co-authored-by: Cassian Godsted <cassian@godsted.com>
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>

(cherry picked from commit 9886aab)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 15, 2025
* Port to 1.21.5

* update reference mod to 1.21.8, excluding 'rendering/basic-concepts'

* remove unused reference, fix block entity renderer text

* update docs

* Add a note on 1.21.6's change to text rendering

* add block models page link to data generation setup page

* remove the rendering concepts page from the navigator, minor fixes

* update version numbers

* sync with upstream, fix game tests, checkstyle fixes

* fix typo

* fix spotless violations

---------

Co-authored-by: modmuss50 <modmuss50@gmail.com>
Co-authored-by: Cassian Godsted <cassian@godsted.com>
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>

(cherry picked from commit 9886aab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-version Related to a newer version of Minecraft priority:high This should be addressed before anything else

Projects

None yet

5 participants