Entity Attributes page #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cprodhomme
force-pushed
the
entity-attributes
branch
2 times, most recently
from
fd0c91f to
0076032
Compare
its-miroma
added
new-content
its-miroma
requested changes
Apr 6, 2025
Member
its-miroma
left a comment
its-miroma
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Mine are a few style nitpicks, a more thorough content verification is still needed
cprodhomme
force-pushed
the
entity-attributes
branch
3 times, most recently
from
d93e794 to
6792a18
Compare
Contributor
Author
All done ! Thank you for your feedback :) |
Contributor
Author
|
Oh, I ran into a few errors—I'll take a look. |
cprodhomme
force-pushed
the
entity-attributes
branch
2 times, most recently
from
550417a to
d7652cd
Compare
cprodhomme
force-pushed
the
entity-attributes
branch
5 times, most recently
from
2e33c9b to
3307e6f
Compare
Contributor
Author
|
Not sure to know how to correct the last error @its-miroma |
its-miroma
reviewed
Apr 9, 2025
reference/latest/src/main/java/com/example/docs/entity/attribute/ModEntityAttributes.java
Outdated
Show resolved
Hide resolved
cprodhomme
force-pushed
the
entity-attributes
branch
from
3307e6f to
1562bae
Compare
Contributor
Author
|
All done @its-miroma |
Contributor
|
Might be just a nitpick, but javadocs in the example code look a bit chaotic with the syntax highlightng.
If you decide to change it, you could either use normal comments or just exclude it from the page view and describe the content on the page itself. But like i said earlier, this might just be my preference. ^^ |
its-miroma
requested changes
Dec 2, 2025
Co-authored-by: Miroma <its.miroma@proton.me>
its-miroma
previously approved these changes
Dec 2, 2025
its-miroma
requested review from
cassiancc and
ekulxam
and removed request for
ekulxam
cassiancc
previously approved these changes
Dec 5, 2025
ekulxam
suggested changes
Dec 5, 2025
ekulxam
suggested changes
Dec 8, 2025
Co-authored-by: SkyNotTheLimit <159592458+ekulxam@users.noreply.github.com>
cassiancc
previously approved these changes
Dec 8, 2025
ekulxam
suggested changes
Dec 8, 2025
Contributor
|
Otherwise, I have no further comments. |
Co-authored-by: SkyNotTheLimit <159592458+ekulxam@users.noreply.github.com>
Updated attribute registration parameters for clarity.
ekulxam
approved these changes
Dec 8, 2025
cassiancc
approved these changes
Dec 8, 2025
its-miroma
added a commit
to its-miroma/fmc
that referenced
this pull request
Dec 9, 2025
* main: Developer Guides: revise "Introduction to Fabric" (FabricMC#401) Entity Attributes page (FabricMC#320) Data Attachment Docs (FabricMC#405) Call `setDirty()` Only When Data is Changed (FabricMC#424) Avoid use of first person (FabricMC#423) fix item tooltip, add() -> accept() (FabricMC#422) Fix edit on GitHub links (FabricMC#421)
its-miroma
added a commit
to its-miroma/fmc
that referenced
this pull request
Dec 9, 2025
* plugins: lowercase mixin format sidebar mention first unobfuscated version npm audit fix add tabs plugin Developer Guides: revise "Introduction to Fabric" (FabricMC#401) Entity Attributes page (FabricMC#320) Data Attachment Docs (FabricMC#405) Call `setDirty()` Only When Data is Changed (FabricMC#424) Avoid use of first person (FabricMC#423) fix item tooltip, add() -> accept() (FabricMC#422) Fix edit on GitHub links (FabricMC#421)
its-miroma
added a commit
to Earthcomputer/fabric-docs
that referenced
this pull request
Dec 9, 2025
* main: add tabs plugin (FabricMC#425) Developer Guides: revise "Introduction to Fabric" (FabricMC#401) Entity Attributes page (FabricMC#320) Data Attachment Docs (FabricMC#405) Call `setDirty()` Only When Data is Changed (FabricMC#424) Avoid use of first person (FabricMC#423) fix item tooltip, add() -> accept() (FabricMC#422) Fix edit on GitHub links (FabricMC#421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.