Data Attachment Docs #405
Merged
Data Attachment Docs #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cassiancc
added
new-content
DennisOchulor
suggested changes
Dec 3, 2025
Contributor
DennisOchulor
left a comment
DennisOchulor
left a comment
There was a problem hiding this comment.
Not sure if it's really necessary, but the attachment change event could use a little section about it.
Co-authored-by: DennisOchulor <113277083+DennisOchulor@users.noreply.github.com>
DennisOchulor
suggested changes
Dec 4, 2025
reference/latest/src/main/java/com/example/docs/attachment/Stamina.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/attachment/Stamina.java
Outdated
Show resolved
Hide resolved
Co-authored-by: DennisOchulor <113277083+DennisOchulor@users.noreply.github.com>
ekulxam
reviewed
Dec 4, 2025
Contributor
ekulxam
left a comment
ekulxam
left a comment
There was a problem hiding this comment.
I already left most of my comments in https://discord.com/channels/507304429255393322/1440182041952915518, just have a few questions.
dicedpixels
previously approved these changes
Dec 4, 2025
its-miroma
requested changes
Dec 4, 2025
Member
its-miroma
left a comment
its-miroma
left a comment
There was a problem hiding this comment.
clear article, but a bit wordy. I've simplified and shortened some parts. Also, consider adding as many code blocks to the reference as possible, especially since this API is experimental and might change in the future.
Co-authored-by: Miroma <its.miroma@proton.me>
its-miroma
requested changes
Dec 4, 2025
Co-authored-by: Miroma <its.miroma@proton.me>
its-miroma
requested changes
Dec 4, 2025
Member
its-miroma
left a comment
its-miroma
left a comment
There was a problem hiding this comment.
I capitalized Data Attachment. LGTM
reference/latest/src/main/java/com/example/docs/attachment/ExampleModAttachments.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/attachment/ExampleModAttachments.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/attachment/ExampleModAttachments.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/attachment/ExampleModAttachments.java
Outdated
Show resolved
Hide resolved
reference/latest/src/main/java/com/example/docs/attachment/ExampleModAttachments.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Miroma <its.miroma@proton.me>
its-miroma
approved these changes
Dec 4, 2025
ekulxam
approved these changes
Dec 4, 2025
Contributor
ekulxam
left a comment
ekulxam
left a comment
There was a problem hiding this comment.
All my comments have been resolved.
dicedpixels
approved these changes
Dec 5, 2025
ekulxam
approved these changes
Dec 5, 2025
its-miroma
added a commit
to its-miroma/fmc
that referenced
this pull request
Dec 9, 2025
* main: Developer Guides: revise "Introduction to Fabric" (FabricMC#401) Entity Attributes page (FabricMC#320) Data Attachment Docs (FabricMC#405) Call `setDirty()` Only When Data is Changed (FabricMC#424) Avoid use of first person (FabricMC#423) fix item tooltip, add() -> accept() (FabricMC#422) Fix edit on GitHub links (FabricMC#421)
its-miroma
added a commit
to its-miroma/fmc
that referenced
this pull request
Dec 9, 2025
* plugins: lowercase mixin format sidebar mention first unobfuscated version npm audit fix add tabs plugin Developer Guides: revise "Introduction to Fabric" (FabricMC#401) Entity Attributes page (FabricMC#320) Data Attachment Docs (FabricMC#405) Call `setDirty()` Only When Data is Changed (FabricMC#424) Avoid use of first person (FabricMC#423) fix item tooltip, add() -> accept() (FabricMC#422) Fix edit on GitHub links (FabricMC#421)
its-miroma
added a commit
to Earthcomputer/fabric-docs
that referenced
this pull request
Dec 9, 2025
* main: add tabs plugin (FabricMC#425) Developer Guides: revise "Introduction to Fabric" (FabricMC#401) Entity Attributes page (FabricMC#320) Data Attachment Docs (FabricMC#405) Call `setDirty()` Only When Data is Changed (FabricMC#424) Avoid use of first person (FabricMC#423) fix item tooltip, add() -> accept() (FabricMC#422) Fix edit on GitHub links (FabricMC#421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the new Data Attachment API, including info on syncing, persistence, saving and writing, as well as a simplified example of the Facade Pattern discussed by modmuss.
https://deploy-preview-405--nimble-elf-d9d491.netlify.app/develop/data-attachments
Fixes #341