Blocks: Block Models #364
Merged
Blocks: Block Models #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com>
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
its-miroma
added
new-content
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
Thanks for the fast replies, I'll try the approach you suggested and see how it goes. |
Fellteros
commented
Sep 21, 2025
develop/blocks/block-models.md
Outdated
| } | ||
| ``` | ||
|
|
||
| 1. `rotation`: _Three floats_. Specifies the rotation of the model according to the scheme `[x, y, z]`. |
Contributor
Author
There was a problem hiding this comment.
@its-miroma What do you think about adding non-breaking spaces to the "[x, y, z]" part? It looks weird when it's soft wrapped (see the image). I know that there is a lint rule that forbids this, but in this case, I think it would be reasonable
Member
There was a problem hiding this comment.
You may do it and ignore the false positive, I'll push an exception to the markdownlint config.
But I think that flipping the sentence structure might fix this issue and be clearer, something like:
1. `rotation` (`float [x, y, z]`): Specifies the rotation of the model.
Contributor
Author
There was a problem hiding this comment.
Well there are other places where that can't be applied, so I think I'll stick with my original idea. thx for the suggestion though
Co-authored-by: 136986257+its-miroma@users.noreply.github.com Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com>
its-miroma
approved these changes
Sep 23, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
its-miroma
approved these changes
Sep 28, 2025
modmuss50
approved these changes
Oct 6, 2025
its-miroma
added a commit
to dicedpixels/fabric-docs
that referenced
this pull request
Oct 12, 2025
* upstream/main: Update Docs to 1.21.10 (FabricMC#369) uniform sidebar translations keys (FabricMC#370) fix image z-index (FabricMC#368) Blocks: Block Models (FabricMC#364) Split IDE-Specific Pages (FabricMC#366) Notes on Creating a Project (FabricMC#367) Rendering in the world and custom render pipelines (FabricMC#365)
kevinthegreat1
pushed a commit
to kevinthegreat1/fabric-docs
that referenced
this pull request
Oct 14, 2025
* Added Block Models page * Markdown lint changes * Minor tweaks * update block-models.md to 1.21.8, style changes, lint Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> * made changes according to miroma's suggestions Co-authored-by: 136986257+its-miroma@users.noreply.github.com Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> * lint Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> * Add nbsps where reasonable * Apply suggestion from @its-miroma * Apply suggestion from @its-miroma * Apply suggestion from @its-miroma * Small grammatical changes --------- Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit a70cfe3)
kevinthegreat1
pushed a commit
to kevinthegreat1/fabric-docs
that referenced
this pull request
Oct 14, 2025
* Added Block Models page * Markdown lint changes * Minor tweaks * update block-models.md to 1.21.8, style changes, lint Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> * made changes according to miroma's suggestions Co-authored-by: 136986257+its-miroma@users.noreply.github.com Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> * lint Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> * Add nbsps where reasonable * Apply suggestion from @its-miroma * Apply suggestion from @its-miroma * Apply suggestion from @its-miroma * Small grammatical changes --------- Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit a70cfe3)
kevinthegreat1
pushed a commit
to kevinthegreat1/fabric-docs
that referenced
this pull request
Oct 15, 2025
* Added Block Models page * Markdown lint changes * Minor tweaks * update block-models.md to 1.21.8, style changes, lint Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> * made changes according to miroma's suggestions Co-authored-by: 136986257+its-miroma@users.noreply.github.com Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> * lint Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> * Add nbsps where reasonable * Apply suggestion from @its-miroma * Apply suggestion from @its-miroma * Apply suggestion from @its-miroma * Small grammatical changes --------- Signed-off-by: Fellteros <144528463+Fellteros@users.noreply.github.com> Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit a70cfe3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #324 got merged recently, I made a similar page for block models. It's basically the same, just for blocks