-
Notifications
You must be signed in to change notification settings - Fork 247
Rendering in the world and custom render pipelines #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
LGTM! |
its-miroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Minor changes then LGTM!
If "drawing" is considered a synonym for the "rendering" (second) phase, it would be clearer if we used it everywhere. Also, I've seen "preparation" referring to extraction, maybe we should take a look at that also. Maybe something like:
- Rendering is composed of two phases: extraction, which prepares the render state, and drawing.
reference/latest/src/client/java/com/example/docs/rendering/CustomRenderPipeline.java
Show resolved
Hide resolved
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
its-miroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@modmuss50 we need your approval because of a change to checkstyle config |
* upstream/main: Notes on Creating a Project (FabricMC#367) Rendering in the world and custom render pipelines (FabricMC#365)
* upstream/main: Notes on Creating a Project (FabricMC#367) Rendering in the world and custom render pipelines (FabricMC#365)
* upstream/main: Update Docs to 1.21.10 (FabricMC#369) uniform sidebar translations keys (FabricMC#370) fix image z-index (FabricMC#368) Blocks: Block Models (FabricMC#364) Split IDE-Specific Pages (FabricMC#366) Notes on Creating a Project (FabricMC#367) Rendering in the world and custom render pipelines (FabricMC#365)
* Rendering in the world * Lint * Allow comments after block * Apply suggestions from code review Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> * Clean up phases * Update phases explanation --------- Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit 5cf3406)
* Rendering in the world * Lint * Allow comments after block * Apply suggestions from code review Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> * Clean up phases * Update phases explanation --------- Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit 5cf3406)
* Rendering in the world * Lint * Allow comments after block * Apply suggestions from code review Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> * Clean up phases * Update phases explanation --------- Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit 5cf3406)
This guide covers some world rendering concepts and changes in new versions, which have become very confusing for modders. The idea is that this guide covers both concepts (the "extraction" and "drawing" split) and gives a concrete example of how to render in the world using a custom render pipeline.
While I understand this API may change in the future, there is currently no good guide on how to render in the world in versions 1.21.6-1.21.8. This guide covers these versions, and currently works in the 1.21.9 snapshots as well.
I am aware that
WorldRenderEventsis being replaced to better serve usages like this, and I will update this using the new API when it becomes available for 1.21.9 and above. But as of now, I think it will be beneficial to have a guide covering versions 1.21.6-1.21.8.This is a bit technical and confusing for me. If there are better ways of doing what I'm doing, please let me know, because this is what I'm doing in my mods, and I would definitely appreciate a simpler way.