V1 rollup testing #108
Merged
V1 rollup testing #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that existed at or before the given height
…alid keys, replacing keys, signing attributes and endorsements
…ven the public key
…t-height response
…g the hash of the content instead, so that it fits within the ledger's buffer
Emyrk
reviewed
Jun 13, 2019
Contributor
Emyrk
left a comment
Emyrk
left a comment
There was a problem hiding this comment.
This is a big one, only did a first pass review looking at comments and verifying the enterprise-wallet still builds against the refactor 👍
Emyrk
reviewed
Jun 14, 2019
Contributor
Emyrk
left a comment
Emyrk
left a comment
There was a problem hiding this comment.
Only change I think should be made is to verify the glide.lock file. It looks like it could be pruned
Corrected some dependencies in the lock file for unit tests
Yml files cannot handle tabs
Fd 1059 circle ci
Contributor
|
Added circle integration to verify PR build |
Emyrk
approved these changes
Jun 17, 2019
| // TransactionData is metadata about a given Transaction, including data about | ||
| // the Transaction Status (i.e. weather the Transaction has been written to the | ||
| // Blockchain). | ||
| type TransactionData struct { |
| func EntryCommitACK(txID, fullTransaction string) (*EntryStatus, error) { | ||
| params := ackRequest{Hash: txID, ChainID: "c", FullTransaction: fullTransaction} | ||
| // FactoidACK gets the status of a given Factoid Transaction. | ||
| func FactoidACK(txID, fullTransaction string) (*FactoidTxStatus, error) { |
| func FactoidACK(txID, fullTransaction string) (*FactoidTxStatus, error) { | ||
| params := ackRequest{Hash: txID, ChainID: "f", FullTransaction: fullTransaction} | ||
| // EntryCommitACK searches for an entry/chain commit with a given transaction ID. | ||
| func EntryCommitACK(txID, fullTransaction string) (*EntryStatus, error) { |
| return base58.Encode(buf.Bytes()) | ||
| } | ||
|
|
||
| // ParseMnemonic parse and validate a bip39 mnumonic string. Remove extra |
| @@ -1,178 +0,0 @@ | |||
| // Copyright 2016 Factom Foundation | |||
| return r.Entry, nil | ||
| } | ||
|
|
||
| // GetChainHead returns the hash of the most recent Entry made into a given |
| } | ||
|
|
||
| // GetAllChainEntries returns a list of all Factom Entries for a given Chain. | ||
| func GetAllChainEntries(chainid string) ([]*Entry, error) { |
| // GetAllChainEntriesAtHeight returns a list of all Factom Entries for a given | ||
| // Chain at a given point in the Chain's history. | ||
| func GetAllChainEntriesAtHeight(chainid string, height int64) ([]*Entry, error) { | ||
| es := make([]*Entry, 0) |
Contributor
There was a problem hiding this comment.
I feel this could be refactored to share most of the code with GetAllChainEntries
| } | ||
|
|
||
| // GetEntry requests an Entry from the factomd API by its Entry Hash | ||
| func GetEntry(hash string) (*Entry, error) { |
| } | ||
|
|
||
| // GetHeights requests the list of heights from the factomd API. | ||
| func GetHeights() (*HeightsResponse, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry for the mess. This PR should cover FD-961 and FD-963