Skip to content

feat: make health check configurable#122

Merged
matthewelwell merged 6 commits intomainfrom
feat/make-health-check-configurable
Sep 4, 2024
Merged

feat: make health check configurable#122
matthewelwell merged 6 commits intomainfrom
feat/make-health-check-configurable

Conversation

@matthewelwell
Copy link
Copy Markdown
Contributor

This PR looks to solve #120.

It does so by making certain aspects of the health check configurable, with the bear minimum health check being to confirm that the environment document has been updated at some point.

@matthewelwell
Copy link
Copy Markdown
Contributor Author

My main concern with the current approach in this PR is how health checks will handle start up when environment_service.last_updated is expected to be null. I think this is fine, although thinking about it, the behaviour would have been the same before because we would have just suppressed the TypeError and returned status_code=500.

@matthewelwell matthewelwell marked this pull request as ready for review September 4, 2024 10:37
…ble' into feat/make-health-check-configurable
@gagantrivedi
Copy link
Copy Markdown
Member

My main concern with the current approach in this PR is how health checks will handle start up when environment_service.last_updated is expected to be null. I think this is fine, although thinking about it, the behaviour would have been the same before because we would have just suppressed the TypeError and returned status_code=500.

Yeah, I think that should be the responsibility of the service to give some grace period for the proxy to become healthy

Comment thread src/edge_proxy/server.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants