feat: remove unnecessary setting health_check.count_stale_documents_as_failing#123
Merged
matthewelwell merged 2 commits intomainfrom Sep 4, 2024
Merged
Conversation
rolodato
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a conversation with @rolodato on Flagsmith/flagsmith#4580, I have updated the settings added in #122 to remove the boolean setting used to configure the essentially 'infinite grace period' and replaced it with the option to set the grace period to null. In order to help with the readability though, I have also renamed the grace period field.
Note: since the documentation has not been released for the original settings, I plan to release this as a minor update with a mention in the notes about the breaking settings changes.