Skip to content

feat(evaluation-context): Add ApplicationEvaluationContext, document schema fields#5203

Closed
khvn26 wants to merge 3 commits intomainfrom
feat/application-evaluation-context
Closed

feat(evaluation-context): Add ApplicationEvaluationContext, document schema fields#5203
khvn26 wants to merge 3 commits intomainfrom
feat/application-evaluation-context

Conversation

@khvn26
Copy link
Copy Markdown
Member

@khvn26 khvn26 commented Mar 10, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This adds ApplicationEvaluationContext to the shared SDK evaluation context schema used by Golang and JS SDKs.

I also added descriptions to the new and current fields.

How did you test this code?

N/A

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 9:55am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 9:55am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 9:55am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 10, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5203 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5203 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5203 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5203 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5203 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5203 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 10, 2025

Uffizzi Preview deployment-61730 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Mar 10, 2025
@khvn26 khvn26 requested a review from kyle-ssg March 10, 2025 19:42
@khvn26 khvn26 assigned tiagoapolo and unassigned tiagoapolo Mar 10, 2025
Comment thread sdk/evaluation-context.json Outdated
Comment thread sdk/evaluation-context.json Outdated
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Mar 11, 2025
@matthewelwell
Copy link
Copy Markdown
Contributor

@khvn26 I'd love to see more description in this PR for future reference if needed. Since I'm not fully aligned on the evaluation context functionality in general, I'm a little unsure on the addition of the Application context here.

For example, let's link it to Tiago's PR in the js client repository and explain whether it complements or supersedes that PR.

Also, can you add an example usage or the plans for how it should be used. By adding it to the evaluation context, it seems like we're suggesting that it should / could be used for evaluation purposes but as I've mentioned before, my understanding was that this data was (primarily at least) for the purpose of having visibility on where API traffic was originating from.

@matthewelwell matthewelwell removed their request for review March 13, 2025 10:26
@kyle-ssg
Copy link
Copy Markdown
Member

Im going to approve this as it looks like there'd be no breaking changes to SDKs, I agree with Matt's comments however - I don't fully understand what this means for the SDKs and if any further work is required to support this. Does the JS SDK need to just do a new build to pull in the updated types?

@khvn26
Copy link
Copy Markdown
Member Author

khvn26 commented Mar 18, 2025

I'm going to close this for now as we're not going to support evaluation for these fields for a while and there's no alignment yet in the team about it.

I will, however, open a separate PR adding field descriptions to existing schema.

@khvn26 khvn26 closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants