feat(evaluation-context): Add ApplicationEvaluationContext, document schema fields#5203
feat(evaluation-context): Add ApplicationEvaluationContext, document schema fields#5203
ApplicationEvaluationContext, document schema fields#5203Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
|
@khvn26 I'd love to see more description in this PR for future reference if needed. Since I'm not fully aligned on the evaluation context functionality in general, I'm a little unsure on the addition of the Application context here. For example, let's link it to Tiago's PR in the js client repository and explain whether it complements or supersedes that PR. Also, can you add an example usage or the plans for how it should be used. By adding it to the evaluation context, it seems like we're suggesting that it should / could be used for evaluation purposes but as I've mentioned before, my understanding was that this data was (primarily at least) for the purpose of having visibility on where API traffic was originating from. |
|
Im going to approve this as it looks like there'd be no breaking changes to SDKs, I agree with Matt's comments however - I don't fully understand what this means for the SDKs and if any further work is required to support this. Does the JS SDK need to just do a new build to pull in the updated types? |
|
I'm going to close this for now as we're not going to support evaluation for these fields for a while and there's no alignment yet in the team about it. I will, however, open a separate PR adding field descriptions to existing schema. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
This adds
ApplicationEvaluationContextto the shared SDK evaluation context schema used by Golang and JS SDKs.I also added descriptions to the new and current fields.
How did you test this code?
N/A