Skip to content

#4940 Fix for build on Mac#4941

Merged
rrrooommmaaa merged 2 commits intomasterfrom
bugfix/issue-4940-fix-mac-build
Feb 7, 2023
Merged

#4940 Fix for build on Mac#4941
rrrooommmaaa merged 2 commits intomasterfrom
bugfix/issue-4940-fix-mac-build

Conversation

@sosnovsky
Copy link
Collaborator

This PR fixes extension building in macOS

close #4940


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@rrrooommmaaa rrrooommmaaa merged commit 0730dc4 into master Feb 7, 2023
@rrrooommmaaa rrrooommmaaa deleted the bugfix/issue-4940-fix-mac-build branch February 7, 2023 12:21
@rrrooommmaaa
Copy link
Contributor

Hi @sosnovsky
I'm having the bak files piling up after each build. Perhaps, it'd be better to delete them?
image

@sosnovsky
Copy link
Collaborator Author

@rrrooommmaaa I updated build script to not produce .bak files in new PR - #4945
macOS and Linux have a bit different syntaxes for sed command, so I just added conditional check for the current OS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trouble building the extension

2 participants