#4940 Update build script to not produce .bak files#4945
Merged
rrrooommmaaa merged 2 commits intomasterfrom Feb 9, 2023
Merged
#4940 Update build script to not produce .bak files#4945rrrooommmaaa merged 2 commits intomasterfrom
rrrooommmaaa merged 2 commits intomasterfrom
Conversation
rrrooommmaaa
reviewed
Feb 9, 2023
scripts/build.sh
Outdated
| # until https://github.com/openpgpjs/web-stream-tools/pull/20 is resolved | ||
| sed -i.bak -E "s/'\.\/(streams|util|writer|reader|node-conversions)'/'\.\/\1\.js'/g" $OUTDIR/lib/streams/* | ||
| STREAMS_REGEX="s/'\.\/(streams|util|writer|reader|node-conversions)'/'\.\/\1\.js'/g" | ||
| STREAMS_OUTDIR=$OUTDIR/lib/streams/* |
Contributor
There was a problem hiding this comment.
This is more like STREAMS_FILES than an "outdir"
rrrooommmaaa
approved these changes
Feb 9, 2023
FlowCryptRobot
pushed a commit
that referenced
this pull request
Feb 22, 2023
…#4943) * build(deps-dev): bump @openpgp/web-stream-tools from 0.0.11 to 0.0.13 Bumps [@openpgp/web-stream-tools](https://github.com/openpgpjs/web-stream-tools) from 0.0.11 to 0.0.13. - [Release notes](https://github.com/openpgpjs/web-stream-tools/releases) - [Commits](openpgpjs/web-stream-tools@v0.0.11...v0.0.13) --- updated-dependencies: - dependency-name: "@openpgp/web-stream-tools" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * #4282 fix: duplicated contact search result (#4944) * fix: dupliated contact search result * feat: added ui test * fix: pr review * #4940 Update build script to not produce .bak files (#4945) * update build script * rename STREAMS_OUTDIR to STREAMS_FILES * #4844 feat: renew id token when expires (#4949) * feat: renew id token when expires * fix: pr reviews * Employ user verification mechanisms from OpenPGP v5 (#4946) * reuse getPrimeryUser method * verifying key users * allow localhost domain for email address * fix * fix and test * use verified users in key-import-ui * PR review fixes --------- Co-authored-by: Roman Shevchenko <roman@flowcrypt.com> * prevent pasting large input on secure compose (#4914) * prevent pasting large input on secure compose * Added type definition for SquireEditor.getRoot() * apply requested change * update * cleanup * update * consider selection * add warning modal * update * update * update --------- Co-authored-by: Roman Shevchenko <rrrooommmaaa@mail.ru> Co-authored-by: Roman Shevchenko <roman@flowcrypt.com> * fix --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ioan Moldovan <mobilestar108@outlook.com> Co-authored-by: Roma Sosnovsky <roma.sosnovsky@gmail.com> Co-authored-by: Roman <rrrooommmaaa@mail.ru> Co-authored-by: Roman Shevchenko <roman@flowcrypt.com> Co-authored-by: Mart G <46025304+martgil@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes unnecessary
.bakfiles after extension buildclose #4940
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):